1
0
mirror of https://github.com/danog/psalm.git synced 2024-12-12 01:09:38 +01:00
psalm/src/Psalm/Checker/CommentChecker.php

949 lines
34 KiB
PHP
Raw Normal View History

2016-06-24 00:45:46 +02:00
<?php
namespace Psalm\Checker;
Refactor scanning and analysis, introducing multithreading (#191) * Add failing test * Add visitor to soup up classlike references * Move a whole bunch of code into the visitor * Move some methods back, move onto analysis stage * Use the getAliases method everywhere * Fix refs * Fix more refs * Fix some tests * Fix more tests * Fix include tests * Shift config class finding to project checker and fix bugs * Fix a few more tests * transition test to new syntax * Remove var_dump * Delete a bunch of code and fix mutation test * Remove unnecessary visitation * Transition to better mocked out file provider, breaking some cached statement loading * Use different scheme for naming anonymous classes * Fix anonymous class issues * Refactor file/statement loading * Add specific property types * Fix mapped property assignment * Improve how we deal with traits * Fix trait checking * Pass Psalm checks * Add multi-process support * Delay console output until the end * Remove PHP 7 syntax * Update file storage with classes * Fix scanning individual files and add reflection return types * Always turn XDebug off * Add quicker method of getting method mutations * Queue return types for crawling * Interpret all strings as possible classes once we see a `get_class` call * Check invalid return types again * Fix template namespacing issues * Default to class-insensitive file names for includes * Don’t overwrite existing issues data * Add var docblocks for scanning * Add null check * Fix loading of external classes in templates * Only try to populate class when we haven’t yet seen it’s not a class * Fix trait property accessibility * Only ever improve docblock param type * Make param replacement more robust * Fix static const missing inferred type * Fix a few more tests * Register constant definitions * Fix trait aliasing * Skip constant type tests for now * Fix linting issues * Make sure caching is off for tests * Remove unnecessary return * Use emulative parser if on PHP 5.6 * Cache parser for faster first-time parse * Fix constant resolution when scanning classes * Remove test that’s beyond a practical scope * Add back --diff support * Add --help for --threads * Remove unused vars
2017-07-25 22:11:02 +02:00
use Psalm\Aliases;
2016-11-02 07:29:00 +01:00
use Psalm\Exception\DocblockParseException;
use Psalm\Exception\IncorrectDocblockException;
use Psalm\Exception\TypeParseTreeException;
2018-01-21 18:44:46 +01:00
use Psalm\FileSource;
use Psalm\Scanner\ClassLikeDocblockComment;
use Psalm\Scanner\FunctionDocblockComment;
use Psalm\Scanner\VarDocblockComment;
use Psalm\Type;
2016-06-24 00:45:46 +02:00
class CommentChecker
{
const TYPE_REGEX = '(\??\\\?[\(\)A-Za-z0-9_&\<\.=,\>\[\]\-\{\}:|?\\\\]*|\$[a-zA-Z_0-9_]+)';
2016-06-24 00:45:46 +02:00
/**
* @param string $comment
Refactor scanning and analysis, introducing multithreading (#191) * Add failing test * Add visitor to soup up classlike references * Move a whole bunch of code into the visitor * Move some methods back, move onto analysis stage * Use the getAliases method everywhere * Fix refs * Fix more refs * Fix some tests * Fix more tests * Fix include tests * Shift config class finding to project checker and fix bugs * Fix a few more tests * transition test to new syntax * Remove var_dump * Delete a bunch of code and fix mutation test * Remove unnecessary visitation * Transition to better mocked out file provider, breaking some cached statement loading * Use different scheme for naming anonymous classes * Fix anonymous class issues * Refactor file/statement loading * Add specific property types * Fix mapped property assignment * Improve how we deal with traits * Fix trait checking * Pass Psalm checks * Add multi-process support * Delay console output until the end * Remove PHP 7 syntax * Update file storage with classes * Fix scanning individual files and add reflection return types * Always turn XDebug off * Add quicker method of getting method mutations * Queue return types for crawling * Interpret all strings as possible classes once we see a `get_class` call * Check invalid return types again * Fix template namespacing issues * Default to class-insensitive file names for includes * Don’t overwrite existing issues data * Add var docblocks for scanning * Add null check * Fix loading of external classes in templates * Only try to populate class when we haven’t yet seen it’s not a class * Fix trait property accessibility * Only ever improve docblock param type * Make param replacement more robust * Fix static const missing inferred type * Fix a few more tests * Register constant definitions * Fix trait aliasing * Skip constant type tests for now * Fix linting issues * Make sure caching is off for tests * Remove unnecessary return * Use emulative parser if on PHP 5.6 * Cache parser for faster first-time parse * Fix constant resolution when scanning classes * Remove test that’s beyond a practical scope * Add back --diff support * Add --help for --threads * Remove unused vars
2017-07-25 22:11:02 +02:00
* @param Aliases $aliases
* @param array<string, string>|null $template_type_names
2017-03-02 04:27:52 +01:00
* @param int|null $var_line_number
* @param int|null $came_from_line_number what line number in $source that $comment came from
2018-07-15 23:23:17 +02:00
* @param array<string, array<int, string>> $type_aliases
2017-05-27 02:16:18 +02:00
*
* @throws DocblockParseException if there was a problem parsing the docblock
*
* @return VarDocblockComment[]
* @psalm-suppress MixedArrayAccess
2016-06-24 00:45:46 +02:00
*/
2016-11-02 07:29:00 +01:00
public static function getTypeFromComment(
$comment,
2018-01-21 18:44:46 +01:00
FileSource $source,
Refactor scanning and analysis, introducing multithreading (#191) * Add failing test * Add visitor to soup up classlike references * Move a whole bunch of code into the visitor * Move some methods back, move onto analysis stage * Use the getAliases method everywhere * Fix refs * Fix more refs * Fix some tests * Fix more tests * Fix include tests * Shift config class finding to project checker and fix bugs * Fix a few more tests * transition test to new syntax * Remove var_dump * Delete a bunch of code and fix mutation test * Remove unnecessary visitation * Transition to better mocked out file provider, breaking some cached statement loading * Use different scheme for naming anonymous classes * Fix anonymous class issues * Refactor file/statement loading * Add specific property types * Fix mapped property assignment * Improve how we deal with traits * Fix trait checking * Pass Psalm checks * Add multi-process support * Delay console output until the end * Remove PHP 7 syntax * Update file storage with classes * Fix scanning individual files and add reflection return types * Always turn XDebug off * Add quicker method of getting method mutations * Queue return types for crawling * Interpret all strings as possible classes once we see a `get_class` call * Check invalid return types again * Fix template namespacing issues * Default to class-insensitive file names for includes * Don’t overwrite existing issues data * Add var docblocks for scanning * Add null check * Fix loading of external classes in templates * Only try to populate class when we haven’t yet seen it’s not a class * Fix trait property accessibility * Only ever improve docblock param type * Make param replacement more robust * Fix static const missing inferred type * Fix a few more tests * Register constant definitions * Fix trait aliasing * Skip constant type tests for now * Fix linting issues * Make sure caching is off for tests * Remove unnecessary return * Use emulative parser if on PHP 5.6 * Cache parser for faster first-time parse * Fix constant resolution when scanning classes * Remove test that’s beyond a practical scope * Add back --diff support * Add --help for --threads * Remove unused vars
2017-07-25 22:11:02 +02:00
Aliases $aliases,
array $template_type_names = null,
$var_line_number = null,
2018-07-15 23:23:17 +02:00
$came_from_line_number = null,
array $type_aliases = null
2016-11-02 07:29:00 +01:00
) {
$var_id = null;
2016-06-24 00:45:46 +02:00
2018-05-20 23:19:53 +02:00
$var_type_tokens = null;
$original_type = null;
2016-06-24 00:45:46 +02:00
$var_comments = [];
2017-03-02 04:27:52 +01:00
$comments = self::parseDocComment($comment, $var_line_number);
2016-06-24 00:45:46 +02:00
if (!isset($comments['specials']['var']) && !isset($comments['specials']['psalm-var'])) {
return [];
2017-03-02 04:27:52 +01:00
}
if ($comments) {
$all_vars = (isset($comments['specials']['var']) ? $comments['specials']['var'] : [])
+ (isset($comments['specials']['psalm-var']) ? $comments['specials']['psalm-var'] : []);
2017-03-02 04:27:52 +01:00
/** @var int $line_number */
foreach ($all_vars as $line_number => $var_line) {
2017-03-02 04:27:52 +01:00
$var_line = trim($var_line);
2016-06-24 00:45:46 +02:00
2017-03-02 04:27:52 +01:00
if (!$var_line) {
continue;
}
try {
$line_parts = self::splitDocLine($var_line);
} catch (DocblockParseException $e) {
throw $e;
}
if ($line_parts && $line_parts[0]) {
if ($line_parts[0][0] === '$' && $line_parts[0] !== '$this') {
throw new IncorrectDocblockException('Misplaced variable');
}
try {
2018-05-20 23:19:53 +02:00
$var_type_tokens = Type::fixUpLocalType(
$line_parts[0],
$aliases,
2018-07-15 23:23:17 +02:00
$template_type_names,
$type_aliases
);
} catch (TypeParseTreeException $e) {
throw new DocblockParseException($line_parts[0] . ' is not a valid type');
}
2017-03-02 04:27:52 +01:00
$original_type = $line_parts[0];
2017-03-02 04:27:52 +01:00
$var_line_number = $line_number;
if (count($line_parts) > 1 && $line_parts[1][0] === '$') {
$var_id = $line_parts[1];
2017-03-02 04:27:52 +01:00
}
}
2017-03-02 04:27:52 +01:00
2018-05-20 23:19:53 +02:00
if (!$var_type_tokens || !$original_type) {
continue;
2016-06-24 00:45:46 +02:00
}
try {
$defined_type = Type::parseTokens($var_type_tokens, false, $template_type_names ?: []);
} catch (TypeParseTreeException $e) {
if (is_int($came_from_line_number)) {
throw new DocblockParseException(
2018-05-20 23:19:53 +02:00
implode('', $var_type_tokens) .
' is not a valid type' .
' (from ' .
$source->getFilePath() .
':' .
$came_from_line_number .
')'
);
}
2016-06-24 00:45:46 +02:00
2018-05-20 23:19:53 +02:00
throw new DocblockParseException(implode('', $var_type_tokens) . ' is not a valid type');
}
$defined_type->setFromDocblock();
2016-06-24 00:45:46 +02:00
$var_comment = new VarDocblockComment();
$var_comment->type = $defined_type;
$var_comment->original_type = $original_type;
$var_comment->var_id = $var_id;
$var_comment->line_number = $var_line_number;
$var_comment->deprecated = isset($comments['specials']['deprecated']);
$var_comments[] = $var_comment;
}
}
2016-06-24 00:45:46 +02:00
return $var_comments;
2016-06-24 00:45:46 +02:00
}
2018-07-15 23:23:17 +02:00
/**
* @param string $comment
* @param Aliases $aliases
* @param array<string, array<int, string>> $type_aliases
*
* @throws DocblockParseException if there was a problem parsing the docblock
*
* @return array<string, array<int, string>>
*/
public static function getTypeAliasesFromComment(
$comment,
Aliases $aliases,
array $type_aliases = null
) {
$comments = self::parseDocComment($comment);
if (!isset($comments['specials']['psalm-type'])) {
return [];
}
return self::getTypeAliasesFromCommentLines(
$comments['specials']['psalm-type'],
$aliases,
$type_aliases
);
}
/**
* @param array<string> $type_alias_comment_lines
* @param Aliases $aliases
* @param array<string, array<int, string>> $type_aliases
*
* @throws DocblockParseException if there was a problem parsing the docblock
*
* @return array<string, array<int, string>>
*/
private static function getTypeAliasesFromCommentLines(
array $type_alias_comment_lines,
Aliases $aliases,
array $type_aliases = null
) {
$type_alias_tokens = [];
foreach ($type_alias_comment_lines as $var_line) {
$var_line = trim($var_line);
if (!$var_line) {
continue;
}
$var_line = preg_replace('/[ \t]+/', ' ', $var_line);
$var_line_parts = preg_split('/( |=)/', $var_line, -1, PREG_SPLIT_DELIM_CAPTURE | PREG_SPLIT_NO_EMPTY);
$type_alias = array_shift($var_line_parts);
if (!isset($var_line_parts[0])) {
continue;
}
if ($var_line_parts[0] === ' ') {
array_shift($var_line_parts);
}
if ($var_line_parts[0] === '=') {
array_shift($var_line_parts);
}
if (!isset($var_line_parts[0])) {
continue;
}
if ($var_line_parts[0] === ' ') {
array_shift($var_line_parts);
}
$type_string = implode('', $var_line_parts);
try {
$type_tokens = Type::fixUpLocalType(
$type_string,
$aliases,
null,
$type_aliases
);
} catch (TypeParseTreeException $e) {
throw new DocblockParseException($type_string . ' is not a valid type');
}
$type_alias_tokens[$type_alias] = $type_tokens;
}
return $type_alias_tokens;
}
2016-10-14 06:53:43 +02:00
/**
* @param string $comment
* @param int $line_number
2017-05-27 02:16:18 +02:00
*
* @throws DocblockParseException if there was a problem parsing the docblock
*
2016-11-13 05:59:31 +01:00
* @return FunctionDocblockComment
* @psalm-suppress MixedArrayAccess
2016-10-14 06:53:43 +02:00
*/
2018-07-22 04:55:16 +02:00
public static function extractFunctionDocblockInfo($comment, $line_number)
{
$comments = self::parseDocComment($comment, $line_number);
2016-06-24 00:45:46 +02:00
2016-11-13 05:59:31 +01:00
$info = new FunctionDocblockComment();
2016-06-24 00:45:46 +02:00
if (isset($comments['specials']['return']) || isset($comments['specials']['psalm-return'])) {
2016-12-17 01:22:30 +01:00
/** @var array<int, string> */
$return_specials = isset($comments['specials']['psalm-return'])
? $comments['specials']['psalm-return']
: $comments['specials']['return'];
$return_block = trim((string)reset($return_specials));
2016-06-24 00:45:46 +02:00
if (!$return_block) {
throw new DocblockParseException('Missing @return type');
}
2016-10-28 17:05:51 +02:00
try {
$line_parts = self::splitDocLine($return_block);
2016-11-02 07:29:00 +01:00
} catch (DocblockParseException $e) {
2016-10-28 17:05:51 +02:00
throw $e;
}
2016-10-28 06:11:16 +02:00
if (!preg_match('/\[[^\]]+\]/', $line_parts[0])
2017-01-15 16:58:44 +01:00
&& $line_parts[0][0] !== '{'
) {
2018-03-22 22:55:36 +01:00
if ($line_parts[0][0] === '$' && !preg_match('/^\$this(\||$)/', $line_parts[0])) {
throw new IncorrectDocblockException('Misplaced variable');
}
2016-11-13 05:59:31 +01:00
$info->return_type = $line_parts[0];
$line_number = array_keys($return_specials)[0];
if ($line_number) {
$info->return_type_line_number = $line_number;
}
} else {
throw new DocblockParseException('Badly-formatted @return type');
2016-06-24 00:45:46 +02:00
}
}
if (isset($comments['specials']['param']) || isset($comments['specials']['psalm-param'])) {
$all_params = (isset($comments['specials']['param']) ? $comments['specials']['param'] : [])
+ (isset($comments['specials']['psalm-param']) ? $comments['specials']['psalm-param'] : []);
2016-12-17 06:48:31 +01:00
/** @var string $param */
foreach ($all_params as $line_number => $param) {
2016-10-28 17:05:51 +02:00
try {
2016-12-17 06:48:31 +01:00
$line_parts = self::splitDocLine($param);
2016-11-02 07:29:00 +01:00
} catch (DocblockParseException $e) {
2016-10-28 17:05:51 +02:00
throw $e;
}
2016-06-24 00:45:46 +02:00
2017-05-30 05:21:46 +02:00
if (count($line_parts) === 1 && isset($line_parts[0][0]) && $line_parts[0][0] === '$') {
continue;
}
if (count($line_parts) > 1) {
2018-05-20 23:19:53 +02:00
if (!preg_match('/\[[^\]]+\]/', $line_parts[0])
&& preg_match('/^(\.\.\.)?&?\$[A-Za-z0-9_]+,?$/', $line_parts[1])
2017-01-15 16:58:44 +01:00
&& $line_parts[0][0] !== '{'
) {
if ($line_parts[1][0] === '&') {
$line_parts[1] = substr($line_parts[1], 1);
}
2018-03-22 22:55:36 +01:00
if ($line_parts[0][0] === '$' && !preg_match('/^\$this(\||$)/', $line_parts[0])) {
throw new IncorrectDocblockException('Misplaced variable');
}
$line_parts[1] = preg_replace('/,$/', '', $line_parts[1]);
$info->params[] = [
'name' => $line_parts[1],
'type' => $line_parts[0],
'line_number' => (int)$line_number,
];
2016-10-15 06:12:57 +02:00
}
} else {
throw new DocblockParseException('Badly-formatted @param');
2016-06-24 00:45:46 +02:00
}
}
}
if (isset($comments['specials']['global'])) {
foreach ($comments['specials']['global'] as $line_number => $global) {
try {
$line_parts = self::splitDocLine($global);
} catch (DocblockParseException $e) {
throw $e;
}
if (count($line_parts) === 1 && isset($line_parts[0][0]) && $line_parts[0][0] === '$') {
continue;
}
if (count($line_parts) > 1) {
if (!preg_match('/\[[^\]]+\]/', $line_parts[0])
&& preg_match('/^(\.\.\.)?&?\$[A-Za-z0-9_]+,?$/', $line_parts[1])
&& $line_parts[0][0] !== '{'
) {
if ($line_parts[1][0] === '&') {
$line_parts[1] = substr($line_parts[1], 1);
}
if ($line_parts[0][0] === '$' && !preg_match('/^\$this(\||$)/', $line_parts[0])) {
throw new IncorrectDocblockException('Misplaced variable');
}
$line_parts[1] = preg_replace('/,$/', '', $line_parts[1]);
$info->globals[] = [
'name' => $line_parts[1],
'type' => $line_parts[0],
'line_number' => (int)$line_number,
];
}
} else {
throw new DocblockParseException('Badly-formatted @param');
}
}
}
if (isset($comments['specials']['deprecated'])) {
2016-11-13 05:59:31 +01:00
$info->deprecated = true;
}
2016-10-11 20:17:55 +02:00
if (isset($comments['specials']['psalm-suppress'])) {
foreach ($comments['specials']['psalm-suppress'] as $suppress_entry) {
2016-12-17 06:48:31 +01:00
$info->suppress[] = preg_split('/[\s]+/', $suppress_entry)[0];
}
}
if (isset($comments['specials']['throws'])) {
foreach ($comments['specials']['throws'] as $throws_entry) {
$info->throws[] = preg_split('/[\s]+/', $throws_entry)[0];
}
}
2018-07-14 01:09:35 +02:00
if (isset($comments['specials']['template']) || isset($comments['specials']['psalm-template'])) {
$all_templates = (isset($comments['specials']['template']) ? $comments['specials']['template'] : [])
+ (isset($comments['specials']['psalm-template']) ? $comments['specials']['psalm-template'] : []);
foreach ($all_templates as $template_line) {
2017-02-10 02:35:17 +01:00
$template_type = preg_split('/[\s]+/', $template_line);
2017-05-27 02:05:57 +02:00
if (count($template_type) > 2 && in_array(strtolower($template_type[1]), ['as', 'super'], true)) {
$info->template_type_names[] = [
$template_type[0],
strtolower($template_type[1]), $template_type[2]
];
2017-02-10 02:35:17 +01:00
} else {
$info->template_type_names[] = [$template_type[0]];
2017-02-10 02:35:17 +01:00
}
}
}
if (isset($comments['specials']['template-typeof'])) {
foreach ($comments['specials']['template-typeof'] as $template_typeof) {
$typeof_parts = preg_split('/[\s]+/', $template_typeof);
if (count($typeof_parts) < 2 || $typeof_parts[1][0] !== '$') {
throw new IncorrectDocblockException('Misplaced variable');
2017-02-10 02:35:17 +01:00
}
$info->template_typeofs[] = [
'template_type' => $typeof_parts[0],
'param_name' => substr($typeof_parts[1], 1),
];
}
}
if (isset($comments['specials']['psalm-assert'])) {
foreach ($comments['specials']['psalm-assert'] as $assertion) {
$assertion_parts = preg_split('/[\s]+/', $assertion);
if (count($assertion_parts) < 2 || $assertion_parts[1][0] !== '$') {
throw new IncorrectDocblockException('Misplaced variable');
}
$info->assertions[] = [
'type' => $assertion_parts[0],
'param_name' => substr($assertion_parts[1], 1),
];
}
}
if (isset($comments['specials']['psalm-assert-if-true'])) {
foreach ($comments['specials']['psalm-assert-if-true'] as $assertion) {
$assertion_parts = preg_split('/[\s]+/', $assertion);
if (count($assertion_parts) < 2 || $assertion_parts[1][0] !== '$') {
throw new IncorrectDocblockException('Misplaced variable');
}
$info->if_true_assertions[] = [
'type' => $assertion_parts[0],
'param_name' => substr($assertion_parts[1], 1),
];
}
}
if (isset($comments['specials']['psalm-assert-if-false'])) {
foreach ($comments['specials']['psalm-assert-if-false'] as $assertion) {
$assertion_parts = preg_split('/[\s]+/', $assertion);
if (count($assertion_parts) < 2 || $assertion_parts[1][0] !== '$') {
throw new IncorrectDocblockException('Misplaced variable');
}
$info->if_false_assertions[] = [
'type' => $assertion_parts[0],
'param_name' => substr($assertion_parts[1], 1),
];
}
}
2016-11-13 05:59:31 +01:00
$info->variadic = isset($comments['specials']['psalm-variadic']);
$info->ignore_nullable_return = isset($comments['specials']['psalm-ignore-nullable-return']);
$info->ignore_falsable_return = isset($comments['specials']['psalm-ignore-falsable-return']);
2016-06-24 00:45:46 +02:00
return $info;
}
2016-10-28 06:11:16 +02:00
2017-02-10 02:35:17 +01:00
/**
* @param string $comment
* @param int $line_number
2017-05-27 02:16:18 +02:00
*
* @throws DocblockParseException if there was a problem parsing the docblock
*
2017-02-10 02:35:17 +01:00
* @return ClassLikeDocblockComment
* @psalm-suppress MixedArrayAccess
*/
public static function extractClassLikeDocblockInfo($comment, $line_number)
{
$comments = self::parseDocComment($comment, $line_number);
$info = new ClassLikeDocblockComment();
if (isset($comments['specials']['template'])) {
foreach ($comments['specials']['template'] as $template_line) {
$template_type = preg_split('/[\s]+/', $template_line);
2017-05-27 02:05:57 +02:00
if (count($template_type) > 2 && in_array(strtolower($template_type[1]), ['as', 'super'], true)) {
$info->template_type_names[] = [
$template_type[0],
strtolower($template_type[1]), $template_type[2]
];
2017-02-10 02:35:17 +01:00
} else {
$info->template_type_names[] = [$template_type[0]];
2017-02-10 02:35:17 +01:00
}
}
}
if (isset($comments['specials']['template-extends'])) {
foreach ($comments['specials']['template-extends'] as $template_line) {
$info->template_parents[] = $template_line;
}
}
if (isset($comments['specials']['deprecated'])) {
$info->deprecated = true;
}
if (isset($comments['specials']['psalm-seal-properties'])) {
$info->sealed_properties = true;
}
if (isset($comments['specials']['psalm-seal-methods'])) {
$info->sealed_methods = true;
}
if (isset($comments['specials']['psalm-suppress'])) {
foreach ($comments['specials']['psalm-suppress'] as $suppress_entry) {
$info->suppressed_issues[] = preg_split('/[\s]+/', $suppress_entry)[0];
}
}
if (isset($comments['specials']['method'])) {
foreach ($comments['specials']['method'] as $method_entry) {
$method_entry = preg_replace('/[ \t]+/', ' ', trim($method_entry));
$docblock_lines = [];
if (!preg_match('/^([a-z_A-Z][a-z_0-9A-Z]+) *\(/', $method_entry, $matches)) {
$doc_line_parts = self::splitDocLine($method_entry);
$docblock_lines[] = '@return ' . array_shift($doc_line_parts);
$method_entry = implode(' ', $doc_line_parts);
}
$method_entry = trim(preg_replace('/\/\/.*/', '', $method_entry));
$end_of_method_regex = '/(?<!array\()\) ?(\: ?(\??[\\\\a-zA-Z0-9_]+))?/';
if (preg_match($end_of_method_regex, $method_entry, $matches, PREG_OFFSET_CAPTURE)) {
$method_entry = substr($method_entry, 0, (int) $matches[0][1] + strlen((string) $matches[0][0]));
}
$method_entry = str_replace([', ', '( '], [',', '('], $method_entry);
$method_entry = preg_replace('/ (?!(\$|\.\.\.|&))/', '', trim($method_entry));
2018-06-28 23:39:25 +02:00
try {
$method_tree = Type\ParseTree::createFromTokens(Type::tokenize($method_entry, false));
} catch (TypeParseTreeException $e) {
throw new DocblockParseException($method_entry . ' is not a valid method');
}
if (!$method_tree instanceof Type\ParseTree\MethodWithReturnTypeTree
&& !$method_tree instanceof Type\ParseTree\MethodTree) {
throw new DocblockParseException($method_entry . ' is not a valid method');
}
if ($method_tree instanceof Type\ParseTree\MethodWithReturnTypeTree) {
$docblock_lines[] = '@return ' . Type::getTypeFromTree($method_tree->children[1]);
$method_tree = $method_tree->children[0];
}
if (!$method_tree instanceof Type\ParseTree\MethodTree) {
throw new DocblockParseException($method_entry . ' is not a valid method');
}
$args = [];
foreach ($method_tree->children as $method_tree_child) {
if (!$method_tree_child instanceof Type\ParseTree\MethodParamTree) {
throw new DocblockParseException($method_entry . ' is not a valid method');
}
$args[] = ($method_tree_child->byref ? '&' : '')
. ($method_tree_child->variadic ? '...' : '')
. $method_tree_child->name
. ($method_tree_child->default != '' ? ' = ' . $method_tree_child->default : '');
if ($method_tree_child->children) {
$param_type = Type::getTypeFromTree($method_tree_child->children[0]);
$docblock_lines[] = '@param ' . $param_type . ' '
. ($method_tree_child->variadic ? '...' : '')
. $method_tree_child->name;
}
}
$function_string = 'function ' . $method_tree->value . '(' . implode(', ', $args) . ')';
$function_docblock = $docblock_lines ? "/**\n * " . implode("\n * ", $docblock_lines) . "\n*/\n" : "";
$php_string = '<?php class A { ' . $function_docblock . ' public ' . $function_string . '{} }';
try {
$statements = \Psalm\Provider\StatementsProvider::parseStatements($php_string);
} catch (\Exception $e) {
throw new DocblockParseException('Badly-formatted @method string ' . $method_entry);
}
if (!$statements[0] instanceof \PhpParser\Node\Stmt\Class_
|| !isset($statements[0]->stmts[0])
|| !$statements[0]->stmts[0] instanceof \PhpParser\Node\Stmt\ClassMethod
) {
throw new DocblockParseException('Badly-formatted @method string ' . $method_entry);
}
$info->methods[] = $statements[0]->stmts[0];
}
}
self::addMagicPropertyToInfo($info, $comments['specials'], 'property');
self::addMagicPropertyToInfo($info, $comments['specials'], 'property-read');
self::addMagicPropertyToInfo($info, $comments['specials'], 'property-write');
return $info;
}
/**
* @param ClassLikeDocblockComment $info
* @param array<string, array<int, string>> $specials
* @param string $property_tag ('property', 'property-read', or 'property-write')
*
* @throws DocblockParseException
*
* @return void
*/
protected static function addMagicPropertyToInfo(ClassLikeDocblockComment $info, array $specials, $property_tag)
{
$magic_property_comments = isset($specials[$property_tag]) ? $specials[$property_tag] : [];
foreach ($magic_property_comments as $line_number => $property) {
try {
$line_parts = self::splitDocLine($property);
} catch (DocblockParseException $e) {
throw $e;
}
if (count($line_parts) === 1 && $line_parts[0][0] === '$') {
array_unshift($line_parts, 'mixed');
}
if (count($line_parts) > 1) {
if (preg_match('/^' . self::TYPE_REGEX . '$/', $line_parts[0])
&& !preg_match('/\[[^\]]+\]/', $line_parts[0])
&& preg_match('/^(\.\.\.)?&?\$[A-Za-z0-9_]+,?$/', $line_parts[1])
&& !strpos($line_parts[0], '::')
&& $line_parts[0][0] !== '{'
) {
if ($line_parts[1][0] === '&') {
$line_parts[1] = substr($line_parts[1], 1);
}
2018-03-22 22:55:36 +01:00
if ($line_parts[0][0] === '$' && !preg_match('/^\$this(\||$)/', $line_parts[0])) {
throw new IncorrectDocblockException('Misplaced variable');
}
$line_parts[1] = preg_replace('/,$/', '', $line_parts[1]);
$info->properties[] = [
'name' => $line_parts[1],
'type' => $line_parts[0],
'line_number' => $line_number,
'tag' => $property_tag,
];
} else {
throw new DocblockParseException('Badly-formatted @property');
}
} else {
throw new DocblockParseException('Badly-formatted @property');
}
}
2017-02-10 02:35:17 +01:00
}
2016-10-28 06:11:16 +02:00
/**
* @param string $return_block
2017-05-27 02:16:18 +02:00
*
* @throws DocblockParseException if an invalid string is found
*
2016-10-28 06:11:16 +02:00
* @return array<string>
*/
2018-01-07 16:23:02 +01:00
public static function splitDocLine($return_block)
2016-10-28 06:11:16 +02:00
{
$brackets = '';
$type = '';
$expects_callable_return = false;
$return_block = preg_replace('/[ \t]+/', ' ', $return_block);
2018-05-20 23:19:53 +02:00
$quote_char = null;
$escaped = false;
for ($i = 0, $l = strlen($return_block); $i < $l; ++$i) {
2016-10-28 06:11:16 +02:00
$char = $return_block[$i];
$next_char = $i < $l - 1 ? $return_block[$i + 1] : null;
2016-10-28 06:11:16 +02:00
2018-05-20 23:19:53 +02:00
if ($quote_char) {
if ($char === $quote_char && $i > 1 && !$escaped) {
$quote_char = null;
$type .= $char;
continue;
}
if ($char === '\\' && !$escaped && ($next_char === $quote_char || $next_char === '\\')) {
$escaped = true;
$type .= $char;
continue;
}
$escaped = false;
$type .= $char;
continue;
}
if ($char === '"' || $char === '\'') {
$quote_char = $char;
$type .= $char;
continue;
}
2016-10-28 06:11:16 +02:00
if ($char === '[' || $char === '{' || $char === '(' || $char === '<') {
$brackets .= $char;
2016-11-02 07:29:00 +01:00
} elseif ($char === ']' || $char === '}' || $char === ')' || $char === '>') {
2016-10-28 06:11:16 +02:00
$last_bracket = substr($brackets, -1);
$brackets = substr($brackets, 0, -1);
if (($char === ']' && $last_bracket !== '[')
|| ($char === '}' && $last_bracket !== '{')
|| ($char === ')' && $last_bracket !== '(')
|| ($char === '>' && $last_bracket !== '<')
) {
2016-11-02 07:29:00 +01:00
throw new DocblockParseException('Invalid string ' . $return_block);
2016-10-28 06:11:16 +02:00
}
} elseif ($char === ' ') {
2016-10-28 06:11:16 +02:00
if ($brackets) {
continue;
}
if ($next_char === '|') {
++$i;
$type .= $next_char;
continue;
}
$last_char = $i > 0 ? $return_block[$i - 1] : null;
if ($last_char === '|') {
continue;
}
if ($next_char === ':') {
++$i;
$type .= ':';
$expects_callable_return = true;
continue;
}
if ($expects_callable_return) {
$expects_callable_return = false;
continue;
}
2016-11-01 05:39:41 +01:00
$remaining = trim(substr($return_block, $i + 1));
if ($remaining) {
return array_merge([$type], explode(' ', $remaining));
2016-11-01 05:39:41 +01:00
}
return [$type];
2016-10-28 06:11:16 +02:00
}
$type .= $char;
}
return [$type];
}
2016-11-02 07:29:00 +01:00
/**
2016-10-28 06:11:16 +02:00
* Parse a docblock comment into its parts.
*
2016-11-02 07:29:00 +01:00
* Taken from advanced api docmaker, which was taken from
* https://github.com/facebook/libphutil/blob/master/src/parser/docblock/PhutilDocblockParser.php
2016-10-28 06:11:16 +02:00
*
* @param string $docblock
* @param int $line_number
* @param bool $preserve_format
2017-05-27 02:16:18 +02:00
*
2016-10-28 06:11:16 +02:00
* @return array Array of the main comment and specials
* @psalm-return array{description:string, specials:array<string, array<int, string>>}
2016-10-28 06:11:16 +02:00
*/
public static function parseDocComment($docblock, $line_number = null, $preserve_format = false)
2016-10-28 06:11:16 +02:00
{
// Strip off comments.
$docblock = trim($docblock);
$docblock = preg_replace('@^/\*\*@', '', $docblock);
$docblock = preg_replace('@\*/$@', '', $docblock);
$docblock = preg_replace('@^[ \t]*\*@m', '', $docblock);
2016-10-28 06:11:16 +02:00
// Normalize multi-line @specials.
$lines = explode("\n", $docblock);
$line_map = [];
2016-10-28 06:11:16 +02:00
$last = false;
foreach ($lines as $k => $line) {
if (preg_match('/^\s?@\w/i', $line)) {
$last = $k;
} elseif (preg_match('/^\s*$/', $line)) {
$last = false;
} elseif ($last !== false) {
$old_last_line = $lines[$last];
$lines[$last] = rtrim($old_last_line) . ($preserve_format ? "\n" . $line : ' ' . trim($line));
if ($line_number) {
$old_line_number = $line_map[$old_last_line];
unset($line_map[$old_last_line]);
$line_map[$lines[$last]] = $old_line_number;
}
2016-10-28 06:11:16 +02:00
unset($lines[$k]);
}
if ($line_number) {
$line_map[$line] = $line_number++;
}
2016-10-28 06:11:16 +02:00
}
2016-11-02 07:29:00 +01:00
$special = [];
2016-10-28 06:11:16 +02:00
if ($preserve_format) {
foreach ($lines as $m => $line) {
if (preg_match('/^\s?@([\w\-:]+)[\t ]*(.*)$/sm', $line, $matches)) {
/** @var string[] $matches */
list($full_match, $type, $data) = $matches;
$docblock = str_replace($full_match, '', $docblock);
if (empty($special[$type])) {
$special[$type] = [];
}
$line_number = $line_map && isset($line_map[$full_match]) ? $line_map[$full_match] : (int)$m;
$special[$type][$line_number] = rtrim($data);
2016-10-28 06:11:16 +02:00
}
}
} else {
$docblock = implode("\n", $lines);
// Parse @specials.
if (preg_match_all('/^\s?@([\w\-:]+)[\t ]*([^\n]*)/m', $docblock, $matches, PREG_SET_ORDER)) {
$docblock = preg_replace('/^\s?@([\w\-:]+)\s*([^\n]*)/m', '', $docblock);
/** @var string[] $match */
foreach ($matches as $m => $match) {
list($_, $type, $data) = $match;
if (empty($special[$type])) {
$special[$type] = [];
}
2016-10-28 06:11:16 +02:00
$line_number = $line_map && isset($line_map[$_]) ? $line_map[$_] : (int)$m;
2017-06-29 06:28:37 +02:00
$special[$type][$line_number] = $data;
}
2016-10-28 06:11:16 +02:00
}
}
$docblock = str_replace("\t", ' ', $docblock);
// Smush the whole docblock to the left edge.
$min_indent = 80;
$indent = 0;
foreach (array_filter(explode("\n", $docblock)) as $line) {
2017-05-27 02:05:57 +02:00
for ($ii = 0; $ii < strlen($line); ++$ii) {
2016-10-28 06:11:16 +02:00
if ($line[$ii] != ' ') {
break;
}
2017-05-27 02:05:57 +02:00
++$indent;
2016-10-28 06:11:16 +02:00
}
$min_indent = min($indent, $min_indent);
}
$docblock = preg_replace('/^' . str_repeat(' ', $min_indent) . '/m', '', $docblock);
$docblock = rtrim($docblock);
// Trim any empty lines off the front, but leave the indent level if there
// is one.
$docblock = preg_replace('/^\s*\n/', '', $docblock);
2016-11-02 07:29:00 +01:00
return [
'description' => $docblock,
2017-05-27 02:05:57 +02:00
'specials' => $special,
2016-11-02 07:29:00 +01:00
];
2016-10-28 06:11:16 +02:00
}
2016-11-13 05:59:31 +01:00
/**
* @param array{description:string,specials:array<string,array<string>>} $parsed_doc_comment
2016-11-21 19:37:27 +01:00
* @param string $left_padding
2017-05-27 02:16:18 +02:00
*
* @return string
2016-11-13 05:59:31 +01:00
*/
public static function renderDocComment(array $parsed_doc_comment, $left_padding)
{
$doc_comment_text = '/**' . "\n";
2016-11-13 05:59:31 +01:00
$description_lines = null;
$trimmed_description = trim($parsed_doc_comment['description']);
if (!empty($trimmed_description)) {
$description_lines = explode("\n", $parsed_doc_comment['description']);
2016-11-13 05:59:31 +01:00
foreach ($description_lines as $line) {
$doc_comment_text .= $left_padding . ' *' . (trim($line) ? ' ' . $line : '') . "\n";
2016-11-13 05:59:31 +01:00
}
}
if ($description_lines && $parsed_doc_comment['specials']) {
$doc_comment_text .= $left_padding . ' *' . "\n";
2016-11-13 05:59:31 +01:00
}
if ($parsed_doc_comment['specials']) {
2017-09-16 21:08:11 +02:00
$last_type = null;
2017-09-16 21:00:50 +02:00
2016-11-13 05:59:31 +01:00
foreach ($parsed_doc_comment['specials'] as $type => $lines) {
if ($last_type !== null && $last_type !== 'psalm-return') {
$doc_comment_text .= $left_padding . ' *' . "\n";
2017-09-16 21:08:11 +02:00
}
2016-11-13 05:59:31 +01:00
foreach ($lines as $line) {
$doc_comment_text .= $left_padding . ' * @' . $type . ' '
. str_replace("\n", "\n" . $left_padding . ' *', $line) . "\n";
2016-11-13 05:59:31 +01:00
}
2017-09-16 21:00:50 +02:00
2017-09-16 21:08:11 +02:00
$last_type = $type;
2016-11-13 05:59:31 +01:00
}
}
$doc_comment_text .= $left_padding . ' */' . "\n" . $left_padding;
2016-11-13 05:59:31 +01:00
return $doc_comment_text;
}
2016-06-24 00:45:46 +02:00
}