1
0
mirror of https://github.com/danog/psalm.git synced 2024-12-04 18:48:03 +01:00
psalm/tests/Template/PropertiesOfTemplateTest.php

431 lines
14 KiB
PHP
Raw Normal View History

<?php
2022-06-28 15:42:18 +02:00
namespace Psalm\Tests\Template;
2022-06-28 15:46:30 +02:00
use Psalm\Tests\TestCase;
use Psalm\Tests\Traits\InvalidCodeAnalysisTestTrait;
use Psalm\Tests\Traits\ValidCodeAnalysisTestTrait;
class PropertiesOfTemplateTest extends TestCase
{
use ValidCodeAnalysisTestTrait;
use InvalidCodeAnalysisTestTrait;
/**
Add support for strict arrays, fix type alias intersection, fix array_is_list assertion on non-lists (#8395) * Immutable CodeLocation * Remove excess clones * Remove external clones * Remove leftover clones * Fix final clone issue * Immutable storages * Refactoring * Fixes * Fixes * Fix * Fix * Fixes * Simplify * Fixes * Fix * Fixes * Update * Fix * Cache global types * Fix * Update * Update * Fixes * Fixes * Refactor * Fixes * Fix * Fix * More caching * Fix * Fix * Update * Update * Fix * Fixes * Update * Refactor * Update * Fixes * Break one more test * Fix * FIx * Fix * Fix * Fix * Fix * Improve performance and readability * Equivalent logic * Fixes * Revert * Revert "Revert" This reverts commit f9175100c8452c80559234200663fd4c4f4dd889. * Fix * Fix reference bug * Make default TypeVisitor immutable * Bugfix * Remove clones * Partial refactoring * Refactoring * Fixes * Fix * Fixes * Fixes * cs-fix * Fix final bugs * Add test * Misc fixes * Update * Fixes * Experiment with removing different property * revert "Experiment with removing different property" This reverts commit ac1156e077fc4ea633530d51096d27b6e88bfdf9. * Uniform naming * Uniform naming * Hack hotfix * Clean up $_FILES ref #8621 * Undo hack, try fixing properly * Helper method * Remove redundant call * Partially fix bugs * Cleanup * Change defaults * Fix bug * Fix (?, hope this doesn't break anything else) * cs-fix * Review fixes * Bugfix * Bugfix * Improve logic * Add support for list{} and callable-list{} types, properly implement array_is_list assertions (fixes #8389) * Default to sealed arrays * Fix array_merge bug * Fixes * Fix * Sealed type checks * Properly infer properties-of and get_object_vars on final classes * Fix array_map zipping * Fix tests * Fixes * Fixes * Fix more stuff * Recursively resolve type aliases * Fix typo * Fixes * Fix array_is_list assertion on keyed array * Add BC docs * Fixes * fix * Update * Update * Update * Update * Seal arrays with count assertions * Fix #8528 * Fix * Update * Improve sealed array foreach logic * get_object_vars on template properties * Fix sealed array assertion reconciler logic * Improved reconciler * Add tests * Single source of truth for test types * Fix tests * Fixup tests * Fixup tests * Fixup tests * Update * Fix tests * Fix tests * Final fixes * Fixes * Use list syntax only when needed * Fix tests * Cs-fix * Update docs * Update docs * Update docs * Update docs * Update docs * Document missing types * Update docs * Improve class-string-map docs * Update * Update * I love working on psalm :) * Keep arrays unsealed by default * Fixup tests * Fix syntax mistake * cs-fix * Fix typo * Re-import missing types * Keep strict types only in return types * argc/argv fixes * argc/argv fixes * Fix test * Comment-out valinor code, pinging @romm pls merge https://github.com/CuyZ/Valinor/pull/246 so we can add valinor to the psalm docs :)
2022-11-05 22:34:42 +01:00
*
*/
public function providerValidCodeParse(): iterable
{
return [
'propertiesOfTemplateParam' => [
'code' => '<?php
/**
* @template T
* @param T $obj
* @return properties-of<T>
*/
function asArray($obj) {
/** @var properties-of<T> */
$properties = [];
return $properties;
}
class A {
/** @var int */
public $a = 42;
/** @var bool */
private $b = true;
/** @var string */
protected $c = "c";
}
$obj = new A();
$objAsArray = asArray($obj);
$a = $objAsArray["a"];
$aPlus2 = $a + 2;
$b = $objAsArray["b"];
if ($b === true) {
echo "True!";
}
$c = $objAsArray["c"];
$cConcat = $c . "foo";
',
],
'propertiesOfTemplateParamWithTemplate' => [
'code' => '<?php
/**
* @template T
* @param T $obj
* @return properties-of<T>
*/
function asArray($obj) {
/** @var properties-of<T> */
$properties = [];
return $properties;
}
/** @template T */
class A {
/** @var bool */
private $b = true;
/** @var string */
protected $c = "c";
/** @param T $a */
public function __construct(public $a) {}
}
$obj = new A(42);
$objAsArray = asArray($obj);
',
'assertions' => [
'$objAsArray===' => 'array{a: 42, b: bool, c: string, ...<string, mixed>}'
]
],
'privatePropertiesPicksPrivate' => [
'code' => '<?php
/**
* @template T
* @param T $obj
* @return private-properties-of<T>
*/
function asArray($obj) {
/** @var private-properties-of<T> */
$properties = [];
return $properties;
}
class A {
/** @var int */
public $a = 42;
/** @var bool */
private $b = true;
/** @var string */
protected $c = "c";
}
$obj = new A();
$objAsArray = asArray($obj);
$b = $objAsArray["b"];
',
],
'protectedPropertiesPicksProtected' => [
'code' => '<?php
/**
* @template T
* @param T $obj
* @return protected-properties-of<T>
*/
function asArray($obj) {
/** @var protected-properties-of<T> */
$properties = [];
return $properties;
}
class A {
/** @var int */
public $a = 42;
/** @var bool */
private $b = true;
/** @var string */
protected $c = "c";
}
$obj = new A();
$objAsArray = asArray($obj);
$b = $objAsArray["c"];
',
],
'publicPropertiesPicksPublic' => [
'code' => '<?php
/**
* @template T
* @param T $obj
* @return public-properties-of<T>
*/
function asArray($obj) {
/** @var public-properties-of<T> */
$properties = [];
return $properties;
}
class A {
/** @var int */
public $a = 42;
/** @var bool */
private $b = true;
/** @var string */
protected $c = "c";
}
$obj = new A();
$objAsArray = asArray($obj);
$a = $objAsArray["a"];
',
],
'propertiesOfNestedTemplates' => [
'code' => '<?php
/**
* @template T
* @template TArray of array<array-key, T>
* @param TArray $array
* @return properties-of<T>
*/
function asArray($array) {
/** @var properties-of<T> */
$properties = [];
return $properties;
}
class A {
/** @var int */
public $a = 42;
/** @var bool */
private $b = true;
/** @var string */
protected $c = "c";
}
$obj = new A();
$objAsArray = asArray([$obj]);
$b = $objAsArray["c"];
'
],
];
}
/**
Add support for strict arrays, fix type alias intersection, fix array_is_list assertion on non-lists (#8395) * Immutable CodeLocation * Remove excess clones * Remove external clones * Remove leftover clones * Fix final clone issue * Immutable storages * Refactoring * Fixes * Fixes * Fix * Fix * Fixes * Simplify * Fixes * Fix * Fixes * Update * Fix * Cache global types * Fix * Update * Update * Fixes * Fixes * Refactor * Fixes * Fix * Fix * More caching * Fix * Fix * Update * Update * Fix * Fixes * Update * Refactor * Update * Fixes * Break one more test * Fix * FIx * Fix * Fix * Fix * Fix * Improve performance and readability * Equivalent logic * Fixes * Revert * Revert "Revert" This reverts commit f9175100c8452c80559234200663fd4c4f4dd889. * Fix * Fix reference bug * Make default TypeVisitor immutable * Bugfix * Remove clones * Partial refactoring * Refactoring * Fixes * Fix * Fixes * Fixes * cs-fix * Fix final bugs * Add test * Misc fixes * Update * Fixes * Experiment with removing different property * revert "Experiment with removing different property" This reverts commit ac1156e077fc4ea633530d51096d27b6e88bfdf9. * Uniform naming * Uniform naming * Hack hotfix * Clean up $_FILES ref #8621 * Undo hack, try fixing properly * Helper method * Remove redundant call * Partially fix bugs * Cleanup * Change defaults * Fix bug * Fix (?, hope this doesn't break anything else) * cs-fix * Review fixes * Bugfix * Bugfix * Improve logic * Add support for list{} and callable-list{} types, properly implement array_is_list assertions (fixes #8389) * Default to sealed arrays * Fix array_merge bug * Fixes * Fix * Sealed type checks * Properly infer properties-of and get_object_vars on final classes * Fix array_map zipping * Fix tests * Fixes * Fixes * Fix more stuff * Recursively resolve type aliases * Fix typo * Fixes * Fix array_is_list assertion on keyed array * Add BC docs * Fixes * fix * Update * Update * Update * Update * Seal arrays with count assertions * Fix #8528 * Fix * Update * Improve sealed array foreach logic * get_object_vars on template properties * Fix sealed array assertion reconciler logic * Improved reconciler * Add tests * Single source of truth for test types * Fix tests * Fixup tests * Fixup tests * Fixup tests * Update * Fix tests * Fix tests * Final fixes * Fixes * Use list syntax only when needed * Fix tests * Cs-fix * Update docs * Update docs * Update docs * Update docs * Update docs * Document missing types * Update docs * Improve class-string-map docs * Update * Update * I love working on psalm :) * Keep arrays unsealed by default * Fixup tests * Fix syntax mistake * cs-fix * Fix typo * Re-import missing types * Keep strict types only in return types * argc/argv fixes * argc/argv fixes * Fix test * Comment-out valinor code, pinging @romm pls merge https://github.com/CuyZ/Valinor/pull/246 so we can add valinor to the psalm docs :)
2022-11-05 22:34:42 +01:00
*
*/
public function providerInvalidCodeParse(): iterable
{
return [
'propertiesOfAllowsOnlyDefinedProperties' => [
'code' => '<?php
/**
* @template T
* @param T $obj
* @return properties-of<T>
*/
function asArray($obj) {
/** @var properties-of<T> */
$properties = [];
return $properties;
}
final class A {
/** @var int */
public $a = 42;
/** @var bool */
private $b = true;
/** @var string */
protected $c = "c";
}
$obj = new A();
$objAsArray = asArray($obj);
$d = $objAsArray["d"];
',
'error_message' => 'InvalidArrayOffset'
],
'privatePropertiesPicksNoPublic' => [
'code' => '<?php
/**
* @template T
* @param T $obj
* @return private-properties-of<T>
*/
function asArray($obj) {
/** @var private-properties-of<T> */
$properties = [];
return $properties;
}
final class A {
/** @var int */
public $a = 42;
/** @var bool */
private $b = true;
/** @var string */
protected $c = "c";
}
$obj = new A();
$objAsArray = asArray($obj);
$b = $objAsArray["a"];
',
'error_message' => 'InvalidArrayOffset'
],
'privatePropertiesPicksNoProtected' => [
'code' => '<?php
/**
* @template T
* @param T $obj
* @return private-properties-of<T>
*/
function asArray($obj) {
/** @var private-properties-of<T> */
$properties = [];
return $properties;
}
final class A {
/** @var int */
public $a = 42;
/** @var bool */
private $b = true;
/** @var string */
protected $c = "c";
}
$obj = new A();
$objAsArray = asArray($obj);
$b = $objAsArray["c"];
',
'error_message' => 'InvalidArrayOffset'
],
'protectedPropertiesPicksNoPublic' => [
'code' => '<?php
/**
* @template T
* @param T $obj
* @return protected-properties-of<T>
*/
function asArray($obj) {
/** @var protected-properties-of<T> */
$properties = [];
return $properties;
}
final class A {
/** @var int */
public $a = 42;
/** @var bool */
private $b = true;
/** @var string */
protected $c = "c";
}
$obj = new A();
$objAsArray = asArray($obj);
$b = $objAsArray["a"];
',
'error_message' => 'InvalidArrayOffset'
],
'protectedPropertiesPicksNoPrivate' => [
'code' => '<?php
/**
* @template T
* @param T $obj
* @return protected-properties-of<T>
*/
function asArray($obj) {
/** @var protected-properties-of<T> */
$properties = [];
return $properties;
}
final class A {
/** @var int */
public $a = 42;
/** @var bool */
private $b = true;
/** @var string */
protected $c = "c";
}
$obj = new A();
$objAsArray = asArray($obj);
$b = $objAsArray["b"];
',
'error_message' => 'InvalidArrayOffset'
],
'publicPropertiesPicksNoPrivate' => [
'code' => '<?php
/**
* @template T
* @param T $obj
* @return public-properties-of<T>
*/
function asArray($obj) {
/** @var public-properties-of<T> */
$properties = [];
return $properties;
}
final class A {
/** @var int */
public $a = 42;
/** @var bool */
private $b = true;
/** @var string */
protected $c = "c";
}
$obj = new A();
$objAsArray = asArray($obj);
$a = $objAsArray["b"];
',
'error_message' => 'InvalidArrayOffset'
],
'publicPropertiesPicksNoProtected' => [
'code' => '<?php
/**
* @template T
* @param T $obj
* @return public-properties-of<T>
*/
function asArray($obj) {
/** @var public-properties-of<T> */
$properties = [];
return $properties;
}
final class A {
/** @var int */
public $a = 42;
/** @var bool */
private $b = true;
/** @var string */
protected $c = "c";
}
$obj = new A();
$objAsArray = asArray($obj);
$a = $objAsArray["c"];
',
'error_message' => 'InvalidArrayOffset'
],
'propertiesOfNestedTemplatesPickPublic' => [
'code' => '<?php
/**
* @template T
* @template TArray of array<array-key, T>
* @param TArray $array
* @return properties-of<T>
*/
function asArray($array) {
/** @var properties-of<T> */
$properties = [];
return $properties;
}
final class A {
/** @var int */
public $a = 42;
/** @var bool */
private $b = true;
/** @var string */
protected $c = "c";
}
$obj = new A();
$objAsArray = asArray([$obj]);
$b = $objAsArray["d"];
',
'error_message' => 'InvalidArrayOffset'
],
];
}
}