2018-01-29 05:41:11 +01:00
|
|
|
<?php
|
|
|
|
namespace Psalm\Tests;
|
|
|
|
|
2019-07-05 22:24:00 +02:00
|
|
|
use function array_keys;
|
|
|
|
use function count;
|
|
|
|
use const DIRECTORY_SEPARATOR;
|
|
|
|
use function dirname;
|
|
|
|
use function explode;
|
|
|
|
use function file_exists;
|
|
|
|
use function file_get_contents;
|
|
|
|
use function implode;
|
|
|
|
use function preg_quote;
|
2018-01-29 05:41:11 +01:00
|
|
|
use Psalm\Config;
|
|
|
|
use Psalm\Context;
|
2019-03-23 19:27:54 +01:00
|
|
|
use Psalm\Internal\Analyzer\FileAnalyzer;
|
2018-11-12 16:57:05 +01:00
|
|
|
use Psalm\Tests\Internal\Provider;
|
2019-06-26 22:52:29 +02:00
|
|
|
use function sort;
|
|
|
|
use function strpos;
|
2019-07-05 22:24:00 +02:00
|
|
|
use function substr;
|
|
|
|
use function trim;
|
2018-01-29 05:41:11 +01:00
|
|
|
|
|
|
|
class DocumentationTest extends TestCase
|
|
|
|
{
|
2018-11-06 03:57:36 +01:00
|
|
|
/** @var \Psalm\Internal\Analyzer\ProjectAnalyzer */
|
2018-11-11 18:01:14 +01:00
|
|
|
protected $project_analyzer;
|
2018-01-29 05:41:11 +01:00
|
|
|
|
|
|
|
/**
|
|
|
|
* @return array<string, array<int, string>>
|
|
|
|
*/
|
|
|
|
private static function getCodeBlocksFromDocs()
|
|
|
|
{
|
2019-06-09 06:54:13 +02:00
|
|
|
$issue_file = dirname(dirname(__FILE__)) . DIRECTORY_SEPARATOR . 'docs' . DIRECTORY_SEPARATOR . 'running_psalm' . DIRECTORY_SEPARATOR . 'issues.md';
|
2018-01-29 05:41:11 +01:00
|
|
|
|
|
|
|
if (!file_exists($issue_file)) {
|
|
|
|
throw new \UnexpectedValueException('docs not found');
|
|
|
|
}
|
|
|
|
|
|
|
|
$file_contents = file_get_contents($issue_file);
|
|
|
|
|
|
|
|
if (!$file_contents) {
|
|
|
|
throw new \UnexpectedValueException('Docs are empty');
|
|
|
|
}
|
|
|
|
|
2018-04-13 01:42:24 +02:00
|
|
|
$file_lines = explode("\n", $file_contents);
|
2018-01-29 05:41:11 +01:00
|
|
|
|
|
|
|
$issue_code = [];
|
|
|
|
|
|
|
|
$current_issue = null;
|
|
|
|
|
|
|
|
for ($i = 0, $j = count($file_lines); $i < $j; ++$i) {
|
|
|
|
$current_line = $file_lines[$i];
|
|
|
|
|
|
|
|
if (substr($current_line, 0, 4) === '### ') {
|
|
|
|
$current_issue = trim(substr($current_line, 4));
|
|
|
|
++$i;
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (substr($current_line, 0, 6) === '```php' && $current_issue) {
|
|
|
|
$current_block = '';
|
|
|
|
++$i;
|
|
|
|
|
|
|
|
do {
|
2018-04-13 01:42:24 +02:00
|
|
|
$current_block .= $file_lines[$i] . "\n";
|
2018-01-29 05:41:11 +01:00
|
|
|
++$i;
|
|
|
|
} while (substr($file_lines[$i], 0, 3) !== '```' && $i < $j);
|
|
|
|
|
2018-02-22 00:59:31 +01:00
|
|
|
$issue_code[(string) $current_issue][] = trim($current_block);
|
2018-01-29 05:41:11 +01:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return $issue_code;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @return void
|
|
|
|
*/
|
2019-05-17 00:36:36 +02:00
|
|
|
public function setUp() : void
|
2018-01-29 05:41:11 +01:00
|
|
|
{
|
2018-11-06 03:57:36 +01:00
|
|
|
FileAnalyzer::clearCache();
|
2018-11-12 16:46:55 +01:00
|
|
|
\Psalm\Internal\FileManipulation\FunctionDocblockManipulator::clearCache();
|
2018-01-29 05:41:11 +01:00
|
|
|
|
|
|
|
$this->file_provider = new Provider\FakeFileProvider();
|
|
|
|
|
2018-11-11 18:01:14 +01:00
|
|
|
$this->project_analyzer = new \Psalm\Internal\Analyzer\ProjectAnalyzer(
|
2018-01-29 05:41:11 +01:00
|
|
|
new TestConfig(),
|
2018-11-06 03:57:36 +01:00
|
|
|
new \Psalm\Internal\Provider\Providers(
|
2018-09-28 22:18:45 +02:00
|
|
|
$this->file_provider,
|
|
|
|
new Provider\FakeParserCacheProvider()
|
|
|
|
)
|
2018-01-29 05:41:11 +01:00
|
|
|
);
|
2019-02-07 21:27:43 +01:00
|
|
|
|
|
|
|
$this->project_analyzer->setPhpVersion('7.3');
|
2018-01-29 05:41:11 +01:00
|
|
|
}
|
|
|
|
|
2018-01-29 06:39:21 +01:00
|
|
|
/**
|
|
|
|
* @return void
|
|
|
|
*/
|
|
|
|
public function testAllIssuesCovered()
|
|
|
|
{
|
2019-05-03 21:29:44 +02:00
|
|
|
$all_issues = \Psalm\Config\IssueHandler::getAllIssueTypes();
|
|
|
|
$all_issues[] = 'ParseError';
|
|
|
|
$all_issues[] = 'PluginIssue';
|
|
|
|
|
2018-01-29 06:39:21 +01:00
|
|
|
sort($all_issues);
|
|
|
|
|
|
|
|
$code_blocks = self::getCodeBlocksFromDocs();
|
|
|
|
|
|
|
|
// these cannot have code
|
|
|
|
$code_blocks['UnrecognizedExpression'] = true;
|
|
|
|
$code_blocks['UnrecognizedStatement'] = true;
|
2019-01-07 14:38:56 +01:00
|
|
|
$code_blocks['PluginIssue'] = true;
|
2019-08-04 16:37:36 +02:00
|
|
|
$code_blocks['TaintedInput'] = true;
|
2018-01-29 06:39:21 +01:00
|
|
|
|
2019-04-26 00:02:19 +02:00
|
|
|
// these are deprecated
|
|
|
|
$code_blocks['TypeCoercion'] = true;
|
|
|
|
$code_blocks['MixedTypeCoercion'] = true;
|
2019-06-07 15:25:03 +02:00
|
|
|
$code_blocks['MixedTypeCoercion'] = true;
|
|
|
|
$code_blocks['MisplacedRequiredParam'] = true;
|
2019-04-26 00:02:19 +02:00
|
|
|
|
2018-01-29 06:39:21 +01:00
|
|
|
$documented_issues = array_keys($code_blocks);
|
|
|
|
sort($documented_issues);
|
|
|
|
|
2018-04-13 01:42:24 +02:00
|
|
|
$this->assertSame(implode("\n", $all_issues), implode("\n", $documented_issues));
|
2018-01-29 06:39:21 +01:00
|
|
|
}
|
|
|
|
|
2018-01-29 05:41:11 +01:00
|
|
|
/**
|
2018-11-06 03:57:36 +01:00
|
|
|
* @dataProvider providerInvalidCodeParse
|
2018-01-29 05:41:11 +01:00
|
|
|
* @small
|
|
|
|
*
|
|
|
|
* @param string $code
|
|
|
|
* @param string $error_message
|
|
|
|
* @param array<string> $error_levels
|
|
|
|
* @param bool $check_references
|
|
|
|
*
|
|
|
|
* @return void
|
|
|
|
*/
|
|
|
|
public function testInvalidCode($code, $error_message, $error_levels = [], $check_references = false)
|
|
|
|
{
|
2018-07-13 23:44:50 +02:00
|
|
|
if (strpos($this->getTestName(), 'SKIPPED-') !== false) {
|
2018-01-29 05:41:11 +01:00
|
|
|
$this->markTestSkipped();
|
|
|
|
}
|
|
|
|
|
2018-02-04 00:52:35 +01:00
|
|
|
if ($check_references) {
|
2018-11-11 18:01:14 +01:00
|
|
|
$this->project_analyzer->getCodebase()->reportUnusedCode();
|
2019-08-18 20:27:50 +02:00
|
|
|
$this->project_analyzer->trackUnusedSuppressions();
|
2018-02-04 00:52:35 +01:00
|
|
|
}
|
2018-01-29 05:41:11 +01:00
|
|
|
|
2019-11-11 15:59:56 +01:00
|
|
|
$is_array_offset_test = strpos($error_message, 'ArrayOffset') && strpos($error_message, 'PossiblyUndefined') !== false;
|
|
|
|
|
|
|
|
$this->project_analyzer->getConfig()->ensure_array_string_offsets_exist = $is_array_offset_test;
|
|
|
|
$this->project_analyzer->getConfig()->ensure_array_int_offsets_exist = $is_array_offset_test;
|
|
|
|
|
2018-01-29 05:41:11 +01:00
|
|
|
foreach ($error_levels as $error_level) {
|
2018-11-11 18:01:14 +01:00
|
|
|
$this->project_analyzer->getCodebase()->config->setCustomErrorLevel($error_level, Config::REPORT_SUPPRESS);
|
2018-01-29 05:41:11 +01:00
|
|
|
}
|
|
|
|
|
2019-02-23 22:22:39 +01:00
|
|
|
$this->expectException(\Psalm\Exception\CodeException::class);
|
2019-01-12 16:52:23 +01:00
|
|
|
$this->expectExceptionMessageRegExp('/\b' . preg_quote($error_message, '/') . '\b/');
|
2018-01-29 05:41:11 +01:00
|
|
|
|
|
|
|
$file_path = self::$src_dir_path . 'somefile.php';
|
|
|
|
|
|
|
|
$this->addFile($file_path, $code);
|
|
|
|
|
|
|
|
$context = new Context();
|
|
|
|
$context->collect_references = $check_references;
|
|
|
|
|
|
|
|
$this->analyzeFile($file_path, $context);
|
|
|
|
|
|
|
|
if ($check_references) {
|
2019-12-02 21:24:01 +01:00
|
|
|
$this->project_analyzer->consolidateAnalyzedData();
|
2018-01-29 05:41:11 +01:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2019-02-23 22:22:39 +01:00
|
|
|
* @return array<string,array{string,string,string[],bool}>
|
2018-01-29 05:41:11 +01:00
|
|
|
*/
|
2018-11-06 03:57:36 +01:00
|
|
|
public function providerInvalidCodeParse()
|
2018-01-29 05:41:11 +01:00
|
|
|
{
|
|
|
|
$invalid_code_data = [];
|
|
|
|
|
|
|
|
foreach (self::getCodeBlocksFromDocs() as $issue_name => $blocks) {
|
|
|
|
switch ($issue_name) {
|
2018-06-22 07:13:49 +02:00
|
|
|
case 'MissingThrowsDocblock':
|
|
|
|
continue 2;
|
|
|
|
|
2019-03-24 21:17:14 +01:00
|
|
|
case 'UncaughtThrowInGlobalScope':
|
|
|
|
continue 2;
|
|
|
|
|
2018-03-06 18:19:50 +01:00
|
|
|
case 'InvalidStringClass':
|
|
|
|
continue 2;
|
|
|
|
|
2018-09-18 23:08:32 +02:00
|
|
|
case 'ForbiddenEcho':
|
|
|
|
continue 2;
|
|
|
|
|
2019-01-07 14:38:56 +01:00
|
|
|
case 'PluginClass':
|
|
|
|
continue 2;
|
|
|
|
|
2018-01-29 05:41:11 +01:00
|
|
|
case 'InvalidFalsableReturnType':
|
|
|
|
$ignored_issues = ['FalsableReturnStatement'];
|
|
|
|
break;
|
|
|
|
|
|
|
|
case 'InvalidNullableReturnType':
|
|
|
|
$ignored_issues = ['NullableReturnStatement'];
|
|
|
|
break;
|
|
|
|
|
|
|
|
case 'InvalidReturnType':
|
|
|
|
$ignored_issues = ['InvalidReturnStatement'];
|
|
|
|
break;
|
|
|
|
|
|
|
|
case 'MixedInferredReturnType':
|
|
|
|
$ignored_issues = ['MixedReturnStatement'];
|
|
|
|
break;
|
|
|
|
|
|
|
|
case 'MixedStringOffsetAssignment':
|
|
|
|
$ignored_issues = ['MixedAssignment'];
|
|
|
|
break;
|
|
|
|
|
2018-05-08 22:34:08 +02:00
|
|
|
case 'ParadoxicalCondition':
|
|
|
|
$ignored_issues = ['MissingParamType'];
|
|
|
|
break;
|
|
|
|
|
2018-01-29 05:41:11 +01:00
|
|
|
case 'UnusedClass':
|
|
|
|
case 'UnusedMethod':
|
|
|
|
$ignored_issues = ['UnusedVariable'];
|
|
|
|
break;
|
|
|
|
|
|
|
|
default:
|
|
|
|
$ignored_issues = [];
|
|
|
|
}
|
|
|
|
|
|
|
|
$invalid_code_data[$issue_name] = [
|
2018-04-13 01:42:24 +02:00
|
|
|
'<?php' . "\n" . $blocks[0],
|
2018-01-29 05:41:11 +01:00
|
|
|
$issue_name,
|
|
|
|
$ignored_issues,
|
2019-09-19 17:59:43 +02:00
|
|
|
strpos($issue_name, 'Unused') !== false
|
|
|
|
|| strpos($issue_name, 'Unevaluated') !== false
|
|
|
|
|| strpos($issue_name, 'Unnecessary') !== false,
|
2018-01-29 05:41:11 +01:00
|
|
|
];
|
|
|
|
}
|
|
|
|
|
|
|
|
return $invalid_code_data;
|
|
|
|
}
|
|
|
|
}
|