1
0
mirror of https://github.com/danog/psalm.git synced 2024-12-12 09:19:40 +01:00
psalm/tests/RedundantConditionTest.php

641 lines
21 KiB
PHP
Raw Normal View History

<?php
namespace Psalm\Tests;
class RedundantConditionTest extends TestCase
{
use Traits\FileCheckerValidCodeParseTestTrait;
use Traits\FileCheckerInvalidCodeParseTestTrait;
/**
* @return array
*/
public function providerFileCheckerValidCodeParse()
{
return [
'ignoreIssueAndAssign' => [
'<?php
2018-01-11 21:50:45 +01:00
public function foo(): stdClass {
return new stdClass;
}
$b = null;
foreach ([0, 1] as $i) {
$a = foo();
if (!empty($a)) {
$b = $a;
}
}',
'assertions' => [
'$b' => 'null|stdClass',
],
'error_levels' => ['RedundantCondition'],
],
'byrefNoRedundantCondition' => [
'<?php
/**
* @param int $min ref
* @param int $other
*/
2018-01-11 21:50:45 +01:00
function testmin(&$min, int $other): void {
if (is_null($min)) {
$min = 3;
} elseif (!is_int($min)) {
$min = 5;
} elseif ($min < $other) {
$min = $other;
}
}',
'assertions' => [],
'error_levels' => [
'RedundantConditionGivenDocblockType',
'DocblockTypeContradiction',
],
],
'assignmentInIf' => [
'<?php
2018-01-11 21:50:45 +01:00
function test(int $x = null): int {
if (!$x && !($x = rand(0, 10))) {
echo "Failed to get non-empty x\n";
return -1;
}
return $x;
}',
],
'noRedundantConditionAfterAssignment' => [
'<?php
/** @param int $i */
2018-01-11 21:50:45 +01:00
function foo($i): void {
if ($i !== null) {
$i = (int) $i;
if ($i) {}
}
}',
'assertions' => [],
'error_levels' => [
'RedundantConditionGivenDocblockType',
],
],
'noRedundantConditionAfterDocblockTypeNullCheck' => [
'<?php
class A {
/** @var ?int */
public $foo;
}
class B {}
/**
* @param A|B $i
*/
2018-01-11 21:50:45 +01:00
function foo($i): void {
if (empty($i)) {
return;
}
switch (get_class($i)) {
case "A":
if ($i->foo) {}
break;
default:
break;
}
}',
'assertions' => [],
'error_levels' => ['DocblockTypeContradiction'],
],
'noRedundantConditionTypeReplacementWithDocblock' => [
'<?php
class A {}
/**
* @return A
*/
function getA() {
return new A();
}
$maybe_a = rand(0, 1) ? new A : null;
if ($maybe_a === null) {
$maybe_a = getA();
}
if ($maybe_a === null) {}',
'assertions' => [],
'error_levels' => [
'DocblockTypeContradiction',
],
],
'noRedundantConditionAfterPossiblyNullCheck' => [
'<?php
if (rand(0, 1)) {
$a = "hello";
}
if ($a) {}',
'assertions' => [],
'error_levels' => ['PossiblyUndefinedGlobalVariable'],
],
'noRedundantConditionAfterFromDocblockRemoval' => [
'<?php
class A {
2018-01-11 21:50:45 +01:00
public function foo(): void{}
public function bar(): void{}
}
/** @return A */
function makeA() {
return new A;
}
$a = makeA();
if ($a === null) {
exit;
}
if ($a->foo() || $a->bar()) {}',
'assertions' => [],
'error_levels' => [
'DocblockTypeContradiction',
],
],
'noEmptyUndefinedArrayVar' => [
'<?php
if (rand(0,1)) {
/** @psalm-suppress UndefinedGlobalVariable */
$a = $b[0];
} else {
$a = null;
}
if ($a) {}',
'assertions' => [],
'error_levels' => ['MixedAssignment', 'MixedArrayAccess'],
],
2017-12-09 21:51:38 +01:00
'noComplaintWithIsNumericThenIsEmpty' => [
'<?php
2018-01-11 21:50:45 +01:00
function takesString(string $s): void {
2017-12-09 21:51:38 +01:00
if (!is_numeric($s) || empty($s)) {}
}',
],
'noRedundantConditionOnTryCatchVars' => [
'<?php
2018-01-11 21:50:45 +01:00
function trycatch(): void {
$value = null;
try {
if (rand() % 2 > 0) {
throw new RuntimeException("Failed");
}
$value = new stdClass();
if (rand() % 2 > 0) {
throw new RuntimeException("Failed");
}
} catch (Exception $e) {
if ($value) {
var_export($value);
}
}
if ($value) {}
}',
],
'noRedundantConditionInFalseCheck' => [
'<?php
$ch = curl_init();
if (!$ch) {}',
],
'noRedundantConditionInForCheck' => [
'<?php
class Node
{
/** @var Node|null */
public $next;
public function iterate(): void
{
for ($node = $this; $node !== null; $node = $node->next) {}
}
}',
],
'noRedundantConditionComparingBool' => [
'<?php
2018-01-11 21:50:45 +01:00
function getBool(): bool {
return (bool)rand(0, 1);
}
2018-01-11 21:50:45 +01:00
function takesBool(bool $b): void {
if ($b === getBool()) {}
}',
],
'evaluateElseifProperly' => [
'<?php
/** @param string $str */
2018-01-11 21:50:45 +01:00
function foo($str): int {
if (is_null($str)) {
return 1;
} else if (strlen($str) < 1) {
return 2;
}
return 2;
}',
'assertions' => [],
'error_levels' => [
'DocblockTypeContradiction',
'RedundantConditionGivenDocblockType',
],
],
'evaluateArrayCheck' => [
'<?php
2018-01-11 21:50:45 +01:00
function array_check(): void {
$data = ["f" => false];
while (rand(0, 1) > 0 && !$data["f"]) {
$data = ["f" => true];
}
}',
],
'mixedArrayAssignment' => [
'<?php
/** @param mixed $arr */
2018-01-11 21:50:45 +01:00
function foo($arr): void {
if ($arr["a"] === false) {
$arr["a"] = (bool) rand(0, 1);
if ($arr["a"] === false) {}
}
}',
'assertions' => [],
'error_levels' => ['MixedAssignment', 'MixedArrayAccess'],
],
'hardPhpTypeAssertionsOnDocblockType' => [
'<?php
/** @param string|null $bar */
2018-01-11 21:50:45 +01:00
function foo($bar): void {
if (!is_null($bar) && !is_string($bar)) {
throw new \Exception("bad");
}
if ($bar !== null) {}
}',
'assertions' => [],
'error_levels' => ['RedundantConditionGivenDocblockType'],
],
'isObjectAssertionOnDocblockType' => [
'<?php
class A {}
class B {}
/** @param A|B $a */
function foo($a) : void {
if (!is_object($a)) {
return;
}
if ($a instanceof A) {
} elseif ($a instanceof B) {
} else {
throw new \Exception("bad");
}
}',
'assertions' => [],
'error_levels' => ['RedundantConditionGivenDocblockType', 'DocblockTypeContradiction'],
],
'nullToMixedWithNullCheckNoContinue' => [
'<?php
function getStrings(): array {
return ["hello", "world", 50];
}
$a = getStrings();
if (is_string($a[0]) && strlen($a[0]) > 3) {}',
'assignments' => [],
'error_levels' => [],
],
'replaceFalseTypeWithTrueConditionalOnMixedEquality' => [
'<?php
function getData() {
return rand(0, 1) ? [1, 2, 3] : false;
}
$a = false;
while ($i = getData()) {
if (!$a && $i[0] === 2) {
$a = true;
}
if ($a === false) {}
}',
'assignments' => [],
'error_levels' => ['MixedAssignment', 'MissingReturnType', 'MixedArrayAccess'],
],
'nullCoalescePossiblyUndefined' => [
'<?php
if (rand(0,1)) {
$options = ["option" => true];
}
$option = $options["option"] ?? false;
if ($option) {}',
'assignments' => [],
'error_levels' => ['MixedAssignment'],
],
'allowIntValueCheckAfterComparisonDueToOverflow' => [
'<?php
function foo(int $x) : void {
$x = $x + 1;
if (!is_int($x)) {
echo "Is a float.";
} else {
echo "Is an int.";
}
}
function bar(int $x) : void {
$x = $x + 1;
if (is_float($x)) {
echo "Is a float.";
} else {
echo "Is an int.";
}
}',
],
'allowIntValueCheckAfterComparisonDueToOverflowInc' => [
'<?php
function foo(int $x) : void {
$x++;
if (!is_int($x)) {
echo "Is a float.";
} else {
echo "Is an int.";
}
}
function bar(int $x) : void {
$x++;
if (is_float($x)) {
echo "Is a float.";
} else {
echo "Is an int.";
}
}',
],
'allowIntValueCheckAfterComparisonDueToConditionalOverflow' => [
'<?php
function foo(int $x) : void {
if (rand(0, 1)) {
$x = $x + 1;
}
if (is_float($x)) {
echo "Is a float.";
} else {
echo "Is an int.";
}
}',
],
'changeStringValue' => [
'<?php
$concat = "";
foreach (["x", "y"] as $v) {
if ($concat != "") {
$concat .= ", ";
}
$concat .= "($v)";
}',
],
];
}
/**
* @return array
*/
public function providerFileCheckerInvalidCodeParse()
{
return [
'ifFalse' => [
'<?php
$y = false:
if ($y) {}',
'error_message' => 'TypeDoesNotContainType',
],
'ifNotTrue' => [
'<?php
$y = true:
if (!$y) {}',
'error_message' => 'TypeDoesNotContainType',
],
'ifTrue' => [
'<?php
$y = true:
if ($y) {}',
'error_message' => 'RedundantCondition',
],
'unnecessaryInstanceof' => [
'<?php
class One {
public function fooFoo() : void {}
}
$var = new One();
if ($var instanceof One) {
$var->fooFoo();
}',
'error_message' => 'RedundantCondition',
],
'failedTypeResolution' => [
'<?php
class A { }
/**
* @return void
*/
function fooFoo(A $a) {
if ($a instanceof A) {
}
}',
'error_message' => 'RedundantCondition',
],
'failedTypeResolutionWithDocblock' => [
'<?php
class A { }
/**
* @param A $a
* @return void
*/
function fooFoo(A $a) {
if ($a instanceof A) {
}
}',
'error_message' => 'RedundantCondition',
],
'typeResolutionFromDocblockAndInstanceof' => [
'<?php
class A { }
/**
* @param A $a
* @return void
* @psalm-suppress RedundantConditionGivenDocblockType
*/
function fooFoo($a) {
if ($a instanceof A) {
if ($a instanceof A) {
}
}
}',
'error_message' => 'RedundantCondition',
],
'typeResolutionRepeatingConditionWithSingleVar' => [
'<?php
$a = rand(0, 10) > 5;
if ($a && $a) {}',
'error_message' => 'RedundantCondition',
],
'typeResolutionRepeatingConditionWithVarInMiddle' => [
'<?php
$a = rand(0, 10) > 5;
$b = rand(0, 10) > 5;
if ($a && $b && $a) {}',
'error_message' => 'RedundantCondition',
],
2018-05-07 20:52:45 +02:00
'typeResolutionRepeatingOredConditionWithSingleVar' => [
'<?php
$a = rand(0, 10) > 5;
if ($a || $a) {}',
'error_message' => 'ParadoxicalCondition',
],
'typeResolutionRepeatingOredConditionWithVarInMiddle' => [
'<?php
$a = rand(0, 10) > 5;
$b = rand(0, 10) > 5;
if ($a || $b || $a) {}',
'error_message' => 'ParadoxicalCondition',
],
'typeResolutionIsIntAndIsNumeric' => [
'<?php
$c = rand(0, 10) > 5 ? "hello" : 3;
if (is_int($c) && is_numeric($c)) {}',
'error_message' => 'RedundantCondition',
],
'typeResolutionWithInstanceOfAndNotEmpty' => [
'<?php
$x = rand(0, 10) > 5 ? new stdClass : null;
if ($x instanceof stdClass && $x) {}',
'error_message' => 'RedundantCondition',
],
'methodWithMeaninglessCheck' => [
'<?php
class One {
/** @return void */
public function fooFoo() {}
}
class B {
/** @return void */
public function barBar(One $one) {
if (!$one) {
// do nothing
}
$one->fooFoo();
}
}',
'error_message' => 'TypeDoesNotContainType',
],
2018-05-07 07:26:06 +02:00
'twoVarLogicNotNestedWithElseifNegatedInIf' => [
'<?php
2018-01-11 21:50:45 +01:00
function foo(?string $a, ?string $b): ?string {
if ($a) {
$a = null;
} elseif ($b) {
// do nothing here
} else {
return "bad";
}
if (!$a) return $b;
return $a;
}',
'error_message' => 'RedundantCondition',
],
'refineTypeInMethodCall' => [
'<?php
class A {}
/** @return ?A */
function getA() {
return rand(0, 1) ? new A : null;
}
2018-01-11 21:50:45 +01:00
function takesA(A $a): void {}
$a = getA();
if ($a instanceof A) {}
/** @psalm-suppress PossiblyNullArgument */
takesA($a);
if ($a instanceof A) {}',
'error_message' => 'RedundantCondition - src' . DIRECTORY_SEPARATOR . 'somefile.php:15',
],
'replaceFalseType' => [
'<?php
function foo(bool $b) : void {
if (!$b) {
$b = true;
}
if ($b) {}
}',
'error_message' => 'RedundantCondition',
],
'replaceTrueType' => [
'<?php
function foo(bool $b) : void {
if ($b) {
$b = false;
}
if ($b) {}
}',
'error_message' => 'TypeDoesNotContainType - src' . DIRECTORY_SEPARATOR . 'somefile.php:7',
],
'allowIntValueCheckAfterComparisonDueToConditionalOverflow' => [
'<?php
function foo(int $x) : void {
if (rand(0, 1)) {
$x = 125;
}
if (is_float($x)) {
echo "Is a float.";
} else {
echo "Is an int.";
}
}',
'error_message' => 'TypeDoesNotContainType - src' . DIRECTORY_SEPARATOR . 'somefile.php:7',
],
'disallowTwoIntValueChecksDueToConditionalOverflow' => [
'<?php
function foo(int $x) : void {
$x = $x + 1;
if (is_int($x)) {
} elseif (is_int($x)) {}
}',
'error_message' => 'TypeDoesNotContainType - src' . DIRECTORY_SEPARATOR . 'somefile.php:6',
],
];
}
}