Plugin loading (#855)
* add ability to load plugins by class names
- Plugins need to implement `__invoke(PluginFacade $psalm):void` method
- Plugins are enabled by adding `<pluginClass
class="Qualified\Class\Name"/>`
- `PluginFacade` provides a single point of contact with Psalm, so that
plugins cannot become coupled to Psalm internals
* added `psalm-plugin` cli tool to manage plugins
Available commands:
`psalm-plugin list` - lists available and enabled plugins
`psalm-plugin enable 'Plugin\Class\Name'` - enables plugin (modifies `psalm.xml`)
`psalm-plugin disable 'Plugin\Class\Name'` - disables plugin (modifies `psalm.xml`)
Plugin installation:
`composer install plugin-vendor/plugin-package-name`
Plugin authoring:
Plugins are identified by package `type` field, which should contain
`psalm-plugin` string.
`extra.pluginClass` should refer to the name of the class implementing
`__invoke(PluginFacade $psalm):void` function
Todo:
- better config file search
- better output for `psalm-plugin`
- better formatting for modified xml file
- composer skeleton project for plugins
- ability to refer to plugins by package name (cli only)
- composer plugin to (optionally) enable plugin upon installation
- documentation on plugin installation and authoring
- interfaces for plugin dependencies
- interface for plugin entry point
- migration path for legacy plugins
* documented previously undocumented plugin methods
* split legacy plugin registration into a wrapper class
also added `PluginApi` namespace and `RegistrationInterface`
* reuse psalm's config search algorithm
* enable/disable plugins by composer package name
* allow specifying alternative config file name
* whitelist PluginApi namespace
three times, but well, it works now
* interface for plugin entry points
* psalm-plugin as a symfony console app
* fixed errors found by psalm
* suppressed false positive UnusedMethods
* cs fix
* better psalm-plugin output
* don't leave empty `plugins` node to avoid old schema violation
* removed junk file that shouldn't be there
* cs fix
* fixed phpunit failure (constant redefinition)
* work around missing docblock in on symfony console
* php 7.0 compatibility
* allow `pluginClass` child elements as plugin configuration
* decouple console commands from undelying implementation
- introduce PluginListFactory
- add `PluginList::enable(string $class)` and `PluginList::disable(string $class)`
* PluginList tests
* ComposerLock test
* droppped debugging statement
* added part of console command tests
* added tests for EnableCommand
* added DisableCommand tests
* ignore unused args
* ConfigFile test
* disable travis cache in attempt to fix builds
* nah, that didn't work
* update for upstream changes
* rebase fixes
* namespaced `extra` entry for entry point
* s/PluginFacade/PluginRegistrationSocket/g
* Added $config parameter to PluginEntryPointInterface::__invoke()
* cs fixes
* entry point interface php7.0 compatibility
* cleaned up old cruft
- dropped todos I'm not going to pursues
- locked entry point to be a class implementing entry point interface
* fixed legacy plugins docs
* Added RegistrationInterface::registerHooksFromClass()
It mimics the way old plugins were registered in Psalm\Config, so
handler classes extending Psalm\Plugin should be fully compatible with
it.
Since Psalm\Plugin-style plugin registration was moved to
RegistrationSocket, LegacyPlugin now only load file-based plugins, so it
was renamed to FileBasedPluginAdapter.
* Converted EchoChecker plugin to composer-based format
- Its subfolder is registered as a local composer package in the root
composer.json, so it's directly installable with
```
composer require psalm/echo-checker-plugin
```
- Migration is trivial: drop the plugin into a separate folder, then add
simple composer.json and the entry point class.
* Updated docs
* Don't reject hook handlers that inherit handling methods
* strip void return type in stub file
2018-11-11 05:23:36 +01:00
|
|
|
<?php
|
|
|
|
namespace Psalm\Tests;
|
|
|
|
|
|
|
|
use Prophecy\Argument;
|
|
|
|
use Prophecy\Prophecy\ObjectProphecy;
|
2018-11-18 18:41:47 +01:00
|
|
|
use Psalm\Internal\PluginManager\Command\DisableCommand;
|
|
|
|
use Psalm\Internal\PluginManager\Command\EnableCommand;
|
|
|
|
use Psalm\Internal\PluginManager\Command\ShowCommand;
|
|
|
|
use Psalm\Internal\PluginManager\PluginList;
|
|
|
|
use Psalm\Internal\PluginManager\PluginListFactory;
|
Plugin loading (#855)
* add ability to load plugins by class names
- Plugins need to implement `__invoke(PluginFacade $psalm):void` method
- Plugins are enabled by adding `<pluginClass
class="Qualified\Class\Name"/>`
- `PluginFacade` provides a single point of contact with Psalm, so that
plugins cannot become coupled to Psalm internals
* added `psalm-plugin` cli tool to manage plugins
Available commands:
`psalm-plugin list` - lists available and enabled plugins
`psalm-plugin enable 'Plugin\Class\Name'` - enables plugin (modifies `psalm.xml`)
`psalm-plugin disable 'Plugin\Class\Name'` - disables plugin (modifies `psalm.xml`)
Plugin installation:
`composer install plugin-vendor/plugin-package-name`
Plugin authoring:
Plugins are identified by package `type` field, which should contain
`psalm-plugin` string.
`extra.pluginClass` should refer to the name of the class implementing
`__invoke(PluginFacade $psalm):void` function
Todo:
- better config file search
- better output for `psalm-plugin`
- better formatting for modified xml file
- composer skeleton project for plugins
- ability to refer to plugins by package name (cli only)
- composer plugin to (optionally) enable plugin upon installation
- documentation on plugin installation and authoring
- interfaces for plugin dependencies
- interface for plugin entry point
- migration path for legacy plugins
* documented previously undocumented plugin methods
* split legacy plugin registration into a wrapper class
also added `PluginApi` namespace and `RegistrationInterface`
* reuse psalm's config search algorithm
* enable/disable plugins by composer package name
* allow specifying alternative config file name
* whitelist PluginApi namespace
three times, but well, it works now
* interface for plugin entry points
* psalm-plugin as a symfony console app
* fixed errors found by psalm
* suppressed false positive UnusedMethods
* cs fix
* better psalm-plugin output
* don't leave empty `plugins` node to avoid old schema violation
* removed junk file that shouldn't be there
* cs fix
* fixed phpunit failure (constant redefinition)
* work around missing docblock in on symfony console
* php 7.0 compatibility
* allow `pluginClass` child elements as plugin configuration
* decouple console commands from undelying implementation
- introduce PluginListFactory
- add `PluginList::enable(string $class)` and `PluginList::disable(string $class)`
* PluginList tests
* ComposerLock test
* droppped debugging statement
* added part of console command tests
* added tests for EnableCommand
* added DisableCommand tests
* ignore unused args
* ConfigFile test
* disable travis cache in attempt to fix builds
* nah, that didn't work
* update for upstream changes
* rebase fixes
* namespaced `extra` entry for entry point
* s/PluginFacade/PluginRegistrationSocket/g
* Added $config parameter to PluginEntryPointInterface::__invoke()
* cs fixes
* entry point interface php7.0 compatibility
* cleaned up old cruft
- dropped todos I'm not going to pursues
- locked entry point to be a class implementing entry point interface
* fixed legacy plugins docs
* Added RegistrationInterface::registerHooksFromClass()
It mimics the way old plugins were registered in Psalm\Config, so
handler classes extending Psalm\Plugin should be fully compatible with
it.
Since Psalm\Plugin-style plugin registration was moved to
RegistrationSocket, LegacyPlugin now only load file-based plugins, so it
was renamed to FileBasedPluginAdapter.
* Converted EchoChecker plugin to composer-based format
- Its subfolder is registered as a local composer package in the root
composer.json, so it's directly installable with
```
composer require psalm/echo-checker-plugin
```
- Migration is trivial: drop the plugin into a separate folder, then add
simple composer.json and the entry point class.
* Updated docs
* Don't reject hook handlers that inherit handling methods
* strip void return type in stub file
2018-11-11 05:23:36 +01:00
|
|
|
use Symfony\Component\Console\Application;
|
|
|
|
use Symfony\Component\Console\Input\InputOption;
|
|
|
|
use Symfony\Component\Console\Tester\CommandTester;
|
|
|
|
|
|
|
|
/** @group PluginManager */
|
|
|
|
class PsalmPluginTest extends TestCase
|
|
|
|
{
|
|
|
|
/** @var ObjectProphecy */
|
|
|
|
private $plugin_list;
|
|
|
|
/** @var ObjectProphecy */
|
|
|
|
private $plugin_list_factory;
|
|
|
|
|
|
|
|
/** @var Application */
|
|
|
|
private $app;
|
|
|
|
|
|
|
|
public function setUp()
|
|
|
|
{
|
|
|
|
$this->plugin_list = $this->prophesize(PluginList::class);
|
|
|
|
$this->plugin_list_factory = $this->prophesize(PluginListFactory::class);
|
|
|
|
/** @psalm-suppress TooManyArguments */
|
|
|
|
$this->plugin_list_factory->__invoke(Argument::any(), Argument::any())->willReturn($this->plugin_list->reveal());
|
|
|
|
|
|
|
|
$this->app = new Application('psalm-plugin', '0.1');
|
|
|
|
$this->app->addCommands([
|
|
|
|
new ShowCommand($this->plugin_list_factory->reveal()),
|
|
|
|
new EnableCommand($this->plugin_list_factory->reveal()),
|
|
|
|
new DisableCommand($this->plugin_list_factory->reveal()),
|
|
|
|
]);
|
|
|
|
|
|
|
|
$this->app->getDefinition()->addOption(
|
|
|
|
new InputOption('config', 'c', InputOption::VALUE_REQUIRED, 'Path to Psalm config file')
|
|
|
|
);
|
|
|
|
|
|
|
|
$this->app->setDefaultCommand('show');
|
|
|
|
|
|
|
|
/** @psalm-suppress TooManyArguments */
|
|
|
|
$this->plugin_list->getEnabled()->willReturn([]);
|
|
|
|
/** @psalm-suppress TooManyArguments */
|
|
|
|
$this->plugin_list->getAvailable()->willReturn([]);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @return void
|
|
|
|
* @test
|
|
|
|
*/
|
|
|
|
public function showsNoticesWhenTheresNoPlugins()
|
|
|
|
{
|
|
|
|
$show_command = new CommandTester($this->app->find('show'));
|
|
|
|
$show_command->execute([]);
|
|
|
|
|
|
|
|
$output = $show_command->getDisplay();
|
|
|
|
$this->assertContains('No plugins enabled', $output);
|
|
|
|
$this->assertContains('No plugins available', $output);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @return void
|
|
|
|
* @test
|
|
|
|
*/
|
|
|
|
public function showsEnabledPlugins()
|
|
|
|
{
|
|
|
|
/** @psalm-suppress TooManyArguments */
|
|
|
|
$this->plugin_list->getEnabled()->willReturn(['a\b\c' => 'vendor/package']);
|
|
|
|
|
|
|
|
$show_command = new CommandTester($this->app->find('show'));
|
|
|
|
$show_command->execute([]);
|
|
|
|
|
|
|
|
$output = $show_command->getDisplay();
|
|
|
|
$this->assertContains('vendor/package', $output);
|
|
|
|
$this->assertContains('a\b\c', $output);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @return void
|
|
|
|
* @test
|
|
|
|
*/
|
|
|
|
public function showsAvailablePlugins()
|
|
|
|
{
|
|
|
|
/** @psalm-suppress TooManyArguments */
|
|
|
|
$this->plugin_list->getAvailable()->willReturn(['a\b\c' => 'vendor/package']);
|
|
|
|
|
|
|
|
$show_command = new CommandTester($this->app->find('show'));
|
|
|
|
$show_command->execute([]);
|
|
|
|
|
|
|
|
$output = $show_command->getDisplay();
|
|
|
|
$this->assertContains('vendor/package', $output);
|
|
|
|
$this->assertContains('a\b\c', $output);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @return void
|
|
|
|
* @test
|
|
|
|
*/
|
|
|
|
public function passesExplicitConfigToPluginListFactory()
|
|
|
|
{
|
|
|
|
/** @psalm-suppress TooManyArguments */
|
|
|
|
$this->plugin_list_factory->__invoke(Argument::any(), '/a/b/c')->willReturn($this->plugin_list->reveal());
|
|
|
|
|
|
|
|
$show_command = new CommandTester($this->app->find('show'));
|
|
|
|
$show_command->execute([
|
|
|
|
'--config' => '/a/b/c',
|
|
|
|
]);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @return void
|
|
|
|
* @test
|
|
|
|
*/
|
|
|
|
public function showsColumnHeaders()
|
|
|
|
{
|
|
|
|
/** @psalm-suppress TooManyArguments */
|
|
|
|
$this->plugin_list->getAvailable()->willReturn(['a\b\c' => 'vendor/package']);
|
|
|
|
/** @psalm-suppress TooManyArguments */
|
|
|
|
$this->plugin_list->getAvailable()->willReturn(['c\d\e' => 'another-vendor/package']);
|
|
|
|
|
|
|
|
$show_command = new CommandTester($this->app->find('show'));
|
|
|
|
$show_command->execute([]);
|
|
|
|
|
|
|
|
$output = $show_command->getDisplay();
|
|
|
|
|
|
|
|
$this->assertContains('Package', $output);
|
|
|
|
$this->assertContains('Class', $output);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @return void
|
|
|
|
* @dataProvider commands
|
|
|
|
* @test
|
|
|
|
*/
|
|
|
|
public function listsCommands(string $command)
|
|
|
|
{
|
|
|
|
$list_command = new CommandTester($this->app->find('list'));
|
|
|
|
$list_command->execute([]);
|
|
|
|
$output = $list_command->getDisplay();
|
|
|
|
$this->assertContains($command, $output);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @return void
|
|
|
|
* @dataProvider commands
|
|
|
|
* @test
|
2018-11-14 19:19:38 +01:00
|
|
|
* @psalm-suppress RedundantConditionGivenDocblockType
|
Plugin loading (#855)
* add ability to load plugins by class names
- Plugins need to implement `__invoke(PluginFacade $psalm):void` method
- Plugins are enabled by adding `<pluginClass
class="Qualified\Class\Name"/>`
- `PluginFacade` provides a single point of contact with Psalm, so that
plugins cannot become coupled to Psalm internals
* added `psalm-plugin` cli tool to manage plugins
Available commands:
`psalm-plugin list` - lists available and enabled plugins
`psalm-plugin enable 'Plugin\Class\Name'` - enables plugin (modifies `psalm.xml`)
`psalm-plugin disable 'Plugin\Class\Name'` - disables plugin (modifies `psalm.xml`)
Plugin installation:
`composer install plugin-vendor/plugin-package-name`
Plugin authoring:
Plugins are identified by package `type` field, which should contain
`psalm-plugin` string.
`extra.pluginClass` should refer to the name of the class implementing
`__invoke(PluginFacade $psalm):void` function
Todo:
- better config file search
- better output for `psalm-plugin`
- better formatting for modified xml file
- composer skeleton project for plugins
- ability to refer to plugins by package name (cli only)
- composer plugin to (optionally) enable plugin upon installation
- documentation on plugin installation and authoring
- interfaces for plugin dependencies
- interface for plugin entry point
- migration path for legacy plugins
* documented previously undocumented plugin methods
* split legacy plugin registration into a wrapper class
also added `PluginApi` namespace and `RegistrationInterface`
* reuse psalm's config search algorithm
* enable/disable plugins by composer package name
* allow specifying alternative config file name
* whitelist PluginApi namespace
three times, but well, it works now
* interface for plugin entry points
* psalm-plugin as a symfony console app
* fixed errors found by psalm
* suppressed false positive UnusedMethods
* cs fix
* better psalm-plugin output
* don't leave empty `plugins` node to avoid old schema violation
* removed junk file that shouldn't be there
* cs fix
* fixed phpunit failure (constant redefinition)
* work around missing docblock in on symfony console
* php 7.0 compatibility
* allow `pluginClass` child elements as plugin configuration
* decouple console commands from undelying implementation
- introduce PluginListFactory
- add `PluginList::enable(string $class)` and `PluginList::disable(string $class)`
* PluginList tests
* ComposerLock test
* droppped debugging statement
* added part of console command tests
* added tests for EnableCommand
* added DisableCommand tests
* ignore unused args
* ConfigFile test
* disable travis cache in attempt to fix builds
* nah, that didn't work
* update for upstream changes
* rebase fixes
* namespaced `extra` entry for entry point
* s/PluginFacade/PluginRegistrationSocket/g
* Added $config parameter to PluginEntryPointInterface::__invoke()
* cs fixes
* entry point interface php7.0 compatibility
* cleaned up old cruft
- dropped todos I'm not going to pursues
- locked entry point to be a class implementing entry point interface
* fixed legacy plugins docs
* Added RegistrationInterface::registerHooksFromClass()
It mimics the way old plugins were registered in Psalm\Config, so
handler classes extending Psalm\Plugin should be fully compatible with
it.
Since Psalm\Plugin-style plugin registration was moved to
RegistrationSocket, LegacyPlugin now only load file-based plugins, so it
was renamed to FileBasedPluginAdapter.
* Converted EchoChecker plugin to composer-based format
- Its subfolder is registered as a local composer package in the root
composer.json, so it's directly installable with
```
composer require psalm/echo-checker-plugin
```
- Migration is trivial: drop the plugin into a separate folder, then add
simple composer.json and the entry point class.
* Updated docs
* Don't reject hook handlers that inherit handling methods
* strip void return type in stub file
2018-11-11 05:23:36 +01:00
|
|
|
*/
|
|
|
|
public function showsHelpForCommand(string $command)
|
|
|
|
{
|
|
|
|
$help_command = new CommandTester($this->app->find('help'));
|
|
|
|
$help_command->execute(['command_name' => $command]);
|
|
|
|
$output = $help_command->getDisplay();
|
|
|
|
$this->assertRegExp('/Usage:$\s+' . preg_quote($command, '/') . '\b/m', $output);
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @return void
|
|
|
|
* @test
|
|
|
|
*/
|
|
|
|
public function requiresPluginNameToEnable()
|
|
|
|
{
|
|
|
|
$enable_command = new CommandTester($this->app->find('enable'));
|
|
|
|
$this->expectExceptionMessage('missing: "pluginName"');
|
|
|
|
$enable_command->execute([]);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @return void
|
|
|
|
* @test
|
|
|
|
*/
|
|
|
|
public function enableComplainsWhenPassedUnresolvablePlugin()
|
|
|
|
{
|
|
|
|
$this->plugin_list->resolvePluginClass(Argument::any())->willThrow(new \InvalidArgumentException);
|
|
|
|
|
|
|
|
$enable_command = new CommandTester($this->app->find('enable'));
|
|
|
|
$enable_command->execute(['pluginName' => 'vendor/package']);
|
|
|
|
|
|
|
|
$output = $enable_command->getDisplay();
|
|
|
|
|
|
|
|
$this->assertContains('ERROR', $output);
|
|
|
|
$this->assertContains('Unknown plugin', $output);
|
|
|
|
$this->assertNotEquals(0, $enable_command->getStatusCode());
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @return void
|
|
|
|
* @test
|
|
|
|
*/
|
|
|
|
public function enableComplainsWhenPassedAlreadyEnabledPlugin()
|
|
|
|
{
|
|
|
|
$this->plugin_list->resolvePluginClass('vendor/package')->will(
|
|
|
|
function (array $_args, ObjectProphecy $plugin_list): string {
|
|
|
|
/** @psalm-suppress TooManyArguments */
|
|
|
|
$plugin_list->isEnabled('Vendor\Package\PluginClass')->willReturn(true);
|
|
|
|
return 'Vendor\Package\PluginClass';
|
|
|
|
}
|
|
|
|
);
|
|
|
|
|
|
|
|
$enable_command = new CommandTester($this->app->find('enable'));
|
|
|
|
$enable_command->execute(['pluginName' => 'vendor/package']);
|
|
|
|
|
|
|
|
$output = $enable_command->getDisplay();
|
|
|
|
$this->assertContains('Plugin already enabled', $output);
|
|
|
|
$this->assertNotEquals(0, $enable_command->getStatusCode());
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @return void
|
|
|
|
* @test
|
|
|
|
*/
|
|
|
|
public function enableReportsSuccessWhenItEnablesPlugin()
|
|
|
|
{
|
|
|
|
$this->plugin_list->resolvePluginClass('vendor/package')->will(
|
|
|
|
function (array $_args, ObjectProphecy $plugin_list): string {
|
|
|
|
$plugin_class = 'Vendor\Package\PluginClass';
|
|
|
|
/** @psalm-suppress TooManyArguments */
|
|
|
|
$plugin_list->isEnabled($plugin_class)->willReturn(false);
|
|
|
|
/** @psalm-suppress TooManyArguments */
|
|
|
|
$plugin_list->enable($plugin_class)->shouldBeCalled();
|
|
|
|
return $plugin_class;
|
|
|
|
}
|
|
|
|
);
|
|
|
|
|
|
|
|
$enable_command = new CommandTester($this->app->find('enable'));
|
|
|
|
$enable_command->execute(['pluginName' => 'vendor/package']);
|
|
|
|
|
|
|
|
$output = $enable_command->getDisplay();
|
|
|
|
$this->assertContains('Plugin enabled', $output);
|
|
|
|
$this->assertEquals(0, $enable_command->getStatusCode());
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @return void
|
|
|
|
* @test
|
|
|
|
*/
|
|
|
|
public function requiresPluginNameToDisable()
|
|
|
|
{
|
|
|
|
$disable_command = new CommandTester($this->app->find('disable'));
|
|
|
|
$this->expectExceptionMessage('missing: "pluginName"');
|
|
|
|
$disable_command->execute([]);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @return void
|
|
|
|
* @test
|
|
|
|
*/
|
|
|
|
public function disableComplainsWhenPassedUnresolvablePlugin()
|
|
|
|
{
|
|
|
|
|
|
|
|
$this->plugin_list->resolvePluginClass(Argument::any())->willThrow(new \InvalidArgumentException);
|
|
|
|
|
|
|
|
$disable_command = new CommandTester($this->app->find('disable'));
|
|
|
|
$disable_command->execute(['pluginName' => 'vendor/package']);
|
|
|
|
|
|
|
|
$output = $disable_command->getDisplay();
|
|
|
|
|
|
|
|
$this->assertContains('ERROR', $output);
|
|
|
|
$this->assertContains('Unknown plugin', $output);
|
|
|
|
$this->assertNotEquals(0, $disable_command->getStatusCode());
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @return void
|
|
|
|
* @test
|
|
|
|
*/
|
|
|
|
public function disableComplainsWhenPassedNotEnabledPlugin()
|
|
|
|
{
|
|
|
|
$this->plugin_list->resolvePluginClass('vendor/package')->will(
|
|
|
|
function (array $_args, ObjectProphecy $plugin_list): string {
|
|
|
|
/** @psalm-suppress TooManyArguments */
|
|
|
|
$plugin_list->isEnabled('Vendor\Package\PluginClass')->willReturn(false);
|
|
|
|
return 'Vendor\Package\PluginClass';
|
|
|
|
}
|
|
|
|
);
|
|
|
|
|
|
|
|
$disable_command = new CommandTester($this->app->find('disable'));
|
|
|
|
$disable_command->execute(['pluginName' => 'vendor/package']);
|
|
|
|
|
|
|
|
$output = $disable_command->getDisplay();
|
|
|
|
$this->assertContains('Plugin already disabled', $output);
|
|
|
|
$this->assertNotEquals(0, $disable_command->getStatusCode());
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @return void
|
|
|
|
* @test
|
|
|
|
*/
|
|
|
|
public function disableReportsSuccessWhenItDisablesPlugin()
|
|
|
|
{
|
|
|
|
$this->plugin_list->resolvePluginClass('vendor/package')->will(
|
|
|
|
function (array $_args, ObjectProphecy $plugin_list): string {
|
|
|
|
$plugin_class = 'Vendor\Package\PluginClass';
|
|
|
|
/** @psalm-suppress TooManyArguments */
|
|
|
|
$plugin_list->isEnabled($plugin_class)->willReturn(true);
|
|
|
|
/** @psalm-suppress TooManyArguments */
|
|
|
|
$plugin_list->disable($plugin_class)->shouldBeCalled();
|
|
|
|
return $plugin_class;
|
|
|
|
}
|
|
|
|
);
|
|
|
|
|
|
|
|
$disable_command = new CommandTester($this->app->find('disable'));
|
|
|
|
$disable_command->execute(['pluginName' => 'vendor/package']);
|
|
|
|
|
|
|
|
$output = $disable_command->getDisplay();
|
|
|
|
$this->assertContains('Plugin disabled', $output);
|
|
|
|
$this->assertEquals(0, $disable_command->getStatusCode());
|
|
|
|
}
|
|
|
|
|
|
|
|
/** @return string[][] */
|
|
|
|
public function commands(): array
|
|
|
|
{
|
|
|
|
return [
|
|
|
|
['show',],
|
|
|
|
['enable',],
|
|
|
|
['disable',],
|
|
|
|
];
|
|
|
|
}
|
|
|
|
}
|