2019-12-06 20:58:18 +01:00
|
|
|
<?php
|
|
|
|
namespace Psalm\Tests\TypeReconciliation;
|
|
|
|
|
|
|
|
use Psalm\Context;
|
|
|
|
use Psalm\Internal\Analyzer\FileAnalyzer;
|
|
|
|
use Psalm\Internal\Analyzer\StatementsAnalyzer;
|
2020-07-22 01:40:35 +02:00
|
|
|
use Psalm\Internal\Type\Comparator\UnionTypeComparator;
|
2019-12-06 20:58:18 +01:00
|
|
|
use Psalm\Type;
|
|
|
|
|
|
|
|
class ReconcilerTest extends \Psalm\Tests\TestCase
|
|
|
|
{
|
|
|
|
/** @var FileAnalyzer */
|
|
|
|
protected $file_analyzer;
|
|
|
|
|
|
|
|
/** @var StatementsAnalyzer */
|
|
|
|
protected $statements_analyzer;
|
|
|
|
|
|
|
|
public function setUp() : void
|
|
|
|
{
|
|
|
|
parent::setUp();
|
|
|
|
|
|
|
|
$this->file_analyzer = new FileAnalyzer($this->project_analyzer, 'somefile.php', 'somefile.php');
|
|
|
|
$this->file_analyzer->context = new Context();
|
|
|
|
$this->statements_analyzer = new StatementsAnalyzer(
|
|
|
|
$this->file_analyzer,
|
|
|
|
new \Psalm\Internal\Provider\NodeDataProvider()
|
|
|
|
);
|
2020-03-14 19:48:45 +01:00
|
|
|
|
|
|
|
$this->addFile('newfile.php', '
|
|
|
|
<?php
|
|
|
|
class A {}
|
|
|
|
class B extends A {}
|
|
|
|
');
|
|
|
|
$this->project_analyzer->getCodebase()->scanFiles();
|
2019-12-06 20:58:18 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @dataProvider providerTestReconcilation
|
|
|
|
*
|
|
|
|
*/
|
2020-11-26 16:00:03 +01:00
|
|
|
public function testReconcilation(string $expected_type, string $assertion, string $original_type): void
|
2019-12-06 20:58:18 +01:00
|
|
|
{
|
|
|
|
$reconciled = \Psalm\Internal\Type\AssertionReconciler::reconcile(
|
2020-11-26 16:00:03 +01:00
|
|
|
$assertion,
|
|
|
|
Type::parseString($original_type),
|
2019-12-06 20:58:18 +01:00
|
|
|
null,
|
|
|
|
$this->statements_analyzer,
|
|
|
|
false,
|
|
|
|
[]
|
|
|
|
);
|
|
|
|
|
|
|
|
$this->assertSame(
|
2020-11-26 16:00:03 +01:00
|
|
|
$expected_type,
|
2019-12-06 20:58:18 +01:00
|
|
|
$reconciled->getId()
|
|
|
|
);
|
|
|
|
|
2020-02-22 17:28:24 +01:00
|
|
|
$this->assertContainsOnlyInstancesOf('Psalm\Type\Atomic', $reconciled->getAtomicTypes());
|
2019-12-06 20:58:18 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @dataProvider providerTestTypeIsContainedBy
|
|
|
|
*
|
|
|
|
* @param string $input
|
|
|
|
* @param string $container
|
|
|
|
*
|
|
|
|
*/
|
2020-09-12 17:24:05 +02:00
|
|
|
public function testTypeIsContainedBy($input, $container): void
|
2019-12-06 20:58:18 +01:00
|
|
|
{
|
|
|
|
$this->assertTrue(
|
2020-07-22 01:40:35 +02:00
|
|
|
UnionTypeComparator::isContainedBy(
|
2019-12-06 20:58:18 +01:00
|
|
|
$this->project_analyzer->getCodebase(),
|
|
|
|
Type::parseString($input),
|
|
|
|
Type::parseString($container)
|
|
|
|
)
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @return array<string,array{string,string,string}>
|
|
|
|
*/
|
2020-09-12 17:24:05 +02:00
|
|
|
public function providerTestReconcilation(): array
|
2019-12-06 20:58:18 +01:00
|
|
|
{
|
|
|
|
return [
|
|
|
|
'notNullWithObject' => ['MyObject', '!null', 'MyObject'],
|
|
|
|
'notNullWithObjectPipeNull' => ['MyObject', '!null', 'MyObject|null'],
|
|
|
|
'notNullWithMyObjectPipeFalse' => ['MyObject|false', '!null', 'MyObject|false'],
|
|
|
|
'notNullWithMixed' => ['mixed', '!null', 'mixed'],
|
|
|
|
|
|
|
|
'notEmptyWithMyObject' => ['MyObject', '!falsy', 'MyObject'],
|
|
|
|
'notEmptyWithMyObjectPipeNull' => ['MyObject', '!falsy', 'MyObject|null'],
|
|
|
|
'notEmptyWithMyObjectPipeFalse' => ['MyObject', '!falsy', 'MyObject|false'],
|
|
|
|
'notEmptyWithMixed' => ['non-empty-mixed', '!falsy', 'mixed'],
|
|
|
|
// @todo in the future this should also work
|
|
|
|
//'notEmptyWithMyObjectFalseTrue' => ['MyObject|true', '!falsy', 'MyObject|bool'],
|
|
|
|
|
|
|
|
'nullWithMyObjectPipeNull' => ['null', 'null', 'MyObject|null'],
|
|
|
|
'nullWithMixed' => ['null', 'null', 'mixed'],
|
|
|
|
|
|
|
|
'falsyWithMyObject' => ['mixed', 'falsy', 'MyObject'],
|
|
|
|
'falsyWithMyObjectPipeFalse' => ['false', 'falsy', 'MyObject|false'],
|
|
|
|
'falsyWithMyObjectPipeBool' => ['false', 'falsy', 'MyObject|bool'],
|
|
|
|
'falsyWithMixed' => ['empty-mixed', 'falsy', 'mixed'],
|
|
|
|
'falsyWithBool' => ['false', 'falsy', 'bool'],
|
|
|
|
'falsyWithStringOrNull' => ['null|string()|string(0)', 'falsy', 'string|null'],
|
|
|
|
'falsyWithScalarOrNull' => ['empty-scalar', 'falsy', 'scalar'],
|
|
|
|
|
|
|
|
'notMyObjectWithMyObjectPipeBool' => ['bool', '!MyObject', 'MyObject|bool'],
|
|
|
|
'notMyObjectWithMyObjectPipeNull' => ['null', '!MyObject', 'MyObject|null'],
|
|
|
|
'notMyObjectWithMyObjectAPipeMyObjectB' => ['MyObjectB', '!MyObjectA', 'MyObjectA|MyObjectB'],
|
|
|
|
|
|
|
|
'myObjectWithMyObjectPipeBool' => ['MyObject', 'MyObject', 'MyObject|bool'],
|
|
|
|
'myObjectWithMyObjectAPipeMyObjectB' => ['MyObjectA', 'MyObjectA', 'MyObjectA|MyObjectB'],
|
|
|
|
|
|
|
|
'array' => ['array<array-key, mixed>', 'array', 'array|null'],
|
|
|
|
|
|
|
|
'2dArray' => ['array<array-key, array<array-key, string>>', 'array', 'array<array<string>>|null'],
|
|
|
|
|
|
|
|
'numeric' => ['numeric-string', 'numeric', 'string'],
|
|
|
|
|
|
|
|
'nullableClassString' => ['null', 'falsy', '?class-string'],
|
|
|
|
'mixedOrNullNotFalsy' => ['non-empty-mixed', '!falsy', 'mixed|null'],
|
|
|
|
'mixedOrNullFalsy' => ['empty-mixed|null', 'falsy', 'mixed|null'],
|
|
|
|
'nullableClassStringFalsy' => ['null', 'falsy', 'class-string<A>|null'],
|
|
|
|
'nullableClassStringEqualsNull' => ['null', '=null', 'class-string<A>|null'],
|
|
|
|
'nullableClassStringTruthy' => ['class-string<A>', '!falsy', 'class-string<A>|null'],
|
|
|
|
'iterableToArray' => ['array<int, int>', 'array', 'iterable<int, int>'],
|
|
|
|
'iterableToTraversable' => ['Traversable<int, int>', 'Traversable', 'iterable<int, int>'],
|
2020-01-02 14:37:54 +01:00
|
|
|
'callableToCallableArray' => ['callable-array{0: class-string|object, 1: string}', 'array', 'callable'],
|
2021-01-22 22:14:29 +01:00
|
|
|
'SmallKeyedArrayAndCallable' => ['array{test: string}', 'array{test: string}', 'callable'],
|
|
|
|
'BigKeyedArrayAndCallable' => ['array{foo: string, test: string, thing: string}', 'array{foo: string, test: string, thing: string}', 'callable'],
|
2020-04-11 23:50:24 +02:00
|
|
|
'callableOrArrayToCallableArray' => ['array<array-key, mixed>', 'array', 'callable|array'],
|
2019-12-06 20:58:18 +01:00
|
|
|
'traversableToIntersection' => ['Countable&Traversable', 'Traversable', 'Countable'],
|
|
|
|
'iterableWithoutParamsToTraversableWithoutParams' => ['Traversable', '!array', 'iterable'],
|
|
|
|
'iterableWithParamsToTraversableWithParams' => ['Traversable<int, string>', '!array', 'iterable<int, string>'],
|
2020-11-27 15:10:55 +01:00
|
|
|
'iterableAndObject' => ['Traversable<int, string>', 'object', 'iterable<int, string>'],
|
2020-11-26 15:25:49 +01:00
|
|
|
'iterableAndNotObject' => ['array<int, string>', '!object', 'iterable<int, string>'],
|
2021-01-19 23:19:47 +01:00
|
|
|
'boolNotEmptyIsTrue' => ['true', '!empty', 'bool'],
|
2019-12-06 20:58:18 +01:00
|
|
|
];
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @return array<string,array{string,string}>
|
|
|
|
*/
|
2020-09-12 17:24:05 +02:00
|
|
|
public function providerTestTypeIsContainedBy(): array
|
2019-12-06 20:58:18 +01:00
|
|
|
{
|
|
|
|
return [
|
|
|
|
'arrayContainsWithArrayOfStrings' => ['array<string>', 'array'],
|
|
|
|
'arrayContainsWithArrayOfExceptions' => ['array<Exception>', 'array'],
|
2020-03-14 19:48:45 +01:00
|
|
|
'arrayOfIterable' => ['array', 'iterable'],
|
|
|
|
'arrayOfIterableWithType' => ['array<A>', 'iterable<A>'],
|
|
|
|
'arrayOfIterableWithSubclass' => ['array<B>', 'iterable<A>'],
|
|
|
|
'arrayOfSubclassOfParent' => ['array<B>', 'array<A>'],
|
|
|
|
'subclassOfParent' => ['B', 'A'],
|
2019-12-06 20:58:18 +01:00
|
|
|
'unionContainsWithstring' => ['string', 'string|false'],
|
|
|
|
'unionContainsWithFalse' => ['false', 'string|false'],
|
|
|
|
'objectLikeTypeWithPossiblyUndefinedToGeneric' => [
|
|
|
|
'array{0: array{a: string}, 1: array{c: string, e: string}}',
|
|
|
|
'array<int, array<string, string>>',
|
|
|
|
],
|
|
|
|
'objectLikeTypeWithPossiblyUndefinedToEmpty' => [
|
|
|
|
'array<empty, empty>',
|
|
|
|
'array{a?: string, b?: string}',
|
|
|
|
],
|
2020-09-08 05:29:46 +02:00
|
|
|
'literalNumericStringInt' => [
|
|
|
|
'"0"',
|
|
|
|
'numeric',
|
|
|
|
],
|
|
|
|
'literalNumericString' => [
|
|
|
|
'"10.03"',
|
|
|
|
'numeric',
|
|
|
|
],
|
2019-12-06 20:58:18 +01:00
|
|
|
];
|
|
|
|
}
|
|
|
|
}
|