1
0
mirror of https://github.com/danog/psalm.git synced 2024-12-12 09:19:40 +01:00
psalm/docs/running_psalm/issues/TaintedFile.md

44 lines
1.5 KiB
Markdown
Raw Normal View History

# TaintedFile
This rule is emitted when user-controlled input can be passed into a sensitive file operation.
## Risk
The risk here depends on the actual operation that contains user-controlled input, and how it is later on processed.
It could range from:
- Creating files
- Example: `file_put_contents`
- Risk: Depending on the server configuration this may result in remote code execution. (e.g. writing a file in the web root)
- Modifying files
- Example: `file_put_contents`
- Risk: Depending on the server configuration this may result in remote code execution. (e.g. modifying a PHP file)
- Reading files
- Example: `file_get_contents`
- Risk: Sensitive data could be exposed from the filesystem. (e.g. config values, source code, user-submitted files)
- Deleting files
- Example: `unlink`
- Risk: Denial of Service or potentially RCE. (e.g. deleting application code, removing a .htaccess file)
## Example
```php
<?php
$content = file_get_contents($_GET['header']);
echo $content;
```
## Mitigations
Use an allowlist approach where possible to verify names on file operations.
Sanitize user-controlled filenames by stripping `..`, `\` and `/`.
## Further resources
- [File Upload Cheat Sheet](https://cheatsheetseries.owasp.org/cheatsheets/File_Upload_Cheat_Sheet.html)
- [OWASP Wiki for Unrestricted FIle Upload](https://owasp.org/www-community/vulnerabilities/Unrestricted_File_Upload)
- [CWE-73](https://cwe.mitre.org/data/definitions/73.html)