danog/psalm
1
0
Fork 0
mirror of https://github.com/danog/psalm.git synced 2024-11-30 04:39:00 +01:00
Code Issues Projects Releases Wiki Activity

array_pop is impure

Browse Source 
Fixes vimeo/psalm#9429
This commit is contained in:
Bruce Weirdan 2023-02-28 18:53:36 -04:00
parent 381a23bd4e
commit 007ffaecd8
No known key found for this signature in database
GPG Key ID: CFC3AAB181751B0D
2 changed files with 25 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/Psalm/Internal/Codebase/Functions.php
View File

@ -476,6 +476,7 @@ class Functions
'date_default_timezone_set', 'assert_options', 'setlocale',
'set_exception_handler', 'set_time_limit', 'putenv', 'spl_autoload_register',
'spl_autoload_unregister', 'microtime', 'array_rand', 'set_include_path',
'array_pop',
// logging
'openlog', 'syslog', 'error_log', 'define_syslog_variables',

24
tests/PureAnnotationTest.php
View File

@ -902,6 +902,30 @@ class PureAnnotationTest extends TestCase
',
'error_message' => 'ImpureFunctionCall',
],
'array_popIsNotMutationFree' => [
'code' => <<<'PHP'
<?php
class Stack
{
/** @var array<string> */
private array $stack = [];
public function push(string $item): void
{
$this->stack[] = $item;
}
/** @psalm-mutation-free */
public function next(): string|null
{
return array_pop($this->stack);
}
}
PHP,
'error_message' => 'ImpureFunctionCall',
'ignored_issues' => [],
'php_version' => '8.0',
],
];
}
}