Migrate Codebase-namespaced and FileManipulation-namespaced classes to internals

examples/plugins/ClassUnqualifier.php

@@ -3,7 +3,7 @@ namespace Psalm\Example\Plugin;
 
 use Psalm\Codebase;
 use Psalm\CodeLocation;
-use Psalm\FileManipulation\FileManipulation;
+use Psalm\FileManipulation;
 use Psalm\FileSource;
 use Psalm\Plugin\Hook\AfterClassLikeExistenceCheckInterface;
 use Psalm\StatementsSource;

examples/plugins/StringChecker.php

@@ -7,7 +7,7 @@ use Psalm\Checker\StatementsChecker;
 use Psalm\Codebase;
 use Psalm\CodeLocation;
 use Psalm\Context;
-use Psalm\FileManipulation\FileManipulation;
+use Psalm\FileManipulation;
 use Psalm\IssueBuffer;
 use Psalm\Issue\TypeCoercion;
 use Psalm\Plugin\Hook\AfterExpressionAnalysisInterface;

examples/plugins/composer-based/echo-checker/EchoChecker.php

@@ -5,7 +5,7 @@ use PhpParser;
 use Psalm\Codebase;
 use Psalm\CodeLocation;
 use Psalm\Context;
-use Psalm\FileManipulation\FileManipulation;
+use Psalm\FileManipulation;
 use Psalm\IssueBuffer;
 use Psalm\Issue\TypeCoercion;
 use Psalm\Plugin\Hook\AfterStatementAnalysisInterface;

psalm.xml.dist

@@ -71,7 +71,7 @@
 
         <UnusedProperty>
             <errorLevel type="info">
-                <file name="src/Psalm/FileManipulation/FunctionDocblockManipulator.php" />
+                <file name="src/Psalm/Internal/FileManipulation/FunctionDocblockManipulator.php" />
             </errorLevel>
         </UnusedProperty>
 

src/Psalm/Codebase.php

@@ -98,42 +98,42 @@ class Codebase
     public $find_unused_code = false;
 
     /**
-     * @var Codebase\Reflection
+     * @var Internal\Codebase\Reflection
      */
     private $reflection;
 
     /**
-     * @var Codebase\Scanner
+     * @var Internal\Codebase\Scanner
      */
     public $scanner;
 
     /**
-     * @var Codebase\Analyzer
+     * @var Internal\Codebase\Analyzer
      */
     public $analyzer;
 
     /**
-     * @var Codebase\Functions
+     * @var Internal\Codebase\Functions
      */
     public $functions;
 
     /**
-     * @var Codebase\ClassLikes
+     * @var Internal\Codebase\ClassLikes
      */
     public $classlikes;
 
     /**
-     * @var Codebase\Methods
+     * @var Internal\Codebase\Methods
      */
     public $methods;
 
     /**
-     * @var Codebase\Properties
+     * @var Internal\Codebase\Properties
      */
     public $properties;
 
     /**
-     * @var Codebase\Populator
+     * @var Internal\Codebase\Populator
      */
     public $populator;
 
@@ -179,9 +179,9 @@ class Codebase
 
         self::$stubbed_constants = [];
 
-        $this->reflection = new Codebase\Reflection($providers->classlike_storage_provider, $this);
+        $this->reflection = new Internal\Codebase\Reflection($providers->classlike_storage_provider, $this);
 
-        $this->scanner = new Codebase\Scanner(
+        $this->scanner = new Internal\Codebase\Scanner(
             $this,
             $config,
             $providers->file_storage_provider,
@@ -193,24 +193,24 @@ class Codebase
 
         $this->loadAnalyzer();
 
-        $this->functions = new Codebase\Functions($providers->file_storage_provider, $this->reflection);
+        $this->functions = new Internal\Codebase\Functions($providers->file_storage_provider, $this->reflection);
-        $this->methods = new Codebase\Methods(
+        $this->methods = new Internal\Codebase\Methods(
             $config,
             $providers->classlike_storage_provider,
             $providers->file_reference_provider
         );
-        $this->properties = new Codebase\Properties(
+        $this->properties = new Internal\Codebase\Properties(
             $providers->classlike_storage_provider,
             $providers->file_reference_provider
         );
 
-        $this->classlikes = new Codebase\ClassLikes(
+        $this->classlikes = new Internal\Codebase\ClassLikes(
             $this->config,
             $providers->classlike_storage_provider,
             $this->scanner,
             $this->methods
         );
-        $this->populator = new Codebase\Populator(
+        $this->populator = new Internal\Codebase\Populator(
             $config,
             $providers->classlike_storage_provider,
             $providers->file_storage_provider,
@@ -227,7 +227,7 @@ class Codebase
      */
     private function loadAnalyzer()
     {
-        $this->analyzer = new Codebase\Analyzer(
+        $this->analyzer = new Internal\Codebase\Analyzer(
             $this->config,
             $this->file_provider,
             $this->file_storage_provider,

src/Psalm/FileManipulation.php

@@ -1,5 +1,5 @@
 <?php
-namespace Psalm\FileManipulation;
+namespace Psalm;
 
 class FileManipulation
 {

src/Psalm/Internal/Analyzer/ClassLikeAnalyzer.php

@@ -7,7 +7,7 @@ use Psalm\Codebase;
 use Psalm\CodeLocation;
 use Psalm\Config;
 use Psalm\Context;
-use Psalm\FileManipulation\FileManipulationBuffer;
+use Psalm\Internal\FileManipulation\FileManipulationBuffer;
 use Psalm\Issue\DuplicateClass;
 use Psalm\Issue\InaccessibleProperty;
 use Psalm\Issue\InvalidClass;

src/Psalm/Internal/Analyzer/FileAnalyzer.php

@@ -5,7 +5,7 @@ use PhpParser;
 use Psalm\Codebase;
 use Psalm\Context;
 use Psalm\Exception\UnpreparedAnalysisException;
-use Psalm\FileManipulation\FileManipulationBuffer;
+use Psalm\Internal\FileManipulation\FileManipulationBuffer;
 use Psalm\IssueBuffer;
 use Psalm\StatementsSource;
 use Psalm\Type;

src/Psalm/Internal/Analyzer/FunctionAnalyzer.php

@@ -3,7 +3,7 @@ namespace Psalm\Internal\Analyzer;
 
 use PhpParser;
 use Psalm\Internal\Analyzer\Statements\Expression\AssertionFinder;
-use Psalm\Codebase\CallMap;
+use Psalm\Internal\Codebase\CallMap;
 use Psalm\Context;
 use Psalm\CodeLocation;
 use Psalm\Issue\InvalidArgument;

src/Psalm/Internal/Analyzer/FunctionLike/ReturnTypeAnalyzer.php

@@ -16,7 +16,7 @@ use Psalm\Internal\Analyzer\StatementsAnalyzer;
 use Psalm\Internal\Analyzer\TypeAnalyzer;
 use Psalm\CodeLocation;
 use Psalm\Context;
-use Psalm\FileManipulation\FunctionDocblockManipulator;
+use Psalm\Internal\FileManipulation\FunctionDocblockManipulator;
 use Psalm\Issue\InvalidFalsableReturnType;
 use Psalm\Issue\InvalidNullableReturnType;
 use Psalm\Issue\InvalidReturnType;

src/Psalm/Internal/Analyzer/FunctionLikeAnalyzer.php

@@ -9,10 +9,10 @@ use Psalm\Codebase;
 use Psalm\Internal\Analyzer\FunctionLike\ReturnTypeAnalyzer;
 use Psalm\Internal\Analyzer\FunctionLike\ReturnTypeCollector;
 use Psalm\Internal\Analyzer\Statements\ExpressionAnalyzer;
-use Psalm\Codebase\CallMap;
+use Psalm\Internal\Codebase\CallMap;
 use Psalm\CodeLocation;
 use Psalm\Context;
-use Psalm\FileManipulation\FunctionDocblockManipulator;
+use Psalm\Internal\FileManipulation\FunctionDocblockManipulator;
 use Psalm\Issue\InvalidParamDefault;
 use Psalm\Issue\MismatchingDocblockParamType;
 use Psalm\Issue\MissingClosureParamType;

src/Psalm/Internal/Analyzer/Statements/Expression/Call/FunctionCallAnalyzer.php

@@ -7,10 +7,10 @@ use Psalm\Internal\Analyzer\FunctionLikeAnalyzer;
 use Psalm\Internal\Analyzer\ProjectAnalyzer;
 use Psalm\Internal\Analyzer\Statements\ExpressionAnalyzer;
 use Psalm\Internal\Analyzer\StatementsAnalyzer;
-use Psalm\Codebase\CallMap;
+use Psalm\Internal\Codebase\CallMap;
 use Psalm\CodeLocation;
 use Psalm\Context;
-use Psalm\FileManipulation\FileManipulationBuffer;
+use Psalm\Internal\FileManipulation\FileManipulationBuffer;
 use Psalm\Issue\ForbiddenCode;
 use Psalm\Issue\InvalidFunctionCall;
 use Psalm\Issue\NullFunctionCall;

src/Psalm/Internal/Analyzer/Statements/Expression/Call/MethodCallAnalyzer.php

@@ -8,11 +8,11 @@ use Psalm\Internal\Analyzer\MethodAnalyzer;
 use Psalm\Internal\Analyzer\Statements\ExpressionAnalyzer;
 use Psalm\Internal\Analyzer\StatementsAnalyzer;
 use Psalm\Internal\Analyzer\TypeAnalyzer;
-use Psalm\Codebase\CallMap;
+use Psalm\Internal\Codebase\CallMap;
 use Psalm\CodeLocation;
 use Psalm\Config;
 use Psalm\Context;
-use Psalm\FileManipulation\FileManipulationBuffer;
+use Psalm\Internal\FileManipulation\FileManipulationBuffer;
 use Psalm\Issue\InvalidMethodCall;
 use Psalm\Issue\InvalidPropertyAssignmentValue;
 use Psalm\Issue\InvalidScope;

src/Psalm/Internal/Analyzer/Statements/Expression/Call/StaticCallAnalyzer.php

@@ -10,7 +10,7 @@ use Psalm\Internal\Analyzer\StatementsAnalyzer;
 use Psalm\CodeLocation;
 use Psalm\Config;
 use Psalm\Context;
-use Psalm\FileManipulation\FileManipulationBuffer;
+use Psalm\Internal\FileManipulation\FileManipulationBuffer;
 use Psalm\Issue\DeprecatedClass;
 use Psalm\Issue\InvalidStringClass;
 use Psalm\Issue\ParentNotFound;

src/Psalm/Internal/Analyzer/Statements/Expression/CallAnalyzer.php

@@ -8,7 +8,7 @@ use Psalm\Internal\Analyzer\MethodAnalyzer;
 use Psalm\Internal\Analyzer\Statements\ExpressionAnalyzer;
 use Psalm\Internal\Analyzer\StatementsAnalyzer;
 use Psalm\Internal\Analyzer\TypeAnalyzer;
-use Psalm\Codebase\CallMap;
+use Psalm\Internal\Codebase\CallMap;
 use Psalm\CodeLocation;
 use Psalm\Context;
 use Psalm\Issue\ImplicitToStringCast;

src/Psalm/Internal/Analyzer/Statements/ExpressionAnalyzer.php

@@ -28,7 +28,7 @@ use Psalm\CodeLocation;
 use Psalm\Config;
 use Psalm\Context;
 use Psalm\Exception\DocblockParseException;
-use Psalm\FileManipulation\FileManipulationBuffer;
+use Psalm\Internal\FileManipulation\FileManipulationBuffer;
 use Psalm\FileSource;
 use Psalm\Issue\ForbiddenCode;
 use Psalm\Issue\InvalidCast;

src/Psalm/Internal/Analyzer/StatementsAnalyzer.php

@@ -23,8 +23,8 @@ use Psalm\Config;
 use Psalm\Context;
 use Psalm\DocComment;
 use Psalm\Exception\DocblockParseException;
-use Psalm\FileManipulation\FileManipulation;
+use Psalm\FileManipulation;
-use Psalm\FileManipulation\FileManipulationBuffer;
+use Psalm\Internal\FileManipulation\FileManipulationBuffer;
 use Psalm\Issue\ContinueOutsideLoop;
 use Psalm\Issue\ForbiddenCode;
 use Psalm\Issue\ForbiddenEcho;

src/Psalm/Internal/Codebase/Analyzer.php

@@ -1,13 +1,13 @@
 <?php
-namespace Psalm\Codebase;
+namespace Psalm\Internal\Codebase;
 
 use PhpParser;
 use Psalm\Internal\Analyzer\FileAnalyzer;
 use Psalm\Internal\Analyzer\ProjectAnalyzer;
 use Psalm\Config;
-use Psalm\FileManipulation\FileManipulation;
+use Psalm\FileManipulation;
-use Psalm\FileManipulation\FileManipulationBuffer;
+use Psalm\Internal\FileManipulation\FileManipulationBuffer;
-use Psalm\FileManipulation\FunctionDocblockManipulator;
+use Psalm\Internal\FileManipulation\FunctionDocblockManipulator;
 use Psalm\IssueBuffer;
 use Psalm\Internal\Provider\ClassLikeStorageProvider;
 use Psalm\Internal\Provider\FileProvider;

src/Psalm/Internal/Codebase/CallMap.php

@@ -1,5 +1,5 @@
 <?php
-namespace Psalm\Codebase;
+namespace Psalm\Internal\Codebase;
 
 use Psalm\Type;
 use Psalm\Storage\FunctionLikeParameter;
@@ -136,7 +136,7 @@ class CallMap
         }
 
         /** @var array<string, array<int|string, string>> */
-        $call_map = require_once(__DIR__ . '/../Internal/CallMap.php');
+        $call_map = require_once(__DIR__ . '/../CallMap.php');
 
         self::$call_map = [];
 

src/Psalm/Internal/Codebase/ClassLikes.php

@@ -1,5 +1,5 @@
 <?php
-namespace Psalm\Codebase;
+namespace Psalm\Internal\Codebase;
 
 use PhpParser;
 use Psalm\Aliases;

src/Psalm/Internal/Codebase/Functions.php

@@ -1,5 +1,5 @@
 <?php
-namespace Psalm\Codebase;
+namespace Psalm\Internal\Codebase;
 
 use Psalm\Codebase;
 use Psalm\Internal\Analyzer\ProjectAnalyzer;

src/Psalm/Internal/Codebase/Methods.php

@@ -1,5 +1,5 @@
 <?php
-namespace Psalm\Codebase;
+namespace Psalm\Internal\Codebase;
 
 use PhpParser;
 use Psalm\Internal\Analyzer\MethodAnalyzer;

src/Psalm/Internal/Codebase/Populator.php

@@ -1,5 +1,5 @@
 <?php
-namespace Psalm\Codebase;
+namespace Psalm\Internal\Codebase;
 
 use Psalm\Internal\Analyzer\ClassLikeAnalyzer;
 use Psalm\Config;

src/Psalm/Internal/Codebase/Properties.php

@@ -1,5 +1,5 @@
 <?php
-namespace Psalm\Codebase;
+namespace Psalm\Internal\Codebase;
 
 use Psalm\CodeLocation;
 use Psalm\Internal\Provider\ClassLikeStorageProvider;

src/Psalm/Internal/Codebase/PropertyMap.php

@@ -1,5 +1,5 @@
 <?php
-namespace Psalm\Codebase;
+namespace Psalm\Internal\Codebase;
 
 class PropertyMap
 {
@@ -22,7 +22,7 @@ class PropertyMap
         }
 
         /** @var array<string, array<string, string>> */
-        $property_map = require_once(__DIR__ . '/../Internal/PropertyMap.php');
+        $property_map = require_once(__DIR__ . '/../PropertyMap.php');
 
         self::$property_map = [];
 

src/Psalm/Internal/Codebase/Reflection.php

@@ -1,5 +1,5 @@
 <?php
-namespace Psalm\Codebase;
+namespace Psalm\Internal\Codebase;
 
 use Psalm\Internal\Analyzer\ClassLikeAnalyzer;
 use Psalm\Internal\Analyzer\CommentAnalyzer;

src/Psalm/Internal/Codebase/Scanner.php

@@ -1,5 +1,5 @@
 <?php
-namespace Psalm\Codebase;
+namespace Psalm\Internal\Codebase;
 
 use Psalm\Codebase;
 use Psalm\Config;

src/Psalm/Internal/FileManipulation/FileManipulationBuffer.php

@@ -1,5 +1,7 @@
 <?php
-namespace Psalm\FileManipulation;
+namespace Psalm\Internal\FileManipulation;
+
+use Psalm\FileManipulation;
 
 class FileManipulationBuffer
 {

src/Psalm/Internal/FileManipulation/FunctionDocblockManipulator.php

@@ -1,5 +1,7 @@
 <?php
-namespace Psalm\FileManipulation;
+namespace Psalm\Internal\FileManipulation;
+
+use Psalm\FileManipulation;
 
 use PhpParser\Node\Expr\Closure;
 use PhpParser\Node\FunctionLike;

src/Psalm/Internal/Visitor/DependencyFinderVisitor.php

@@ -10,8 +10,8 @@ use Psalm\Internal\Analyzer\Statements\Expression\CallAnalyzer;
 use Psalm\Internal\Analyzer\Statements\Expression\IncludeAnalyzer;
 use Psalm\Internal\Analyzer\StatementsAnalyzer;
 use Psalm\Codebase;
-use Psalm\Codebase\CallMap;
+use Psalm\Internal\Codebase\CallMap;
-use Psalm\Codebase\PropertyMap;
+use Psalm\Internal\Codebase\PropertyMap;
 use Psalm\CodeLocation;
 use Psalm\Config;
 use Psalm\DocComment;

src/Psalm/Plugin/Hook/AfterClassLikeExistenceCheckInterface.php

@@ -3,7 +3,7 @@ namespace Psalm\Plugin\Hook;
 
 use Psalm\CodeLocation;
 use Psalm\Codebase;
-use Psalm\FileManipulation\FileManipulation;
+use Psalm\FileManipulation;
 use Psalm\StatementsSource;
 
 interface AfterClassLikeExistenceCheckInterface

src/Psalm/Plugin/Hook/AfterClassLikeVisitInterface.php

@@ -3,7 +3,7 @@ namespace Psalm\Plugin\Hook;
 
 use PhpParser\Node\Stmt\ClassLike;
 use Psalm\Codebase;
-use Psalm\FileManipulation\FileManipulation;
+use Psalm\FileManipulation;
 use Psalm\StatementsSource;
 use Psalm\Storage\ClassLikeStorage;
 

src/Psalm/Plugin/Hook/AfterExpressionAnalysisInterface.php

@@ -4,7 +4,7 @@ namespace Psalm\Plugin\Hook;
 use PhpParser\Node\Expr;
 use Psalm\Codebase;
 use Psalm\Context;
-use Psalm\FileManipulation\FileManipulation;
+use Psalm\FileManipulation;
 use Psalm\StatementsSource;
 
 interface AfterExpressionAnalysisInterface

src/Psalm/Plugin/Hook/AfterFunctionCallAnalysisInterface.php

@@ -4,7 +4,7 @@ namespace Psalm\Plugin\Hook;
 use PhpParser\Node\Expr\FuncCall;
 use Psalm\Codebase;
 use Psalm\Context;
-use Psalm\FileManipulation\FileManipulation;
+use Psalm\FileManipulation;
 use Psalm\StatementsSource;
 use Psalm\Type\Union;
 

src/Psalm/Plugin/Hook/AfterMethodCallAnalysisInterface.php

@@ -6,7 +6,7 @@ use PhpParser\Node\Expr\MethodCall;
 use PhpParser\Node\Expr\StaticCall;
 use Psalm\Codebase;
 use Psalm\Context;
-use Psalm\FileManipulation\FileManipulation;
+use Psalm\FileManipulation;
 use Psalm\StatementsSource;
 use Psalm\Type\Union;
 

src/Psalm/Plugin/Hook/AfterStatementAnalysisInterface.php

@@ -4,7 +4,7 @@ namespace Psalm\Plugin\Hook;
 use PhpParser\Node\Stmt;
 use Psalm\Codebase;
 use Psalm\Context;
-use Psalm\FileManipulation\FileManipulation;
+use Psalm\FileManipulation;
 use Psalm\StatementsSource;
 
 interface AfterStatementAnalysisInterface

tests/ConfigTest.php

@@ -238,7 +238,6 @@ class ConfigTest extends TestCase
                         <directory name="src" />
                         <directory name="examples" />
                         <ignoreFiles>
-                            <file name="**/**/**/*Analyzer.php" />
                             <file name="**/**/**/**/*Analyzer.php" />
                             <file name="**/**/**/**/**/*Analyzer.php" />
                         </ignoreFiles>

tests/DocumentationTest.php

@@ -64,7 +64,7 @@ class DocumentationTest extends TestCase
     public function setUp()
     {
         FileAnalyzer::clearCache();
-        \Psalm\FileManipulation\FunctionDocblockManipulator::clearCache();
+        \Psalm\Internal\FileManipulation\FunctionDocblockManipulator::clearCache();
 
         $this->file_provider = new Provider\FakeFileProvider();
 

tests/FileManipulationTest.php

@@ -15,7 +15,7 @@ class FileManipulationTest extends TestCase
     public function setUp()
     {
         FileAnalyzer::clearCache();
-        \Psalm\FileManipulation\FunctionDocblockManipulator::clearCache();
+        \Psalm\Internal\FileManipulation\FunctionDocblockManipulator::clearCache();
 
         $this->file_provider = new Provider\FakeFileProvider();
     }

tests/FileReferenceTest.php

@@ -15,7 +15,7 @@ class FileReferenceTest extends TestCase
     public function setUp()
     {
         FileAnalyzer::clearCache();
-        \Psalm\FileManipulation\FunctionDocblockManipulator::clearCache();
+        \Psalm\Internal\FileManipulation\FunctionDocblockManipulator::clearCache();
 
         $this->file_provider = new Provider\FakeFileProvider();
 

tests/TypeParseTest.php

@@ -731,6 +731,6 @@ class TypeParseTest extends TestCase
      */
     public function providerTestValidCallMapType()
     {
-        return \Psalm\Codebase\CallMap::getCallMap();
+        return \Psalm\Internal\Codebase\CallMap::getCallMap();
     }
 }