danog/psalm
1
0
Fork 0
mirror of https://github.com/danog/psalm.git synced 2024-11-30 04:39:00 +01:00
Code Issues Projects Releases Wiki Activity

Fix #2290 - detect call on void type

Browse Source
This commit is contained in:
Matthew Brown 2019-11-01 13:05:28 +00:00
parent f2c82fa212
commit 050eb82f04
2 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/Psalm/Internal/Analyzer/Statements/Expression/Call/MethodCallAnalyzer.php
View File

@ -140,7 +140,10 @@ class MethodCallAnalyzer extends \Psalm\Internal\Analyzer\Statements\Expression\
$has_mock = false;
if ($class_type && $stmt->name instanceof PhpParser\Node\Identifier && $class_type->isNull()) {
if ($class_type
&& $stmt->name instanceof PhpParser\Node\Identifier
&& ($class_type->isNull() || $class_type->isVoid())
) {
if (IssueBuffer::accepts(
new NullReference(
'Cannot call method ' . $stmt->name->name . ' on null value',

10
tests/MethodCallTest.php
View File

@ -731,6 +731,16 @@ class MethodCallTest extends TestCase
}',
'error_message' => 'PossiblyNullArgument',
],
'callOnVoid' => [
'<?php
class A {
public function foo(): void {}
}
$p = new A();
$p->foo()->bar();',
'error_message' => 'NullReference'
],
];
}
}