Fix #5049 - assertion of !empty on bool makes true

src/Psalm/Internal/Type/SimpleNegatedAssertionReconciler.php

@@ -586,6 +586,12 @@ class SimpleNegatedAssertionReconciler extends Reconciler
                 }
             }
 
+            if ($existing_var_type->hasBool()) {
+                $existing_var_type->removeType('bool');
+
+                $existing_var_type->addType(new Type\Atomic\TTrue);
+            }
+
             self::removeFalsyNegatedLiteralTypes(
                 $existing_var_type,
                 $did_remove_type

tests/AssertAnnotationTest.php

@@ -1674,6 +1674,20 @@ class AssertAnnotationTest extends TestCase
                     }',
                 'error_message' => 'InvalidDocblock',
             ],
+            'assertNotEmptyOnBool' => [
+                '<?php
+                    /**
+                     * @param mixed $value
+                     * @psalm-assert !empty $value
+                     */
+                    function assertNotEmpty($value) : void {}
+
+                    function foo(bool $bar) : void {
+                        assertNotEmpty($bar);
+                        if ($bar) {}
+                    }',
+                'error_message' => 'RedundantConditionGivenDocblockType',
+            ],
         ];
     }
 }

tests/TypeReconciliation/ReconcilerTest.php

@@ -132,6 +132,7 @@ class ReconcilerTest extends \Psalm\Tests\TestCase
             'iterableWithParamsToTraversableWithParams' => ['Traversable<int, string>', '!array', 'iterable<int, string>'],
             'iterableAndObject' => ['Traversable<int, string>', 'object', 'iterable<int, string>'],
             'iterableAndNotObject' => ['array<int, string>', '!object', 'iterable<int, string>'],
+            'boolNotEmptyIsTrue' => ['true', '!empty', 'bool'],
         ];
     }