1
0
mirror of https://github.com/danog/psalm.git synced 2024-12-02 17:52:45 +01:00

fix outstanding issues

This commit is contained in:
Andrew Nagy 2023-03-02 18:14:20 +00:00
parent 7e9638b729
commit 0e4b878cbe
2 changed files with 1 additions and 6 deletions

View File

@ -827,7 +827,7 @@ class LanguageServer extends Dispatcher
$issue_baseline[$file][$type]['o']--;
}
} else {
/** @psalm-suppress MixedArrayAssignment, MixedAssignment */
/** @psalm-suppress MixedArrayAssignment */
$issue_baseline[$file][$type]['s'] = [];
$issue_data->severity = Config::REPORT_INFO;
/** @psalm-suppress MixedArrayAssignment, MixedOperand, MixedAssignment */

View File

@ -44,25 +44,20 @@ class FileProvider
return $this->temp_files[$file_path]['content'];
}
/** @psalm-suppress ImpureStaticProperty Used only for caching */
if (isset(self::$open_files[$file_path])) {
return self::$open_files[$file_path];
}
/** @psalm-suppress ImpureFunctionCall For our purposes, this should not mutate external state */
if (!file_exists($file_path)) {
throw new UnexpectedValueException('File ' . $file_path . ' should exist to get contents');
}
/** @psalm-suppress ImpureFunctionCall For our purposes, this should not mutate external state */
if (is_dir($file_path)) {
throw new UnexpectedValueException('File ' . $file_path . ' is a directory');
}
/** @psalm-suppress ImpureFunctionCall For our purposes, this should not mutate external state */
$file_contents = (string) file_get_contents($file_path);
/** @psalm-suppress ImpureStaticProperty Used only for caching */
self::$open_files[$file_path] = $file_contents;
return $file_contents;