danog/psalm
1
0
Fork 0
mirror of https://github.com/danog/psalm.git synced 2024-11-27 04:45:20 +01:00
Code Issues Projects Releases Wiki Activity

Use less obscure method for checking a string against many other strings

Browse Source
This commit is contained in:
rightfold 2018-04-21 22:01:10 +02:00 committed by Matthew Brown
parent e6d9854883
commit 10a90d2270
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/Psalm/Checker/MethodChecker.php
View File

@ -663,6 +663,9 @@ class MethodChecker extends FunctionLikeChecker
}
/**
* Check that __clone, __construct, and __destruct do not have a return type
* hint in their signature.
*
* @param MethodStorage $method_storage
* @param CodeLocation $code_location
* @return false|null
@ -676,10 +679,8 @@ class MethodChecker extends FunctionLikeChecker
}
$cased_method_name = $method_storage->cased_name;
switch ($cased_method_name) {
case '__clone':
case '__construct':
case '__destruct':
$methodsOfInterest = ['__clone', '__construct', '__destruct'];
if (in_array($cased_method_name, $methodsOfInterest)) {
if (IssueBuffer::accepts(
new MethodSignatureMustOmitReturnType(
'Method ' . $cased_method_name . ' must not declare a return type',
@ -688,8 +689,8 @@ class MethodChecker extends FunctionLikeChecker
)) {
return false;
}
}
return null;
}
}
}