danog/psalm
1
0
Fork 0
mirror of https://github.com/danog/psalm.git synced 2025-01-22 05:41:20 +01:00
Code Issues Projects Releases Wiki Activity

Fixup!!! don't allow checks on literals

Browse Source
This commit is contained in:
orklah 2022-01-05 12:41:08 +01:00
parent 411399b600
commit 16bb62b499
1 changed files with 14 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/Psalm/Internal/Type/AssertionReconciler.php
View File

@ -1270,13 +1270,17 @@ class AssertionReconciler extends Reconciler
return new Union([$existing_var_atomic_type]);
}
//here we'll accept any type that *could* possibly be valid on loose equality and return the original type
//here we'll accept non-literal type that *could* match on loose equality and return the original type
if ($is_loose_equality) {
if ($existing_var_atomic_type instanceof TString) {
if ($existing_var_atomic_type instanceof TString
&& !$existing_var_atomic_type instanceof TLiteralString
) {
return $existing_var_type;
}
if ($existing_var_atomic_type instanceof TFloat) {
if ($existing_var_atomic_type instanceof TFloat
&& !$existing_var_atomic_type instanceof TLiteralFloat
) {
return $existing_var_type;
}
}
@ -1413,13 +1417,17 @@ class AssertionReconciler extends Reconciler
return new Union([$existing_var_atomic_type]);
}
//here we'll accept any type that *could* possibly be valid on loose equality and return the original type
//here we'll accept non-literal type that *could* match on loose equality and return the original type
if ($is_loose_equality) {
if ($existing_var_atomic_type instanceof TInt) {
if ($existing_var_atomic_type instanceof TInt
&& !$existing_var_atomic_type instanceof TLiteralInt
) {
return $existing_var_type;
}
if ($existing_var_atomic_type instanceof TFloat) {
if ($existing_var_atomic_type instanceof TFloat
&& !$existing_var_atomic_type instanceof TLiteralFloat
) {
return $existing_var_type;
}
}