From 1efe272aede04fe1a0bc7aeecdca41aade24a29c Mon Sep 17 00:00:00 2001
From: orklah <ronan_morin@hotmail.com>
Date: Tue, 12 Oct 2021 20:13:04 +0200
Subject: [PATCH] stub for is_a

---
 src/Psalm/Internal/Type/TemplateStandinTypeReplacer.php | 2 ++
 stubs/CoreGenericFunctions.phpstub                      | 7 +++++++
 tests/ClassTest.php                                     | 3 ++-
 tests/TraitTest.php                                     | 4 ++--
 4 files changed, 13 insertions(+), 3 deletions(-)

diff --git a/src/Psalm/Internal/Type/TemplateStandinTypeReplacer.php b/src/Psalm/Internal/Type/TemplateStandinTypeReplacer.php
index 5223e1126..253231bda 100644
--- a/src/Psalm/Internal/Type/TemplateStandinTypeReplacer.php
+++ b/src/Psalm/Internal/Type/TemplateStandinTypeReplacer.php
@@ -11,6 +11,7 @@ use Psalm\Type\Union;
 
 use function array_merge;
 use function array_values;
+use function class_exists;
 use function count;
 use function is_a;
 use function reset;
@@ -488,6 +489,7 @@ class TemplateStandinTypeReplacer
                 continue;
             }
 
+            /** @var class-string $key may not always be true but class_exists on built in classes(Iterator) is wrong */
             if (is_a($input_key, $key, true)) {
                 $matching_atomic_types[$atomic_input_type->getId()] = $atomic_input_type;
                 continue;
diff --git a/stubs/CoreGenericFunctions.phpstub b/stubs/CoreGenericFunctions.phpstub
index e893eead1..b7b4ecef4 100644
--- a/stubs/CoreGenericFunctions.phpstub
+++ b/stubs/CoreGenericFunctions.phpstub
@@ -1294,3 +1294,10 @@ function get_meta_tags(string $filename, bool $use_include_path = false) : array
  * @return ($categorize is false ? array<string,int|string|float|bool|null|array|resource> : array<string, array<string,int|string|float|bool|null|array|resource>>)
  */
 function get_defined_constants(bool $categorize = false): array {}
+
+/**
+ * @param mixed $object
+ * @param class-string $class_name
+ * @return ($allow_string is false ? ($object is class-string ? false : bool) : bool)
+ */
+function is_a($object, string $class_name, $allow_string = false): bool{}
\ No newline at end of file
diff --git a/tests/ClassTest.php b/tests/ClassTest.php
index 03d7abc35..227e50c4c 100644
--- a/tests/ClassTest.php
+++ b/tests/ClassTest.php
@@ -189,8 +189,9 @@ class ClassTest extends TestCase
             'returnStringAfterIsACheckWithString' => [
                 '<?php
                     class Foo{}
+                    /** @param class-string $maybeBaz */
                     function bar(string $maybeBaz) : string {
-                      if (!is_a($maybeBaz, "Foo", true)) {
+                      if (!is_a($maybeBaz, Foo::class, true)) {
                         throw new Exception("not Foo");
                       }
                       return $maybeBaz;
diff --git a/tests/TraitTest.php b/tests/TraitTest.php
index 7867a0fc6..ce1b700ff 100644
--- a/tests/TraitTest.php
+++ b/tests/TraitTest.php
@@ -324,7 +324,7 @@ class TraitTest extends TestCase
                 '<?php
                     trait T {
                         public function f(): void {
-                            if (is_a(static::class, "B")) { }
+                            if (is_a(static::class, B::class, true)) { }
                         }
                     }
 
@@ -342,7 +342,7 @@ class TraitTest extends TestCase
                 '<?php
                     trait T {
                         public function f(): void {
-                            if (is_a(static::class, "B")) { }
+                            if (is_a(static::class, B::class, true)) { }
                         }
                     }