From 3cd9658d298bbefa8222dfe41440aa7dffbe7d7f Mon Sep 17 00:00:00 2001
From: Bruce Weirdan <weirdan@gmail.com>
Date: Wed, 21 Feb 2024 12:25:30 +0100
Subject: [PATCH] Allow `Override` attribute to be used in pure contexts

Fixes vimeo/psalm#10731
---
 stubs/CoreGenericAttributes.phpstub |  3 +++
 tests/OverrideTest.php              | 17 +++++++++++++++++
 2 files changed, 20 insertions(+)

diff --git a/stubs/CoreGenericAttributes.phpstub b/stubs/CoreGenericAttributes.phpstub
index 92abe9542..0871e0544 100644
--- a/stubs/CoreGenericAttributes.phpstub
+++ b/stubs/CoreGenericAttributes.phpstub
@@ -1,17 +1,20 @@
 <?php
 
+/** @psalm-immutable */
 #[Attribute(Attribute::TARGET_CLASS)]
 final class AllowDynamicProperties
 {
     public function __construct() {}
 }
 
+/** @psalm-immutable */
 #[Attribute(Attribute::TARGET_METHOD)]
 final class Override
 {
     public function __construct() {}
 }
 
+/** @psalm-immutable */
 #[Attribute(Attribute::TARGET_PARAMETER)]
 final class SensitiveParameter
 {
diff --git a/tests/OverrideTest.php b/tests/OverrideTest.php
index ab808a06d..f46f55cfa 100644
--- a/tests/OverrideTest.php
+++ b/tests/OverrideTest.php
@@ -68,6 +68,23 @@ class OverrideTest extends TestCase
                 'ignored_issues' => [],
                 'php_version' => '8.3',
             ],
+            'canBeUsedOnPureMethods' => [
+                'code' => <<<'PHP'
+                    <?php
+                    class A {
+                        /** @psalm-pure */
+                        public function f(): void {}
+                    }
+                    class B extends A {
+                        /** @psalm-pure */
+                        #[Override]
+                        public function f(): void {}
+                    }
+                    PHP,
+                'assertions' => [],
+                'ignored_issues' => [],
+                'php_version' => '8.3',
+            ],
         ];
     }