danog/psalm
1
0
Fork 0
mirror of https://github.com/danog/psalm.git synced 2024-12-03 18:17:55 +01:00
Code Issues Projects Releases Wiki Activity

Generate properly shaped lists when appending

Browse Source
This commit is contained in:
Daniil Gentili 2022-11-27 20:52:42 +01:00
parent 909edb48e3
commit 2b9512ef50
2 changed files with 20 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/Psalm/Internal/Analyzer/Statements/Expression/Assignment/ArrayAssignmentAnalyzer.php
View File

@ -590,6 +590,11 @@ class ArrayAssignmentAnalyzer
$array_atomic_type_class_string->getStandinKeyParam(), $array_atomic_type_class_string->getStandinKeyParam(),
$array_atomic_type_class_string->value_param $array_atomic_type_class_string->value_param
]); ]);
} elseif ($atomic_root_types['array'] instanceof TKeyedArray
&& $atomic_root_types['array']->is_list
&& $atomic_root_types['array']->fallback_params === null
) {
$array_atomic_type = $atomic_root_types['array'];
} elseif ($atomic_root_types['array'] instanceof TNonEmptyArray } elseif ($atomic_root_types['array'] instanceof TNonEmptyArray
|| ($atomic_root_types['array'] instanceof TKeyedArray || ($atomic_root_types['array'] instanceof TKeyedArray
&& $atomic_root_types['array']->is_list && $atomic_root_types['array']->is_list

15
tests/ArrayAssignmentTest.php
View File

@ -2011,6 +2011,21 @@ class ArrayAssignmentTest extends TestCase
if (\array_key_exists($currentAction, $items)) { if (\array_key_exists($currentAction, $items)) {
$items[$currentAction]["active"] = true; $items[$currentAction]["active"] = true;
}' }'
],
'listAppendShape' => [
'code' => '<?php
$a = [];
$a[]= 0;
$a[]= 1;
$a[]= 2;
$b = [0];
$b[]= 1;
$b[]= 2;',
'assertions' => [
'$a===' => 'list{0, 1, 2}',
'$b===' => 'list{0, 1, 2}'
]
] ]
]; ];
} }