danog/psalm
1
0
Fork 0
mirror of https://github.com/danog/psalm.git synced 2025-01-21 21:31:13 +01:00
Code Issues Projects Releases Wiki Activity

Fix get type return types

Browse Source
This commit is contained in:
Matthew Brown 2018-05-08 22:01:05 -04:00
parent 5c39fb5ab1
commit 2c0dd36035
2 changed files with 29 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/Psalm/Checker/Statements/Expression/Call/MethodCallChecker.php
View File

@ -566,6 +566,10 @@ class MethodCallChecker extends \Psalm\Checker\Statements\Expression\CallChecker
$self_fq_class_name
);
if (isset($stmt->inferredType)) {
$return_type_candidate = $stmt->inferredType;
}
if ($return_type_candidate) {
$return_type_candidate = clone $return_type_candidate;
@ -936,6 +940,11 @@ class MethodCallChecker extends \Psalm\Checker\Statements\Expression\CallChecker
) {
return false;
}
if (isset($class_storage->pseudo_property_get_types['$' . $prop_name])) {
$stmt->inferredType = clone $class_storage->pseudo_property_get_types['$' . $prop_name];
}
break;
}

20
tests/MagicPropertyTest.php
View File

@ -203,6 +203,26 @@ class MagicPropertyTest extends TestCase
}
}',
],
'getPropertyExplicitCall' => [
'<?php
class A {
public function __get(string $name) {}
/**
* @param mixed $value
*/
public function __set(string $name, $value) {}
}
/**
* @property string $test
*/
class B extends A {
public function test(): string {
return $this->__get("test");
}
}',
],
];
}