danog/psalm
1
0
Fork 0
mirror of https://github.com/danog/psalm.git synced 2024-11-30 04:39:00 +01:00
Code Issues Projects Releases Wiki Activity

Add support for static checks

Browse Source
This commit is contained in:
Matthew Brown 2016-01-11 17:18:19 -05:00
parent f547f5e021
commit 2ebca32e32
1 changed files with 23 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
lib/FunctionChecker.php
View File

@ -12,6 +12,7 @@ class FunctionChecker
protected $_aliased_classes = [];
protected $_namespace;
protected $_file_name;
protected $_is_static = false;
protected $_class;
protected $_all_vars = [];
protected $_warn_vars = [];
@ -27,6 +28,7 @@ class FunctionChecker
protected static $_method_files = [];
protected static $_method_params = [];
protected static $_method_param_types = [];
protected static $_static_methods = [];
protected static $_declaring_classes = [];
protected static $_existing_static_vars = [];
@ -45,6 +47,7 @@ class FunctionChecker
if ($function instanceof PhpParser\Node\Stmt\ClassMethod) {
self::_registerMethod($function);
$this->_is_static = $function->isStatic();
}
}
@ -488,6 +491,10 @@ class FunctionChecker
protected function _checkVariable(PhpParser\Node\Expr\Variable $stmt, array &$vars_in_scope, array &$vars_possibly_in_scope, $method_id = null, $argument_offset = -1)
{
if ($stmt->name === 'this' && $this->_is_static) {
throw new CodeException('Invalid reference to $this in a static context', $this->_file_name, $stmt->getLine());
}
if (!$this->_check_variables) {
return;
}
@ -838,6 +845,16 @@ class FunctionChecker
throw new CodeException('Method ' . $method_id . ' does not exist', $this->_file_name, $stmt->getLine());
}
if ($this->_is_static) {
if (!isset(self::$_static_methods[$method_id])) {
self::_extractReflectionMethodInfo($method_id);
}
if (!self::$_static_methods[$method_id]) {
throw new CodeException('Method ' . $method_id . ' is not static', $this->_file_name, $stmt->getLine());
}
}
$return_types = $this->_getMethodReturnTypes($method_id);
if ($return_types) {
@ -1003,6 +1020,11 @@ class FunctionChecker
else if ($method->parts === ['defined']) {
$this->_check_consts = false;
}
else if ($method->parts === ['var_dump'] || $method->parts === ['die'] || $method->parts === ['exit']) {
if (FileChecker::shouldCheckVarDumps($this->_file_name)) {
throw new CodeException('Unsafe ' . implode('', $method->parts), $this->_file_name, $stmt->getLine());
}
}
}
foreach ($stmt->args as $i => $arg) {
@ -1296,6 +1318,7 @@ class FunctionChecker
self::$_method_param_types[$method_id][] = $param->getClass() ? '\\' . $param->getClass()->getName() : ($param->isArray() ? 'array' : null);
}
self::$_static_methods[$method_id] = $method->isStatic();
self::$_method_comments[$method_id] = $method->getDocComment() ?: '';
self::$_method_files[$method_id] = $method->getFileName();
self::$_declaring_classes[$method_id] = '\\' . $method->getDeclaringClass()->name;