danog/psalm
1
0
Fork 0
mirror of https://github.com/danog/psalm.git synced 2024-11-27 04:45:20 +01:00
Code Issues Projects Releases Wiki Activity

Make name property of enum cases return non-empty-strings (vimeo/psalm#6964)

Browse Source
This commit is contained in:
Ricardo Boss 2021-12-06 00:33:57 +01:00
parent 056497e73d
commit 2ec77fe29c
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Psalm/Internal/Analyzer/Statements/Expression/Fetch/AtomicPropertyFetchAnalyzer.php
View File

@ -202,7 +202,7 @@ class AtomicPropertyFetchAnalyzer
new Type\Union([new Type\Atomic\TLiteralString($lhs_type_part->case_name)])
);
} else {
$statements_analyzer->node_data->setType($stmt, Type::getString());
$statements_analyzer->node_data->setType($stmt, Type::getNonEmptyString());
}
} else {
self::handleNonExistentProperty(

3
tests/EnumTest.php
View File

@ -126,6 +126,9 @@ class EnumTest extends TestCase
case PUBLISHED;
case ARCHIVED;
/**
* @return non-empty-string
*/
public function get(): string
{
return $this->name;