danog/psalm
1
0
Fork 0
mirror of https://github.com/danog/psalm.git synced 2025-01-22 05:41:20 +01:00
Code Issues Projects Releases Wiki Activity

Detect trying to access to a list with a negative offset (#4552)

Browse Source
This commit is contained in:
orklah 2020-11-16 02:26:50 +01:00 committed by Daniil Gentili
parent 8b56e5eede
commit 2f368244a4
Signed by: danog
GPG Key ID: 8C1BE3B34B230CA7
2 changed files with 22 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/Psalm/Internal/Analyzer/Statements/Expression/Fetch/ArrayFetchAnalyzer.php
View File

@ -797,9 +797,16 @@ class ArrayFetchAnalyzer
$statements_analyzer
);
}
$has_valid_offset = true;
} elseif (count($key_values) === 1
&& is_int($key_values[0])
&& $key_values[0] < 0
) {
$expected_offset_types[] = Type::getPositiveInt();
$has_valid_offset = false;
} else {
$has_valid_offset = true;
}
$has_valid_offset = true;
}
if ($in_assignment && $type instanceof Type\Atomic\TNonEmptyList && $type->count !== null) {

13
tests/ArrayAccessTest.php
View File

@ -1270,6 +1270,19 @@ class ArrayAccessTest extends TestCase
[$width, $height, $depth] = size();',
'error_message' => 'InvalidArrayOffset',
],
'negativeListAccess' => [
'<?php
class HelloWorld
{
public function sayHello(): void
{
$a = explode("/", "a/b/c");
$x = $a[-3];
echo $x;
}
}',
'error_message' => 'InvalidArrayOffset'
]
];
}
}