danog/psalm
1
0
Fork 0
mirror of https://github.com/danog/psalm.git synced 2024-11-26 12:24:49 +01:00
Code Issues Projects Releases Wiki Activity

Fix #8923

Browse Source
This commit is contained in:
Daniil Gentili 2022-12-18 18:19:22 +01:00
parent 7d95f15e30
commit 2f5d0a4a9f
4 changed files with 26 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/Psalm/Internal/Analyzer/ScopeAnalyzer.php
View File

@ -265,7 +265,8 @@ class ScopeAnalyzer
static fn(string $action): bool => $action !== self::ACTION_NONE
);
if ($stmt instanceof PhpParser\Node\Stmt\While_
if (($stmt instanceof PhpParser\Node\Stmt\While_
|| $stmt instanceof PhpParser\Node\Stmt\Do_)
&& $nodes
&& ($stmt_expr_type = $nodes->getType($stmt->cond))
&& $stmt_expr_type->isAlwaysTruthy()

8
tests/Loop/DoTest.php
View File

@ -16,6 +16,14 @@ class DoTest extends TestCase
public function providerValidCodeParse(): iterable
{
return [
'doWhileTrue' => [
'code' => '<?php
function ret(): int {
do {
return 1;
} while (true);
}'
],
'doWhileVar' => [
'code' => '<?php
$worked = false;

8
tests/Loop/ForTest.php
View File

@ -16,6 +16,14 @@ class ForTest extends TestCase
public function providerValidCodeParse(): iterable
{
return [
'forTrue' => [
'code' => '<?php
function ret(): int {
for (;;) {
return 1;
}
}'
],
'implicitFourthLoop' => [
'code' => '<?php
function test(): int {

8
tests/Loop/WhileTest.php
View File

@ -14,6 +14,14 @@ class WhileTest extends TestCase
public function providerValidCodeParse(): iterable
{
return [
'whileTrue' => [
'code' => '<?php
function ret(): int {
do {
return 1;
} while (true);
}'
],
'whileVar' => [
'code' => '<?php
$worked = false;