danog/psalm
1
0
Fork 0
mirror of https://github.com/danog/psalm.git synced 2024-11-27 04:45:20 +01:00
Code Issues Projects Releases Wiki Activity

Add a little caching

Browse Source
This commit is contained in:
Matthew Brown 2016-05-16 18:10:59 -04:00
parent 2ed9d2bff7
commit 333caeaeaa
2 changed files with 24 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/CodeInspector/ClassChecker.php
View File

@ -337,8 +337,10 @@ class ClassChecker implements StatementsSource
$reflection_methods = $reflection_class->getMethods(ReflectionMethod::IS_PUBLIC | ReflectionMethod::IS_PROTECTED);
foreach ($reflection_methods as $reflection_method) {
$method_name = $reflection_method->getName();
$class_methods[] = $method_name;
if (!$reflection_method->isAbstract()) {
$method_name = $reflection_method->getName();
$class_methods[] = $method_name;
}
}
self::$_class_methods[$parent_class] = $class_methods;

21
src/CodeInspector/FunctionChecker.php
View File

@ -19,6 +19,8 @@ class FunctionChecker implements StatementsSource
protected $_return_vars_in_scope = [];
protected $_return_vars_possibly_in_scope = [];
protected static $_no_effects_hashes = [];
protected $_function_params = [];
public function __construct(PhpParser\Node\FunctionLike $function, StatementsSource $source)
@ -36,6 +38,15 @@ class FunctionChecker implements StatementsSource
public function check(&$vars_in_scope = [], &$vars_possibly_in_scope = [])
{
if ($this->_function->stmts) {
if (ClassChecker::getThisClass() && $this instanceof ClassMethodChecker) {
$hash = md5($this->getMethodId() . json_encode($vars_in_scope) . ' ' . json_encode($vars_possibly_in_scope));
// if we know that the function has no effects on vars, we don't bother checking
if (isset(self::$_no_effects_hashes[$hash])) {
return;
}
}
$statements_checker = new StatementsChecker($this, !empty($this->_function->params));
foreach ($this->_function->params as $param) {
@ -86,11 +97,19 @@ class FunctionChecker implements StatementsSource
}
}
foreach ($vars_in_scope as $var => $type) {
foreach ($vars_possibly_in_scope as $var => $type) {
if (strpos($var, 'this->') !== 0) {
unset($vars_possibly_in_scope[$var]);
}
}
if (ClassChecker::getThisClass() && $this instanceof ClassMethodChecker) {
$new_hash = md5($this->getMethodId() . json_encode($vars_in_scope) . ' ' . json_encode($vars_possibly_in_scope));
if ($hash === $new_hash) {
self::$_no_effects_hashes[$hash] = true;
}
}
}
}