danog/psalm
1
0
Fork 0
mirror of https://github.com/danog/psalm.git synced 2025-01-22 13:51:54 +01:00
Code Issues Projects Releases Wiki Activity

Merge pull request #9312 from weirdan/deprecate-functionlikestorage-unused_docblock_params

Browse Source
This commit is contained in:
Bruce Weirdan 2023-02-15 21:46:39 -04:00 committed by GitHub
commit 33f18e8d2d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 15 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/Psalm/Internal/Analyzer/FunctionLikeAnalyzer.php
View File

@ -361,8 +361,8 @@ abstract class FunctionLikeAnalyzer extends SourceAnalyzer
$context->external_mutation_free = true;
}
if ($storage->unused_docblock_params) {
foreach ($storage->unused_docblock_params as $param_name => $param_location) {
if ($storage->has_undertyped_native_parameters) {
foreach ($storage->unused_docblock_parameters as $param_name => $param_location) {
IssueBuffer::maybeAdd(
new InvalidDocblockParamName(
'Incorrect param name $' . $param_name . ' in docblock for ' . $cased_method_id,

4
src/Psalm/Internal/PhpVisitor/Reflector/FunctionLikeDocblockScanner.php
View File

@ -908,8 +908,12 @@ class FunctionLikeDocblockScanner
);
if ($params_without_docblock_type) {
/** @psalm-suppress DeprecatedProperty remove in Psalm 6 */
$storage->unused_docblock_params = $unused_docblock_params;
}
$storage->has_undertyped_native_parameters = $params_without_docblock_type !== [];
$storage->unused_docblock_parameters = $unused_docblock_params;
}
/**

9
src/Psalm/Storage/FunctionLikeStorage.php
View File

@ -172,10 +172,19 @@ abstract class FunctionLikeStorage implements HasAttributesInterface
public $return_type_description;
/**
* @psalm-suppress PossiblyUnusedProperty
* @var array<string, CodeLocation>|null
* @deprecated will be removed in Psalm 6. use {@see FunctionLikeStorage::$unused_docblock_parameters} instead
*/
public $unused_docblock_params;
/**
* @var array<string, CodeLocation>
*/
public array $unused_docblock_parameters = [];
public bool $has_undertyped_native_parameters = false;
/**
* @var bool
*/