danog/psalm
1
0
Fork 0
mirror of https://github.com/danog/psalm.git synced 2024-11-26 20:34:47 +01:00
Code Issues Projects Releases Wiki Activity

Fix #3870 - mark properties as reference-free only for externally-immutable classes

Browse Source
This commit is contained in:
Brown 2020-07-23 01:48:06 -04:00
parent 3bc91b9944
commit 3848fa6872
2 changed files with 27 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/Psalm/Internal/Analyzer/FunctionLikeAnalyzer.php
View File

@ -216,9 +216,7 @@ abstract class FunctionLikeAnalyzer extends SourceAnalyzer
$context->vars_in_scope['$this'] = new Type\Union([$this_object_type]);
if ($storage->external_mutation_free
&& !$storage->mutation_free_inferred
) {
if ($appearing_class_storage->external_mutation_free) {
$context->vars_in_scope['$this']->reference_free = true;
if ($this->function->name->name !== '__construct') {

26
tests/ImmutableAnnotationTest.php
View File

@ -699,6 +699,32 @@ class ImmutableAnnotationTest extends TestCase
}',
'error_message' => 'ImpurePropertyAssignment',
],
'mutationInPropertyAssignment' => [
'<?php
class D {
private string $s;
public function __construct(string $s) {
$this->s = $s;
}
/**
* @psalm-mutation-free
*/
public function getShort() : string {
return substr($this->s, 0, 5);
}
/**
* @psalm-mutation-free
*/
public function getShortMutating() : string {
$this->s .= "hello";
return substr($this->s, 0, 5);
}
}',
'error_message' => 'ImpurePropertyAssignment',
],
];
}
}