danog/psalm
1
0
Fork 0
mirror of https://github.com/danog/psalm.git synced 2024-11-30 04:39:00 +01:00
Code Issues Projects Releases Wiki Activity

remove preg, minor performance gain (up to 1%)

Browse Source
This commit is contained in:
kkmuffme 2023-06-13 20:29:20 +02:00
parent 49c6f31071
commit 394a40b0f7
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/Psalm/Internal/Scanner/DocblockParser.php
View File

@ -122,13 +122,20 @@ class DocblockParser
// Smush the whole docblock to the left edge.
$min_indent = 80;
$reached_first_non_empty_line = false;
foreach ($lines as $k => $line) {
$indent = strspn($line, ' ');
if ($indent === strlen($line)) {
// This line consists of only spaces. Trim it completely.
if ($reached_first_non_empty_line === false) {
// remove any leading empty lines here, to avoid a preg_replace later
unset($lines[$k]);
continue;
}
$lines[$k] = '';
continue;
}
$reached_first_non_empty_line = true;
$min_indent = min($indent, $min_indent);
}
if ($min_indent > 0) {
@ -142,10 +149,6 @@ class DocblockParser
$docblock = implode("\n", $lines);
$docblock = rtrim($docblock);
// Trim any empty lines off the front, but leave the indent level if there
// is one.
$docblock = preg_replace('/^\s*\n/', '', $docblock, 1);
$parsed = new ParsedDocblock($docblock, $special, $first_line_padding ?: '');
self::resolveTags($parsed);