danog/psalm
1
0
Fork 0
mirror of https://github.com/danog/psalm.git synced 2024-11-26 20:34:47 +01:00
Code Issues Projects Releases Wiki Activity

Fix #5108 - prevent crash on 0 type

Browse Source
This commit is contained in:
Matt Brown 2021-01-26 14:06:43 -05:00 committed by Daniil Gentili
parent 5da816f160
commit 4627065d1f
Signed by: danog
GPG Key ID: 8C1BE3B34B230CA7
2 changed files with 20 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/Psalm/Internal/Codebase/Analyzer.php
View File

@ -1144,7 +1144,7 @@ class Analyzer
string $node_type, string $node_type,
PhpParser\Node $parent_node = null PhpParser\Node $parent_node = null
): void { ): void {
if (!$node_type) { if ($node_type === '') {
throw new \UnexpectedValueException('non-empty node_type expected'); throw new \UnexpectedValueException('non-empty node_type expected');
} }
@ -1161,8 +1161,8 @@ class Analyzer
string $reference, string $reference,
int $argument_number int $argument_number
): void { ): void {
if (!$reference) { if ($reference === '') {
throw new \UnexpectedValueException('non-empty node_type expected'); throw new \UnexpectedValueException('non-empty reference expected');
} }
$this->argument_map[$file_path][$start_position] = [ $this->argument_map[$file_path][$start_position] = [

17
tests/LanguageServer/CompletionTest.php
View File

@ -798,4 +798,21 @@ class CompletionTest extends \Psalm\Tests\TestCase
$completion_items = $codebase->getCompletionItemsForClassishThing($completion_data[0], $completion_data[1]); $completion_items = $codebase->getCompletionItemsForClassishThing($completion_data[0], $completion_data[1]);
$this->assertCount(2, $completion_items); $this->assertCount(2, $completion_items);
} }
public function testNoCrashOnLoopId(): void
{
$codebase = $this->project_analyzer->getCodebase();
$config = $codebase->config;
$config->throw_exception = false;
$this->addFile(
'somefile.php',
'<?php
for ($x = 0; $x <= 10; $x++) {}'
);
$codebase->file_provider->openFile('somefile.php');
$codebase->scanFiles();
$this->analyzeFile('somefile.php', new Context());
}
} }