danog/psalm
1
0
Fork 0
mirror of https://github.com/danog/psalm.git synced 2025-01-22 05:41:20 +01:00
Code Issues Projects Releases Wiki Activity

Fix issue when reconciling is_subclass_of on possibly-undefined variable

Browse Source
This commit is contained in:
Matthew Brown 2019-05-03 09:09:51 -04:00
parent db227dab06
commit 49acdfc764
2 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/Psalm/Type/Reconciler.php
View File

@ -365,7 +365,11 @@ class Reconciler
}
}
return Type::parseString($new_var_type, null, $template_type_map);
try {
return Type::parseString($new_var_type, null, $template_type_map);
} catch (\Exception $e) {
return Type::getMixed();
}
}
return Type::getMixed();

12
tests/ClassStringTest.php
View File

@ -557,6 +557,18 @@ class ClassStringTest extends TestCase
return array_merge($generic_classes, $literal_classes);
}',
],
'noCrashWithIsSubclassOfNonExistentVariable' => [
'<?php
class A {}
function foo() : void {
/**
* @psalm-suppress UndefinedVariable
* @psalm-suppress MixedArgument
*/
if (!is_subclass_of($s, A::class)) {}
}',
],
];
}