Simplify ArrayFetchAnalyzer::getArrayAccessTypeGivenOffset

Ref #4714

src/Psalm/Internal/Analyzer/Statements/Block/IfElse/IfAnalyzer.php

@@ -100,7 +100,9 @@ class IfAnalyzer
             ) {
                 if (IssueBuffer::accepts(
                     new ConflictingReferenceConstraint(
-                        'There is more than one pass-by-reference constraint on ' . $var_id,
+                        'There is more than one pass-by-reference constraint on ' . $var_id
+                            . ' between ' . $byref_constraint->type->getId()
+                            . ' and ' . $outer_constraint_type->getId(),
                         new CodeLocation($statements_analyzer, $stmt, $outer_context->include_location, true)
                     ),
                     $statements_analyzer->getSuppressedIssues()

src/Psalm/Internal/Analyzer/Statements/Block/LoopAnalyzer.php

@@ -320,6 +320,7 @@ class LoopAnalyzer
                 }
 
                 $inner_context->clauses = $pre_loop_context->clauses;
+                $inner_context->byref_constraints = $pre_loop_context->byref_constraints;
 
                 $analyzer->setMixedCountsForFile($statements_analyzer->getFilePath(), $original_mixed_counts);
                 IssueBuffer::startRecording();