danog/psalm
1
0
Fork 0
mirror of https://github.com/danog/psalm.git synced 2024-11-30 04:39:00 +01:00
Code Issues Projects Releases Wiki Activity

Don’t memoize method call where we have a getter standin

Browse Source 
Fixes #3427
This commit is contained in:
Brown 2020-05-22 15:54:12 -04:00
parent 4010129e96
commit 4b1c3db760
2 changed files with 49 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Psalm/Internal/Analyzer/Statements/Expression/Call/Method/AtomicMethodCallAnalyzer.php
View File

@ -758,7 +758,7 @@ class AtomicMethodCallAnalyzer extends CallAnalyzer
}
if (!$args && $lhs_var_id) {
if ($config->memoize_method_calls || $can_memoize) {
if (($config->memoize_method_calls || $can_memoize) && !$plain_getter_property) {
$method_var_id = $lhs_var_id . '->' . $method_name_lc . '()';
if (isset($context->vars_in_scope[$method_var_id])) {

48
tests/Config/ConfigTest.php
View File

@ -727,6 +727,54 @@ class ConfigTest extends \Psalm\Tests\TestCase
$this->analyzeFile($file_path, new Context());
}
/**
* @return void
*/
public function testUnchainedMethodCallMemoize()
{
$this->project_analyzer = $this->getProjectAnalyzerWithConfig(
TestConfig::loadFromXML(
dirname(__DIR__, 2),
'<?xml version="1.0"?>
<psalm memoizeMethodCallResults="true">
<projectFiles>
<directory name="src" />
</projectFiles>
</psalm>'
)
);
$file_path = getcwd() . '/src/somefile.php';
$this->addFile(
$file_path,
'<?php
class SomeClass {
private ?int $int;
public function __construct() {
$this->int = 1;
}
public function getInt(): ?int {
return $this->int;
}
}
function printInt(int $int): void {
echo $int;
}
$obj = new SomeClass();
if ($obj->getInt()) {
printInt($obj->getInt());
}'
);
$this->analyzeFile($file_path, new Context());
}
/**
* @return void
*/