danog/psalm
1
0
Fork 0
mirror of https://github.com/danog/psalm.git synced 2025-01-22 05:41:20 +01:00
Code Issues Projects Releases Wiki Activity

Fix #3721 - prevent crash on empty @method

Browse Source
This commit is contained in:
Brown 2020-07-01 09:00:33 -04:00
parent cceacde01d
commit 4c368da75e
2 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/Psalm/Internal/Analyzer/CommentAnalyzer.php
View File

@ -1023,6 +1023,10 @@ class CommentAnalyzer
// replace array bracket contents // replace array bracket contents
$method_entry = preg_replace('/\[([0-9a-zA-Z_\'\" ]+,)*([0-9a-zA-Z_\'\" ]+)\]/', '[]', $method_entry); $method_entry = preg_replace('/\[([0-9a-zA-Z_\'\" ]+,)*([0-9a-zA-Z_\'\" ]+)\]/', '[]', $method_entry);
if (!$method_entry) {
throw new DocblockParseException('No @method entry specified');
}
try { try {
$parse_tree_creator = new ParseTreeCreator( $parse_tree_creator = new ParseTreeCreator(
TypeTokenizer::getFullyQualifiedTokens( TypeTokenizer::getFullyQualifiedTokens(

8
tests/MagicMethodAnnotationTest.php
View File

@ -838,6 +838,14 @@ class MagicMethodAnnotationTest extends TestCase
$b->foo();', $b->foo();',
'error_message' => 'UndefinedMagicMethod', 'error_message' => 'UndefinedMagicMethod',
], ],
'lonelyMethod' => [
'<?php
/**
* @method
*/
class C {}',
'error_message' => 'InvalidDocblock',
],
]; ];
} }