danog/psalm
1
0
Fork 0
mirror of https://github.com/danog/psalm.git synced 2025-01-22 13:51:54 +01:00
Code Issues Projects Releases Wiki Activity

Merge pull request #7279 from weirdan/trim-existing-issue-selections

Browse Source
This commit is contained in:
Bruce Weirdan 2022-01-03 20:42:04 +02:00 committed by GitHub
commit 4c8474573b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/Psalm/ErrorBaseline.php
View File

@ -282,12 +282,7 @@ class ErrorBaseline
foreach ($existingIssueType['s'] as $selection) { foreach ($existingIssueType['s'] as $selection) {
$codeNode = $baselineDoc->createElement('code'); $codeNode = $baselineDoc->createElement('code');
$codeNode->textContent = trim($selection);
/** @todo in major version release (e.g. Psalm 5) replace $selection with trim($selection)
* This will be a minor BC break as baselines generated will then not be compatible with Psalm
* versions from before PR https://github.com/vimeo/psalm/pull/6000
*/
$codeNode->textContent = $selection;
$issueNode->appendChild($codeNode); $issueNode->appendChild($codeNode);
} }
$fileNode->appendChild($issueNode); $fileNode->appendChild($issueNode);