Fix #1793 - warn on deprecated function

assets/config_levels/3.xml

@@ -21,6 +21,7 @@
         <DeprecatedProperty errorLevel="info" />
         <DeprecatedClass errorLevel="info" />
         <DeprecatedConstant errorLevel="info" />
+        <DeprecatedFunction errorLevel="info" />
         <DeprecatedInterface errorLevel="info" />
         <DeprecatedTrait errorLevel="info" />
 

assets/config_levels/4.xml

@@ -21,6 +21,7 @@
         <DeprecatedProperty errorLevel="info" />
         <DeprecatedClass errorLevel="info" />
         <DeprecatedConstant errorLevel="info" />
+        <DeprecatedFunction errorLevel="info" />
         <DeprecatedInterface errorLevel="info" />
         <DeprecatedTrait errorLevel="info" />
 

assets/config_levels/5.xml

@@ -21,6 +21,7 @@
         <DeprecatedProperty errorLevel="info" />
         <DeprecatedClass errorLevel="info" />
         <DeprecatedConstant errorLevel="info" />
+        <DeprecatedFunction errorLevel="info" />
         <DeprecatedInterface errorLevel="info" />
         <DeprecatedTrait errorLevel="info" />
 

assets/config_levels/6.xml

@@ -21,6 +21,7 @@
         <DeprecatedProperty errorLevel="info" />
         <DeprecatedClass errorLevel="info" />
         <DeprecatedConstant errorLevel="info" />
+        <DeprecatedFunction errorLevel="info" />
         <DeprecatedInterface errorLevel="info" />
         <DeprecatedTrait errorLevel="info" />
 

assets/config_levels/7.xml

@@ -21,6 +21,7 @@
         <DeprecatedProperty errorLevel="info" />
         <DeprecatedClass errorLevel="info" />
         <DeprecatedConstant errorLevel="info" />
+        <DeprecatedFunction errorLevel="info" />
         <DeprecatedInterface errorLevel="info" />
         <DeprecatedTrait errorLevel="info" />
 

assets/config_levels/8.xml

@@ -21,6 +21,7 @@
         <DeprecatedProperty errorLevel="info" />
         <DeprecatedClass errorLevel="info" />
         <DeprecatedConstant errorLevel="info" />
+        <DeprecatedFunction errorLevel="info" />
         <DeprecatedInterface errorLevel="info" />
         <DeprecatedTrait errorLevel="info" />
 

config.xsd

@@ -147,6 +147,7 @@
             <xs:element name="ConflictingReferenceConstraint" type="IssueHandlerType" minOccurs="0" />
             <xs:element name="DeprecatedClass" type="ClassIssueHandlerType" minOccurs="0" />
             <xs:element name="DeprecatedConstant" type="IssueHandlerType" minOccurs="0" />
+            <xs:element name="DeprecatedFunction" type="FunctionIssueHandlerType" minOccurs="0" />
             <xs:element name="DeprecatedInterface" type="ClassIssueHandlerType" minOccurs="0" />
             <xs:element name="DeprecatedMethod" type="MethodIssueHandlerType" minOccurs="0" />
             <xs:element name="DeprecatedProperty" type="PropertyIssueHandlerType" minOccurs="0" />

docs/running_psalm/issues.md

@@ -107,6 +107,16 @@ class A {
 echo A::FOO;
 ```
 
+### DeprecatedFunction
+
+Emitted when calling a deprecated function:
+
+```php
+/** @deprecated */
+function foo() : void {}
+foo();
+```
+
 ### DeprecatedInterface
 
 Emitted when referring to a deprecated interface

src/Psalm/Internal/Analyzer/Statements/Expression/Call/FunctionCallAnalyzer.php

@@ -11,6 +11,7 @@ use Psalm\Internal\Codebase\CallMap;
 use Psalm\CodeLocation;
 use Psalm\Context;
 use Psalm\Internal\FileManipulation\FileManipulationBuffer;
+use Psalm\Issue\DeprecatedFunction;
 use Psalm\Issue\ForbiddenCode;
 use Psalm\Issue\MixedFunctionCall;
 use Psalm\Issue\InvalidFunctionCall;
@@ -598,6 +599,19 @@ class FunctionCallAnalyzer extends \Psalm\Internal\Analyzer\Statements\Expressio
                     $function_storage->if_false_assertions
                 );
             }
+
+            if ($function_storage->deprecated && $function_id) {
+                if (IssueBuffer::accepts(
+                    new DeprecatedFunction(
+                        'The function ' . $function_id . ' has been marked as deprecated',
+                        $code_location,
+                        $function_id
+                    ),
+                    $statements_analyzer->getSuppressedIssues()
+                )) {
+                    // continue
+                }
+            }
         }
 
         if ($function instanceof PhpParser\Node\Name) {

src/Psalm/Issue/DeprecatedFunction.php

@@ -0,0 +1,6 @@
+<?php
+namespace Psalm\Issue;
+
+class DeprecatedFunction extends FunctionIssue
+{
+}