danog/psalm
1
0
Fork 0
mirror of https://github.com/danog/psalm.git synced 2024-12-02 09:37:59 +01:00
Code Issues Projects Releases Wiki Activity

Kill all children before throwing

Browse Source
This commit is contained in:
Daniil Gentili 2024-04-11 20:27:08 +02:00
parent e93ecbe1d0
commit 683f63b7f7
1 changed files with 18 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
src/Psalm/Internal/Fork/Pool.php
View File

@ -295,6 +295,20 @@ final class Pool
return $for_write; return $for_write;
} }
private function killAllChildren(): void
{
foreach ($this->child_pid_list as $child_pid) {
/**
* SIGTERM does not exist on windows
*
* @psalm-suppress UnusedPsalmSuppress
* @psalm-suppress UndefinedConstant
* @psalm-suppress MixedArgument
*/
posix_kill($child_pid, SIGTERM);
}
}
/** /**
* Read the results that each child process has serialized on their write streams. * Read the results that each child process has serialized on their write streams.
* The results are returned in an array, one for each worker. The order of the results * The results are returned in an array, one for each worker. The order of the results
@ -364,19 +378,10 @@ final class Pool
($this->task_done_closure)($message->data); ($this->task_done_closure)($message->data);
} }
} elseif ($message instanceof ForkProcessErrorMessage) { } elseif ($message instanceof ForkProcessErrorMessage) {
// Kill all children $this->killAllChildren();
foreach ($this->child_pid_list as $child_pid) {
/**
* SIGTERM does not exist on windows
*
* @psalm-suppress UnusedPsalmSuppress
* @psalm-suppress UndefinedConstant
* @psalm-suppress MixedArgument
*/
posix_kill($child_pid, SIGTERM);
}
throw new Exception($message->message); throw new Exception($message->message);
} else { } else {
$this->killAllChildren();
throw new Exception('Child should return ForkMessage - response type=' . gettype($message)); throw new Exception('Child should return ForkMessage - response type=' . gettype($message));
} }
} }
@ -385,6 +390,7 @@ final class Pool
// If the stream has closed, stop trying to select on it. // If the stream has closed, stop trying to select on it.
if (feof($file)) { if (feof($file)) {
if ($content[(int)$file] !== '' || !isset($done[(int)$file])) { if ($content[(int)$file] !== '' || !isset($done[(int)$file])) {
$this->killAllChildren();
throw new Exception('Child did not send full message before closing the connection'); throw new Exception('Child did not send full message before closing the connection');
} }
@ -447,6 +453,7 @@ final class Pool
* @psalm-suppress UndefinedConstant * @psalm-suppress UndefinedConstant
*/ */
if ($term_sig !== SIGALRM) { if ($term_sig !== SIGALRM) {
$this->killAllChildren();
throw new Exception("Child terminated with return code $return_code and signal $term_sig"); throw new Exception("Child terminated with return code $return_code and signal $term_sig");
} }
} }