danog/psalm
1
0
Fork 0
mirror of https://github.com/danog/psalm.git synced 2025-01-22 22:01:48 +01:00
Code Issues Projects Releases Wiki Activity

Nest new impure checks

Browse Source
This commit is contained in:
Matthew Brown 2020-08-23 13:39:08 -04:00 committed by Daniil Gentili
parent 601a8fdcb6
commit 68b97591d9
Signed by: danog
GPG Key ID: 8C1BE3B34B230CA7
1 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/Psalm/Internal/Analyzer/Statements/Expression/Call/NewAnalyzer.php
View File

@ -546,15 +546,15 @@ class NewAnalyzer extends \Psalm\Internal\Analyzer\Statements\Expression\CallAna
return false;
}
if ($context->pure) {
$declaring_method_id = $codebase->methods->getDeclaringMethodId($method_id);
$declaring_method_id = $codebase->methods->getDeclaringMethodId($method_id);
if ($declaring_method_id) {
$method_storage = $codebase->methods->getStorage($declaring_method_id);
if ($declaring_method_id) {
$method_storage = $codebase->methods->getStorage($declaring_method_id);
$project_analyzer = $statements_analyzer->getProjectAnalyzer();
$project_analyzer = $statements_analyzer->getProjectAnalyzer();
if (!$method_storage->external_mutation_free && !$context->inside_throw) {
if (!$method_storage->external_mutation_free && !$context->inside_throw) {
if ($context->pure) {
if (IssueBuffer::accepts(
new ImpureMethodCall(
'Cannot call an impure constructor from a pure context',
@ -577,8 +577,6 @@ class NewAnalyzer extends \Psalm\Internal\Analyzer\Statements\Expression\CallAna
$generic_param_types = null;
if ($storage->template_types) {
$declaring_method_id = $codebase->methods->getDeclaringMethodId($method_id);
$declaring_fq_class_name = $declaring_method_id
? $declaring_method_id->fq_class_name
: $fq_class_name;