danog/psalm
1
0
Fork 0
mirror of https://github.com/danog/psalm.git synced 2024-11-30 04:39:00 +01:00
Code Issues Projects Releases Wiki Activity

Regression and fail tests

Browse Source 
List fail tests:

```
1) testMethodAnnotation with data set "static (string|int)[] getArray()"
Undefined array key 0

/workspaces/psalm/tests/ClassLikeDocblockParserTest.php:201

2) testMethodAnnotation with data set "static (callable() : string) getCallable()"
Undefined array key 0

/workspaces/psalm/tests/ClassLikeDocblockParserTest.php:201
```
This commit is contained in:
Ivan Sidorov 2024-02-06 15:20:02 +00:00
parent 508da9abd4
commit 6b3380b05f
1 changed files with 184 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

184
tests/ClassLikeDocblockParserTest.php
View File

@ -7,6 +7,8 @@ use PhpParser\Node\Stmt\Class_;
use Psalm\Aliases;
use Psalm\Internal\PhpVisitor\Reflector\ClassLikeDocblockParser;
use function array_values;
class ClassLikeDocblockParserTest extends TestCase
{
public function testDocblockDescription(): void
@ -35,4 +37,186 @@ class ClassLikeDocblockParserTest extends TestCase
$class_docblock = ClassLikeDocblockParser::parse($node, $php_parser_doc, new Aliases());
$this->assertSame([['T', 'of', 'string', true, 33]], $class_docblock->templates);
}
/**
* @return iterable<array-key, array{annotation: string, expected: array}>
*/
public function providerMethodAnnotation(): iterable
{
$data = [
'foo()' => [
'name' => 'foo',
'returnType' => '',
'is_static' => false,
'params' => [],
],
'foo($a)' => [
'name' => 'foo',
'returnType' => '',
'is_static' => false,
'params' => [
'a' => ['type' => ''],
],
],
'string foo()' => [
'name' => 'foo',
'returnType' => 'string',
'is_static' => false,
'params' => [],
],
'static string foo()' => [
'name' => 'foo',
'returnType' => 'string',
'is_static' => true,
'params' => [],
],
'string foo(string $a, int $b)' => [
'name' => 'foo',
'returnType' => 'string',
'is_static' => false,
'params' => [
'a' => ['type' => 'string'],
'b' => ['type' => 'int'],
],
],
'static string foo(string $a, int $b)' => [
'name' => 'foo',
'returnType' => 'string',
'is_static' => true,
'params' => [
'a' => ['type' => 'string'],
'b' => ['type' => 'int'],
],
],
'static foo()' => [
'name' => 'foo',
'returnType' => 'static',
'is_static' => false,
'params' => [],
],
'static static foo()' => [
'name' => 'foo',
'returnType' => 'static',
'is_static' => true,
'params' => [],
],
'static foo(string $z)' => [
'name' => 'foo',
'returnType' => 'static',
'is_static' => false,
'params' => [
'z' => ['type' => 'string'],
],
],
'static static foo(string $z)' => [
'name' => 'foo',
'returnType' => 'static',
'is_static' => true,
'params' => [
'z' => ['type' => 'string'],
],
],
'self foo()' => [
'name' => 'foo',
'returnType' => 'MyClass',
'is_static' => false,
'params' => [],
],
'static self foo()' => [
'name' => 'foo',
'returnType' => 'MyClass',
'is_static' => true,
'params' => [],
],
'self foo(string $z)' => [
'name' => 'foo',
'returnType' => 'MyClass',
'is_static' => false,
'params' => [
'z' => ['type' => 'string'],
],
],
'static self foo(string $z)' => [
'name' => 'foo',
'returnType' => 'MyClass',
'is_static' => true,
'params' => [
'z' => ['type' => 'string'],
],
],
'(string|int)[] getArray()' => [
'name' => 'getArray',
'returnType' => 'array<array-key, int|string>',
'is_static' => false,
'params' => [],
],
'static (string|int)[] getArray()' => [
'name' => 'getArray',
'returnType' => 'array<array-key, int|string>',
'is_static' => true,
'params' => [],
],
'(callable() : string) getCallable()' => [
'name' => 'getCallable',
'returnType' => 'callable():string',
'is_static' => false,
'params' => [],
],
'static (callable() : string) getCallable()' => [
'name' => 'getCallable',
'returnType' => 'callable():string',
'is_static' => true,
'params' => [],
],
];
$res = [];
foreach ($data as $key => $item) {
$res[$key] = [
'annotation' => $key,
'expected' => $item,
];
}
return $res;
}
/**
* @dataProvider providerMethodAnnotation
*/
public function testMethodAnnotation(string $annotation, array $expected): void
{
$full_content = <<<EOF
<?php
/**
* @method $annotation
*/
class MyClass {}
EOF;
$this->addFile('somefile.php', $full_content);
$codebase = $this->project_analyzer->getCodebase();
$codebase->scanFiles();
$class_storage = $codebase->classlike_storage_provider->get('MyClass');
$methods = $expected['is_static']
? $class_storage->pseudo_static_methods
: $class_storage->pseudo_methods;
$method = array_values($methods)[0];
$actual = [
'name' => $method->cased_name,
'returnType' => (string) $method->return_type,
'is_static' => $method->is_static,
'params' => [],
];
foreach ($method->params as $param) {
$actual['params'][$param->name] = [
'type' => (string) $param->type,
];
}
$this->assertEquals($expected, $actual);
}
}