danog/psalm
1
0
Fork 0
mirror of https://github.com/danog/psalm.git synced 2025-01-22 05:41:20 +01:00
Code Issues Projects Releases Wiki Activity

Remove nonsensical taint analysis rule

Browse Source
This commit is contained in:
Matt Brown 2022-06-08 16:00:06 -04:00
parent 006f441198
commit 6d09c3c794
1 changed files with 4 additions and 33 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
src/Psalm/Internal/Analyzer/Statements/Expression/AssignmentAnalyzer.php
View File

@ -776,24 +776,11 @@ class AssignmentAnalyzer
): void {
$parent_nodes = $type->parent_nodes;
$unspecialized_parent_nodes = array_filter(
$parent_nodes,
static fn($parent_node): bool => !$parent_node->specialization_key
);
$new_parent_node = DataFlowNode::getForAssignment($var_id, $var_location);
$data_flow_graph->addNode($new_parent_node);
$new_parent_nodes = [$new_parent_node->id => $new_parent_node];
$specialized_parent_nodes = array_filter(
$parent_nodes,
static fn($parent_node): bool => (bool) $parent_node->specialization_key
);
$new_parent_nodes = [];
foreach ($specialized_parent_nodes as $parent_node) {
$new_parent_node = DataFlowNode::getForAssignment($var_id, $var_location);
$new_parent_node->specialization_key = $parent_node->specialization_key;
$data_flow_graph->addNode($new_parent_node);
$new_parent_nodes += [$new_parent_node->id => $new_parent_node];
foreach ($parent_nodes as $parent_node) {
$data_flow_graph->addPath(
$parent_node,
$new_parent_node,
@ -803,22 +790,6 @@ class AssignmentAnalyzer
);
}
if ($unspecialized_parent_nodes) {
$new_parent_node = DataFlowNode::getForAssignment($var_id, $var_location);
$data_flow_graph->addNode($new_parent_node);
$new_parent_nodes += [$new_parent_node->id => $new_parent_node];
foreach ($unspecialized_parent_nodes as $parent_node) {
$data_flow_graph->addPath(
$parent_node,
$new_parent_node,
'=',
$added_taints,
$removed_taints
);
}
}
$type->parent_nodes = $new_parent_nodes;
}