1
0
mirror of https://github.com/danog/psalm.git synced 2024-12-02 09:37:59 +01:00

Apply suggestions from code review

This commit is contained in:
Bruce Weirdan 2024-02-04 15:41:01 -04:00
parent 8396360d30
commit 6d572a681c
No known key found for this signature in database
GPG Key ID: CFC3AAB181751B0D

View File

@ -6,8 +6,6 @@ use Psalm\Config;
use Psalm\Tests\Traits\InvalidCodeAnalysisTestTrait; use Psalm\Tests\Traits\InvalidCodeAnalysisTestTrait;
use Psalm\Tests\Traits\ValidCodeAnalysisTestTrait; use Psalm\Tests\Traits\ValidCodeAnalysisTestTrait;
use const DIRECTORY_SEPARATOR;
class OverrideTest extends TestCase class OverrideTest extends TestCase
{ {
use ValidCodeAnalysisTestTrait; use ValidCodeAnalysisTestTrait;
@ -83,7 +81,7 @@ class OverrideTest extends TestCase
public function f(): void {} public function f(): void {}
} }
', ',
'error_message' => 'InvalidOverride - src' . DIRECTORY_SEPARATOR . 'somefile.php:3:25', 'error_message' => 'InvalidOverride',
'error_levels' => [], 'error_levels' => [],
'php_version' => '8.3', 'php_version' => '8.3',
], ],
@ -97,7 +95,7 @@ class OverrideTest extends TestCase
public function f(): void {} public function f(): void {}
} }
', ',
'error_message' => 'MissingOverrideAttribute - src' . DIRECTORY_SEPARATOR . 'somefile.php:7:25', 'error_message' => 'MissingOverrideAttribute',
'error_levels' => [], 'error_levels' => [],
'php_version' => '8.3', 'php_version' => '8.3',
], ],
@ -113,7 +111,7 @@ class OverrideTest extends TestCase
public function f(): void {} public function f(): void {}
} }
', ',
'error_message' => 'MissingOverrideAttribute - src' . DIRECTORY_SEPARATOR . 'somefile.php:9:25', 'error_message' => 'MissingOverrideAttribute',
'error_levels' => [], 'error_levels' => [],
'php_version' => '8.3', 'php_version' => '8.3',
], ],
@ -131,7 +129,7 @@ class OverrideTest extends TestCase
public function __construct() {} public function __construct() {}
} }
', ',
'error_message' => 'InvalidOverride - src' . DIRECTORY_SEPARATOR . 'somefile.php:10:25', 'error_message' => 'InvalidOverride',
'error_levels' => [], 'error_levels' => [],
'php_version' => '8.3', 'php_version' => '8.3',
], ],
@ -145,7 +143,7 @@ class OverrideTest extends TestCase
public function f(): void; public function f(): void;
} }
', ',
'error_message' => 'MissingOverrideAttribute - src' . DIRECTORY_SEPARATOR . 'somefile.php:7:25', 'error_message' => 'MissingOverrideAttribute',
'error_levels' => [], 'error_levels' => [],
'php_version' => '8.3', 'php_version' => '8.3',
], ],
@ -160,7 +158,7 @@ class OverrideTest extends TestCase
private function f(): void {} private function f(): void {}
} }
', ',
'error_message' => 'InvalidOverride - src' . DIRECTORY_SEPARATOR . 'somefile.php:7:25', 'error_message' => 'InvalidOverride',
'error_levels' => [], 'error_levels' => [],
'php_version' => '8.3', 'php_version' => '8.3',
], ],
@ -171,7 +169,7 @@ class OverrideTest extends TestCase
public function f(): void; public function f(): void;
} }
', ',
'error_message' => 'InvalidOverride - src' . DIRECTORY_SEPARATOR . 'somefile.php:3:25', 'error_message' => 'InvalidOverride',
'error_levels' => [], 'error_levels' => [],
'php_version' => '8.3', 'php_version' => '8.3',
], ],