danog/psalm
1
0
Fork 0
mirror of https://github.com/danog/psalm.git synced 2024-11-30 04:39:00 +01:00
Code Issues Projects Releases Wiki Activity

Clean up more unused @psalm-suppress annotations

Browse Source
This commit is contained in:
Matthew Brown 2019-08-18 16:59:56 -04:00
parent c5f62d261d
commit 6ea68e9f7f
10 changed files with 18 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/Psalm/Config/FileFilter.php
View File

@ -75,17 +75,8 @@ class FileFilter
*/
protected $declare_strict_types = [];
/**
* @param bool $inclusive
*
* @psalm-suppress DocblockTypeContradiction
*/
public function __construct($inclusive)
public function __construct(bool $inclusive)
{
if (!is_bool($inclusive)) {
throw new \InvalidArgumentException('Filter arg must be bool');
}
$this->inclusive = $inclusive;
}

4
src/Psalm/Internal/Codebase/Analyzer.php
View File

@ -539,10 +539,6 @@ class Analyzer
$codebase->file_reference_provider->addIssue($issue_data['file_path'], $issue_data);
}
}
if ($codebase->track_unused_suppressions) {
IssueBuffer::processUnusedSuppressions($codebase->file_provider);
}
}
/**

1
src/Psalm/Internal/Diff/NamespaceStatementsDiffer.php
View File

@ -34,7 +34,6 @@ class NamespaceStatementsDiffer extends AstDiffer
/**
* @param string $a_code
* @param string $b_code
* @psalm-suppress UnusedParam
*
* @return bool
*/

4
src/Psalm/Internal/Fork/PsalmRestarter.php
View File

@ -34,8 +34,6 @@ class PsalmRestarter extends \Composer\XdebugHandler\XdebugHandler
}
/**
* @psalm-suppress UnusedMethod
*
* @param mixed $loaded
*/
protected function requiresRestart($loaded)
@ -56,8 +54,6 @@ class PsalmRestarter extends \Composer\XdebugHandler\XdebugHandler
}
/**
* @psalm-suppress UnusedMethod
*
* @param mixed $command
*
* @return void

1
src/Psalm/Internal/LanguageServer/EmitterTrait.php
View File

@ -122,7 +122,6 @@ trait EmitterTrait
// The list is not sorted
if (!$this->listeners[$eventName][0]) {
// Sorting
/** @psalm-suppress MixedArgument */
\array_multisort($this->listeners[$eventName][1], SORT_NUMERIC, $this->listeners[$eventName][2]);
// Marking the listeners as sorted

2
src/Psalm/Internal/PluginManager/Command/ShowCommand.php
View File

@ -30,7 +30,6 @@ class ShowCommand extends Command
/**
* @return void
* @psalm-suppress UnusedMethod
*/
protected function configure()
{
@ -42,7 +41,6 @@ class ShowCommand extends Command
/**
* @return null|int
* @psalm-suppress UnusedMethod
*/
protected function execute(InputInterface $i, OutputInterface $o)
{

1
src/Psalm/Internal/Visitor/SimpleNameResolver.php
View File

@ -175,7 +175,6 @@ class SimpleNameResolver extends NodeVisitorAbstract
* @param PhpParser\Node|string|null $node
*
* @return null|PhpParser\Node\Identifier|PhpParser\Node\Name|PhpParser\Node\NullableType
* @psalm-suppress MoreSpecificReturnType
* @psalm-suppress InvalidReturnType
* @psalm-suppress InvalidReturnStatement
*/

1
tests/PsalmPluginTest.php
View File

@ -142,7 +142,6 @@ class PsalmPluginTest extends TestCase
* @return void
* @dataProvider commands
* @test
* @psalm-suppress RedundantConditionGivenDocblockType
*/
public function showsHelpForCommand(string $command)
{

4
tests/TestCase.php
View File

@ -105,9 +105,7 @@ class TestCase extends BaseTestCase
$this->project_analyzer->interpretRefactors();
}
if ($track_unused_suppressions) {
$this->project_analyzer->trackUnusedSuppressions();
}
$this->project_analyzer->trackUnusedSuppressions();
$file_analyzer = new FileAnalyzer(
$this->project_analyzer,

17
tests/UnusedCodeTest.php
View File

@ -64,6 +64,8 @@ class UnusedCodeTest extends TestCase
$this->analyzeFile($file_path, $context, false);
$this->project_analyzer->checkClassReferences();
\Psalm\IssueBuffer::processUnusedSuppressions($this->project_analyzer->getCodebase()->file_provider);
}
/**
@ -98,9 +100,11 @@ class UnusedCodeTest extends TestCase
$context = new Context();
$context->collect_references = true;
$this->analyzeFile($file_path, $context);
$this->analyzeFile($file_path, $context, false);
$this->project_analyzer->checkClassReferences();
\Psalm\IssueBuffer::processUnusedSuppressions($this->project_analyzer->getCodebase()->file_provider);
}
/**
@ -499,6 +503,17 @@ class UnusedCodeTest extends TestCase
return $foo;
}',
],
'suppressUnusedMethod' => [
'<?php
class A {
/**
* @psalm-suppress UnusedMethod
*/
public function foo() : void {}
}
new A();'
],
];
}