danog/psalm
1
0
Fork 0
mirror of https://github.com/danog/psalm.git synced 2024-11-26 20:34:47 +01:00
Code Issues Projects Releases Wiki Activity

Fix text-labels with type of property

Browse Source 
The labels for magic and declared properties must be equal.
This commit is contained in:
Ivan Sidorov 2023-11-17 11:41:53 +00:00
parent 650b8fcd1b
commit 6f19440b02
2 changed files with 43 additions and 43 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Psalm/Codebase.php
View File

@ -1954,7 +1954,7 @@ final class Codebase
if ($property_storage->is_static || $gap === '->') { if ($property_storage->is_static || $gap === '->') {
$completion_items[] = new CompletionItem( $completion_items[] = new CompletionItem(
'$' . $property_name, $property_name,
CompletionItemKind::PROPERTY, CompletionItemKind::PROPERTY,
$property_storage->getInfo(), $property_storage->getInfo(),
$property_storage->description, $property_storage->description,

84
tests/Internal/Codebase/MethodGetCompletionItemsForClassishThingTest.php
View File

@ -128,13 +128,13 @@ final class MethodGetCompletionItemsForClassishThingTest extends TestCase
'magicObjMethod', 'magicObjMethod',
'magicStaticMethod', 'magicStaticMethod',
'$publicObjProp', 'publicObjProp',
'$protectedObjProp', 'protectedObjProp',
'$privateObjProp', 'privateObjProp',
'$publicStaticProp', 'publicStaticProp',
'$protectedStaticProp', 'protectedStaticProp',
'$privateStaticProp', 'privateStaticProp',
'publicObjMethod', 'publicObjMethod',
'protectedObjMethod', 'protectedObjMethod',
@ -149,9 +149,9 @@ final class MethodGetCompletionItemsForClassishThingTest extends TestCase
'magicObjProp2', 'magicObjProp2',
'magicStaticMethod', 'magicStaticMethod',
'$publicStaticProp', 'publicStaticProp',
'$protectedStaticProp', 'protectedStaticProp',
'$privateStaticProp', 'privateStaticProp',
'publicStaticMethod', 'publicStaticMethod',
'protectedStaticMethod', 'protectedStaticMethod',
@ -209,13 +209,13 @@ final class MethodGetCompletionItemsForClassishThingTest extends TestCase
'magicObjMethod', 'magicObjMethod',
'magicStaticMethod', 'magicStaticMethod',
'$publicObjProp', 'publicObjProp',
'$protectedObjProp', 'protectedObjProp',
'$privateObjProp', 'privateObjProp',
'$publicStaticProp', 'publicStaticProp',
'$protectedStaticProp', 'protectedStaticProp',
'$privateStaticProp', 'privateStaticProp',
'abstractPublicMethod', 'abstractPublicMethod',
'abstractProtectedMethod', 'abstractProtectedMethod',
@ -233,9 +233,9 @@ final class MethodGetCompletionItemsForClassishThingTest extends TestCase
'magicObjProp2', 'magicObjProp2',
'magicStaticMethod', 'magicStaticMethod',
'$publicStaticProp', 'publicStaticProp',
'$protectedStaticProp', 'protectedStaticProp',
'$privateStaticProp', 'privateStaticProp',
'publicStaticMethod', 'publicStaticMethod',
'protectedStaticMethod', 'protectedStaticMethod',
@ -296,21 +296,21 @@ final class MethodGetCompletionItemsForClassishThingTest extends TestCase
'magicObjMethod', 'magicObjMethod',
'$publicObjProp', 'publicObjProp',
'$protectedObjProp', 'protectedObjProp',
'$privateObjProp', 'privateObjProp',
'$publicStaticProp', 'publicStaticProp',
'$protectedStaticProp', 'protectedStaticProp',
'$privateStaticProp', 'privateStaticProp',
], ],
'::' => [ '::' => [
'magicObjProp1', 'magicObjProp1',
'magicObjProp2', 'magicObjProp2',
'$publicStaticProp', 'publicStaticProp',
'$protectedStaticProp', 'protectedStaticProp',
'$privateStaticProp', 'privateStaticProp',
], ],
]; ];
@ -367,21 +367,21 @@ final class MethodGetCompletionItemsForClassishThingTest extends TestCase
'magicObjMethod', 'magicObjMethod',
'$publicObjProp', 'publicObjProp',
'$protectedObjProp', 'protectedObjProp',
'$privateObjProp', 'privateObjProp',
'$publicStaticProp', 'publicStaticProp',
'$protectedStaticProp', 'protectedStaticProp',
'$privateStaticProp', 'privateStaticProp',
], ],
'::' => [ '::' => [
'magicObjProp1', 'magicObjProp1',
'magicObjProp2', 'magicObjProp2',
'$publicStaticProp', 'publicStaticProp',
'$protectedStaticProp', 'protectedStaticProp',
'$privateStaticProp', 'privateStaticProp',
], ],
]; ];
@ -435,18 +435,18 @@ final class MethodGetCompletionItemsForClassishThingTest extends TestCase
'magicObjMethod', 'magicObjMethod',
'$publicObjProp', 'publicObjProp',
'$protectedObjProp', 'protectedObjProp',
'$publicStaticProp', 'publicStaticProp',
'$protectedStaticProp', 'protectedStaticProp',
], ],
'::' => [ '::' => [
'magicObjProp1', 'magicObjProp1',
'magicObjProp2', 'magicObjProp2',
'$publicStaticProp', 'publicStaticProp',
'$protectedStaticProp', 'protectedStaticProp',
], ],
]; ];