From 6f96c661ef58a4d2b398f90bdedf52066ca6e2e2 Mon Sep 17 00:00:00 2001
From: Matthew Brown <github@muglug.com>
Date: Mon, 16 Jul 2018 20:52:58 -0400
Subject: [PATCH] Fix #881 - skip tests if necessary test classes are missing

---
 tests/BinaryOperationTest.php | 120 +++++++++++++++++++++-------------
 tests/ClassTest.php           |  63 +++++++++++-------
 2 files changed, 112 insertions(+), 71 deletions(-)

diff --git a/tests/BinaryOperationTest.php b/tests/BinaryOperationTest.php
index 22c542f75..e62b1fedb 100644
--- a/tests/BinaryOperationTest.php
+++ b/tests/BinaryOperationTest.php
@@ -6,6 +6,80 @@ class BinaryOperationTest extends TestCase
     use Traits\FileCheckerInvalidCodeParseTestTrait;
     use Traits\FileCheckerValidCodeParseTestTrait;
 
+    /**
+     * @return void
+     */
+    public function testGMPOperations()
+    {
+        if (class_exists('GMP') === false) {
+            $this->markTestSkipped('Cannot run test, base class "GMP" does not exist!');
+
+            return;
+        }
+
+        $this->addFile(
+            'somefile.php',
+            '<?php
+                $a = gmp_init(2);
+                $b = gmp_init(4);
+                $c = $a + $b;
+                $d = $c + 3;
+                echo $d;
+                $f = $a / $b;
+                $g = $a ** $b;
+                $h = $a % $b;
+
+                $i = 6 + $b;
+                $j = 6 - $b;
+                $k = 6 * $b;
+                $l = 6 / $b;
+                $m = 6 ** $b;
+                $n = 6 % $b;
+
+                $o = $a + 6;
+                $p = $a - 6;
+                $q = $a * 6;
+                $r = $a / 6;
+                $s = $a ** 6;
+                $t = $a % 6;'
+        );
+
+        $assertions = [
+            '$a' => 'GMP',
+            '$b' => 'GMP',
+            '$c' => 'GMP',
+            '$d' => 'GMP',
+            '$f' => 'GMP',
+            '$g' => 'GMP',
+            '$h' => 'GMP',
+            '$i' => 'GMP',
+            '$j' => 'GMP',
+            '$k' => 'GMP',
+            '$l' => 'GMP',
+            '$m' => 'GMP',
+            '$n' => 'GMP',
+            '$o' => 'GMP',
+            '$p' => 'GMP',
+            '$q' => 'GMP',
+            '$r' => 'GMP',
+            '$s' => 'GMP',
+            '$t' => 'GMP',
+        ];
+
+        $context = new \Psalm\Context();
+
+        $this->analyzeFile('somefile.php', $context);
+
+        $actual_vars = [];
+        foreach ($assertions as $var => $_) {
+            if (isset($context->vars_in_scope[$var])) {
+                $actual_vars[$var] = (string)$context->vars_in_scope[$var];
+            }
+        }
+
+        $this->assertSame($assertions, $actual_vars);
+    }
+
     /**
      * @return array
      */
@@ -61,52 +135,6 @@ class BinaryOperationTest extends TestCase
                     '$f' => 'string',
                 ],
             ],
-            'gmpOperations' => [
-                '<?php
-                    $a = gmp_init(2);
-                    $b = gmp_init(4);
-                    $c = $a + $b;
-                    $d = $c + 3;
-                    echo $d;
-                    $f = $a / $b;
-                    $g = $a ** $b;
-                    $h = $a % $b;
-
-                    $i = 6 + $b;
-                    $j = 6 - $b;
-                    $k = 6 * $b;
-                    $l = 6 / $b;
-                    $m = 6 ** $b;
-                    $n = 6 % $b;
-
-                    $o = $a + 6;
-                    $p = $a - 6;
-                    $q = $a * 6;
-                    $r = $a / 6;
-                    $s = $a ** 6;
-                    $t = $a % 6;',
-                'assertions' => [
-                    '$a' => 'GMP',
-                    '$b' => 'GMP',
-                    '$c' => 'GMP',
-                    '$d' => 'GMP',
-                    '$f' => 'GMP',
-                    '$g' => 'GMP',
-                    '$h' => 'GMP',
-                    '$i' => 'GMP',
-                    '$j' => 'GMP',
-                    '$k' => 'GMP',
-                    '$l' => 'GMP',
-                    '$m' => 'GMP',
-                    '$n' => 'GMP',
-                    '$o' => 'GMP',
-                    '$p' => 'GMP',
-                    '$q' => 'GMP',
-                    '$r' => 'GMP',
-                    '$s' => 'GMP',
-                    '$t' => 'GMP',
-                ],
-            ],
             'booleanXor' => [
                 '<?php
                     $a = true ^ false;
diff --git a/tests/ClassTest.php b/tests/ClassTest.php
index 2b6eea08a..b022471f4 100644
--- a/tests/ClassTest.php
+++ b/tests/ClassTest.php
@@ -6,6 +6,44 @@ class ClassTest extends TestCase
     use Traits\FileCheckerInvalidCodeParseTestTrait;
     use Traits\FileCheckerValidCodeParseTestTrait;
 
+    /**
+     * @return void
+     */
+    public function testExtendsMysqli()
+    {
+        if (class_exists('mysqli') === false) {
+            $this->markTestSkipped('Cannot run test, base class "mysqli" does not exist!');
+
+            return;
+        }
+
+        $this->addFile(
+            'somefile.php',
+            '<?php
+                class db extends mysqli {
+                    public function close()
+                    {
+                        return true;
+                    }
+
+                    public function prepare(string $sql)
+                    {
+                        return false;
+                    }
+
+                    public function commit(?int $flags = null, ?string $name = null)
+                    {
+                        return true;
+                    }
+
+                    public function real_escape_string(string $string)
+                    {
+                        return "escaped";
+                    }
+                }'
+        );
+    }
+
     /**
      * @return array
      */
@@ -153,31 +191,6 @@ class ClassTest extends TestCase
                       return $maybeBaz;
                     }',
             ],
-            'extendsMysqli' => [
-                '<?php
-                    class db extends mysqli
-                    {
-                        public function close()
-                        {
-                            return true;
-                        }
-
-                        public function prepare(string $sql)
-                        {
-                            return false;
-                        }
-
-                        public function commit(?int $flags = null, ?string $name = null)
-                        {
-                            return true;
-                        }
-
-                        public function real_escape_string(string $string)
-                        {
-                            return "escaped";
-                        }
-                    }',
-            ],
             'assignAnonymousClassToArray' => [
                 '<?php
                     /**