danog/psalm
1
0
Fork 0
mirror of https://github.com/danog/psalm.git synced 2024-11-27 04:45:20 +01:00
Code Issues Projects Releases Wiki Activity

Fix $function_id when checking for method existence

Browse Source
This commit is contained in:
Matthew Brown 2018-03-01 23:52:11 -05:00
parent cc19f50c04
commit 6fbd8753d5
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/Psalm/Checker/Statements/Expression/CallChecker.php
View File

@ -957,10 +957,10 @@ class CallChecker
return;
}
$function_id = $callable_fq_class_name . '::' . $method_name;
try {
$method_storage = $codebase->methods->getStorage(
$callable_fq_class_name . '::' . $method_name
);
$method_storage = $codebase->methods->getStorage($function_id);
} catch (\UnexpectedValueException $e) {
// the method may not exist, but we're suppressing that issue
return;
@ -1380,7 +1380,7 @@ class CallChecker
foreach ($function_ids as $function_id) {
if (strpos($function_id, '::') !== false) {
list($callable_fq_class_name) = explode('::', $function_id);
list($callable_fq_class_name, $method_name) = explode('::', $function_id);
switch ($callable_fq_class_name) {
case 'self':
@ -1399,6 +1399,8 @@ class CallChecker
$callable_fq_class_name = $container_class;
}
$function_id = $callable_fq_class_name . '::' . $method_name;
if (ClassLikeChecker::checkFullyQualifiedClassLikeName(
$statements_checker,
$callable_fq_class_name,