danog/psalm
1
0
Fork 0
mirror of https://github.com/danog/psalm.git synced 2025-01-21 21:31:13 +01:00
Code Issues Projects Releases Wiki Activity

Fix not always positive bit operations (#5233)

Browse Source 
* Fix not always positive bit operations

* Fix not always positive bit operations

* add test
This commit is contained in:
orklah 2021-02-16 05:10:42 +01:00 committed by GitHub
parent 5191dac3fa
commit 7b24552534
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 40 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/Psalm/Internal/Analyzer/Statements/Expression/BinaryOp/NonDivArithmeticOpAnalyzer.php
View File

@ -663,7 +663,15 @@ class NonDivArithmeticOpAnalyzer
if ($parent instanceof PhpParser\Node\Expr\BinaryOp\Minus) {
$always_positive = false;
} elseif ($left_is_positive && $right_is_positive) {
$always_positive = true;
if ($parent instanceof PhpParser\Node\Expr\BinaryOp\BitwiseXor
|| $parent instanceof PhpParser\Node\Expr\BinaryOp\BitwiseAnd
|| $parent instanceof PhpParser\Node\Expr\BinaryOp\ShiftLeft
|| $parent instanceof PhpParser\Node\Expr\BinaryOp\ShiftRight
) {
$always_positive = false;
} else {
$always_positive = true;
}
} elseif ($parent instanceof PhpParser\Node\Expr\BinaryOp\Plus
&& ($left_type_part instanceof TLiteralInt && $left_type_part->value === 0)
&& $right_is_positive

31
tests/BinaryOperationTest.php
View File

@ -357,6 +357,37 @@ class BinaryOperationTest extends TestCase
function foo($a, $b): void {
onlyZeroOrPlusMinusOne($a <=> $b);
}'
],
'notAlwaysPositiveBitOperations' => [
'<?php
$a = 1;
$b = 1;
$c = 32;
$d = 64;
$e = 2;
if (0 === ($a ^ $b)) {
echo "Actually, zero\n";
}
if (0 === ($a & $e)) {
echo "Actually, zero\n";
}
if (0 === ($a >> $b)) {
echo "Actually, zero\n";
}
if (8 === PHP_INT_SIZE) {
if (0 === ($a << $d)) {
echo "Actually, zero\n";
}
} else {
if (0 === ($a << $c)) {
echo "Actually, zero\n";
}
}'
]
];
}