danog/psalm
1
0
Fork 0
mirror of https://github.com/danog/psalm.git synced 2024-11-26 20:34:47 +01:00
Code Issues Projects Releases Wiki Activity

Fix checks for possibly null right part of binary op

Browse Source
This commit is contained in:
Matthew Brown 2018-07-03 19:52:40 -04:00
parent 76a3fbbdf0
commit 7d747be5d5
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Psalm/Checker/Statements/Expression/BinaryOpChecker.php
View File

@ -651,7 +651,7 @@ class BinaryOpChecker
return;
}
if ($right_type->isNullable() && $right_type->ignore_falsable_issues) {
if ($right_type->isNullable() && !$right_type->ignore_nullable_issues) {
if ($statements_source && IssueBuffer::accepts(
new PossiblyNullOperand(
'Right operand cannot be nullable, got ' . $right_type,

5
tests/BinaryOperationTest.php
View File

@ -217,6 +217,11 @@ class BinaryOperationTest extends TestCase
$a++;',
'error_message' => 'InvalidOperand',
],
'possiblyDivByZero' => [
'<?php
$a = 5 / (rand(0, 1) ? 2 : null);',
'error_message' => 'PossiblyNullOperand',
],
];
}
}