Allow by reference parameters in method docblock (#4873)

src/Psalm/Internal/Type/ParseTreeCreator.php

@@ -157,10 +157,10 @@ class ParseTreeCreator
         $default = '';
 
         if ($current_token[0] === '&') {
-            throw new TypeParseTreeException('Magic args cannot be passed by reference');
+            $byref = true;
-        }
+            ++$this->t;
-
+            $current_token = $this->t < $this->type_token_count ? $this->type_tokens[$this->t] : null;
-        if ($current_token[0] === '...') {
+        } elseif ($current_token[0] === '...') {
             $variadic = true;
 
             ++$this->t;
@@ -648,7 +648,7 @@ class ParseTreeCreator
 
         $current_parent = $this->current_leaf->parent;
 
-        if ($this->current_leaf instanceof ParseTree\MethodTree && $current_parent) {
+        if ($current_parent && $current_parent instanceof ParseTree\MethodTree) {
             $this->createMethodParam($this->type_tokens[$this->t], $current_parent);
             return;
         }

tests/MagicMethodAnnotationTest.php

@@ -204,6 +204,26 @@ class MagicMethodAnnotationTest extends TestCase
                     $child->setArray(["boo"]);
                     $child->setArray(["boo"], 8);',
             ],
+            'validAnnotationWithByRefParam' => [
+                '<?php
+                    class ParentClass {
+                        public function __call(string $name, array $args) {}
+                    }
+
+                    /**
+                     * @template T
+                     * @method void configure(string $string, array &$arr)
+                     */
+                    class Child extends ParentClass
+                    {
+                        /** @psalm-param T $t */
+                        public function getChild($t): void {}
+                    }
+                    $child = new Child();
+
+                    $array = [];
+                    $child->configure("foo", $array);',
+            ],
             'validAnnotationWithNonEmptyDefaultArray' => [
                 '<?php
                     class ParentClass {