danog/psalm
1
0
Fork 0
mirror of https://github.com/danog/psalm.git synced 2024-12-14 02:07:37 +01:00
Code Issues Projects Releases Wiki Activity

Unrelated: Use strict_equality instead of loose_equality for === checks

Browse Source 
(`=` is strict equality, `~` is loose equality)
This commit is contained in:
Tyson Andre 2021-09-06 21:26:43 -04:00
parent f69a255611
commit 7df819e585
1 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/Psalm/Internal/Analyzer/Statements/Expression/AssertionFinder.php
View File

@ -465,7 +465,7 @@ class AssertionFinder
if ($var_name_left && if ($var_name_left &&
(!$var_type->isSingle() || $var_type->getAssertionString() !== $assertion)) { (!$var_type->isSingle() || $var_type->getAssertionString() !== $assertion)) {
$if_types[$var_name_left] = [['~'.$assertion]]; $if_types[$var_name_left] = [['='.$assertion]];
} }
$var_name_right = ExpressionIdentifier::getArrayVarId( $var_name_right = ExpressionIdentifier::getArrayVarId(
@ -476,7 +476,7 @@ class AssertionFinder
if ($var_name_right && if ($var_name_right &&
(!$other_type->isSingle() || $other_type->getAssertionString() !== $assertion)) { (!$other_type->isSingle() || $other_type->getAssertionString() !== $assertion)) {
$if_types[$var_name_right] = [['~'.$assertion]]; $if_types[$var_name_right] = [['='.$assertion]];
} }
return $if_types ? [$if_types] : []; return $if_types ? [$if_types] : [];
@ -3456,14 +3456,13 @@ class AssertionFinder
} }
} else { } else {
foreach ($value_type->getAtomicTypes() as $atomic_value_type) { foreach ($value_type->getAtomicTypes() as $atomic_value_type) {
if ($atomic_value_type instanceof Type\Atomic\TLiteralInt if ($atomic_value_type instanceof Type\Atomic\TFalse
|| $atomic_value_type instanceof Type\Atomic\TLiteralString || $atomic_value_type instanceof Type\Atomic\TTrue
|| $atomic_value_type instanceof Type\Atomic\TLiteralFloat || $atomic_value_type instanceof Type\Atomic\TNull
|| $atomic_value_type instanceof Type\Atomic\TEnumCase
) { ) {
$assertions[] = '=' . $atomic_value_type->getAssertionString();
} else {
$assertions[] = $atomic_value_type->getAssertionString(); $assertions[] = $atomic_value_type->getAssertionString();
} else {
$assertions[] = '=' . $atomic_value_type->getAssertionString();
} }
} }
} }