danog/psalm
1
0
Fork 0
mirror of https://github.com/danog/psalm.git synced 2024-11-26 20:34:47 +01:00
Code Issues Projects Releases Wiki Activity

Fix issue with unset var in loop

Browse Source
This commit is contained in:
Matt Brown 2017-03-15 11:38:23 -04:00
parent 16c10c8710
commit 7fad81edac
2 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/Psalm/Checker/StatementsChecker.php
View File

@ -400,6 +400,12 @@ class StatementsChecker extends SourceChecker implements StatementsSource
}
}
foreach ($asserted_vars as $var_id) {
if (!isset($loop_context->vars_in_scope[$var_id])) {
$loop_context->vars_in_scope[$var_id] = $pre_loop_context->vars_in_scope[$var_id];
}
}
// if there are no changes to the types, no need to re-examine
if (!$has_changes) {
break;

18
tests/LoopScopeTest.php
View File

@ -550,6 +550,24 @@ class LoopScopeTest extends PHPUnit_Framework_TestCase
$file_checker->visitAndAnalyzeMethods();
}
/**
* @return void
*/
public function testUnsetInLoop()
{
$stmts = self::$parser->parse('<?php
$a = null;
foreach ([1, 2, 3] as $i) {
$a = $i;
unset($i);
}
');
$file_checker = new FileChecker('somefile.php', $this->project_checker, $stmts);
$file_checker->visitAndAnalyzeMethods();
}
/**
* @return void
*/