Allow updating array by reference

src/Psalm/Internal/Analyzer/Statements/Expression/Call/ArgumentsAnalyzer.php

@@ -1064,9 +1064,19 @@ class ArgumentsAnalyzer
         }
 
         if (!$arg->value instanceof PhpParser\Node\Expr\Variable) {
+            $suppressed_issues = $statements_analyzer->getSuppressedIssues();
+
+            if (!in_array('EmptyArrayAccess', $suppressed_issues, true)) {
+                $statements_analyzer->addSuppressedIssues(['EmptyArrayAccess']);
+            }
+
             if (ExpressionAnalyzer::analyze($statements_analyzer, $arg->value, $context) === false) {
                 return false;
             }
+
+            if (!in_array('EmptyArrayAccess', $suppressed_issues, true)) {
+                $statements_analyzer->removeSuppressedIssues(['EmptyArrayAccess']);
+            }
         }
     }
 }

tests/ReferenceConstraintTest.php

@@ -143,6 +143,20 @@ class ReferenceConstraintTest extends TestCase
 
                     function bar(I &$i) : void {}',
             ],
+            'notEmptyArrayAccess' => [
+                '<?php
+                    /**
+                     * @param mixed $value
+                     * @param-out int $value
+                     */
+                    function addValue(&$value) : void {
+                        $value = 5;
+                    }
+
+                    $foo = [];
+
+                    addValue($foo["a"]);'
+            ],
         ];
     }