danog/psalm
1
0
Fork 0
mirror of https://github.com/danog/psalm.git synced 2024-11-30 04:39:00 +01:00
Code Issues Projects Releases Wiki Activity

Fix lowercase-string to constant string coercion

Browse Source
This commit is contained in:
Matthew Brown 2020-02-17 17:58:36 -05:00
parent 6a4e7931e6
commit 8dd49b1cbf
2 changed files with 30 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/Psalm/Internal/Analyzer/TypeAnalyzer.php
View File

@ -1276,6 +1276,18 @@ class TypeAnalyzer
return false;
}
if ($input_type_part instanceof Type\Atomic\TLowercaseString
&& $container_type_part instanceof TLiteralString
&& strtolower($container_type_part->value) === $container_type_part->value
) {
if ($atomic_comparison_result) {
$atomic_comparison_result->type_coerced = true;
$atomic_comparison_result->type_coerced_from_scalar = true;
}
return false;
}
if (($container_type_part instanceof TClassString || $container_type_part instanceof TLiteralClassString)
&& ($input_type_part instanceof TClassString || $input_type_part instanceof TLiteralClassString)
) {

18
tests/ConstantTest.php
View File

@ -703,6 +703,24 @@ class ConstantTest extends TestCase
}
}'
],
'lowercaseStringAccessClassConstant' => [
'<?php
class A {
const C = [
"a" => 1,
"b" => 2,
"c" => 3
];
}
/**
* @param lowercase-string $s
*/
function foo(string $s, string $t) : void {
echo A::C[$t];
echo A::C[$s];
}'
],
];
}