danog/psalm
1
0
Fork 0
mirror of https://github.com/danog/psalm.git synced 2024-11-27 04:45:20 +01:00
Code Issues Projects Releases Wiki Activity

Allow union of 0|positive-int to bypass PossiblyUndefinedIntArrayOffset error

Browse Source
This commit is contained in:
Matt Brown 2021-05-23 13:59:40 -04:00
parent e89f7e3960
commit 938afc5aea
2 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/Psalm/Internal/Analyzer/Statements/Expression/Fetch/ArrayFetchAnalyzer.php
View File

@ -866,6 +866,11 @@ class ArrayFetchAnalyzer
$found_match = true;
break;
}
if ($offset_type_part instanceof Type\Atomic\TPositiveInt) {
$found_match = true;
break;
}
}
if (!$found_match) {

19
tests/ArrayAccessTest.php
View File

@ -335,6 +335,25 @@ class ArrayAccessTest extends TestCase
$this->analyzeFile('somefile.php', new \Psalm\Context());
}
public function testDontWorryWhenUnionedWithPositiveInt(): void
{
\Psalm\Config::getInstance()->ensure_array_int_offsets_exist = true;
$this->addFile(
'somefile.php',
'<?php
/**
* @param list<string> $a
* @param 0|positive-int $b
*/
function foo(array $a, int $b): void {
echo $a[$b];
}'
);
$this->analyzeFile('somefile.php', new \Psalm\Context());
}
/**
* @return iterable<string,array{string,assertions?:array<string,string>,error_levels?:string[]}>
*/